Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-10 Thread Keir Fraser
On 10 May 2006, at 00:51, Chris Wright wrote: * Herbert Xu ([EMAIL PROTECTED]) wrote: Chris Wright [EMAIL PROTECTED] wrote: + netdev-features= NETIF_F_IP_CSUM; Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter would seem to be in fact easier for a

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Herbert Xu
Hi Chris: Chris Wright [EMAIL PROTECTED] wrote: +/** Send a packet on a net device to encourage switches to learn the + * MAC. We send a fake ARP request. + * + * @param dev device + * @return 0 on success, error code otherwise + */ +static int send_fake_arp(struct net_device *dev) I

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Christian Limpach
On Tue, May 09, 2006 at 09:55:33PM +1000, Herbert Xu wrote: Hi Chris: Chris Wright [EMAIL PROTECTED] wrote: +/** Send a packet on a net device to encourage switches to learn the + * MAC. We send a fake ARP request. + * + * @param dev device + * @return 0 on success, error code

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Herbert Xu
Christian Limpach [EMAIL PROTECTED] wrote: There's at least two reasons why having it in the driver is preferable: - synchronizing sending the fake ARP request with when the device is operational -- you really want to make this well synchronized to keep unreachability as short as possible,

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Andi Kleen
On Tuesday 09 May 2006 15:01, Herbert Xu wrote: Christian Limpach [EMAIL PROTECTED] wrote: There's at least two reasons why having it in the driver is preferable: - synchronizing sending the fake ARP request with when the device is operational -- you really want to make this well

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Christian Limpach
On Tue, May 09, 2006 at 11:01:05PM +1000, Herbert Xu wrote: Christian Limpach [EMAIL PROTECTED] wrote: There's at least two reasons why having it in the driver is preferable: - synchronizing sending the fake ARP request with when the device is operational -- you really want to make this

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Herbert Xu
Christian Limpach [EMAIL PROTECTED] wrote: Possibly having to page in the process and switching to it would add to the live migration time. More importantly, having to install an additional program in the guest is certainly not very convenient. Sorry I'm still not convinced. What's there

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Christian Limpach
On Tue, May 09, 2006 at 11:26:03PM +1000, Herbert Xu wrote: Christian Limpach [EMAIL PROTECTED] wrote: Possibly having to page in the process and switching to it would add to the live migration time. More importantly, having to install an additional program in the guest is certainly not

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread David Boutcher
[EMAIL PROTECTED] wrote on 05/09/2006 09:00:27 AM: On Tue, May 09, 2006 at 11:26:03PM +1000, Herbert Xu wrote: Christian Limpach [EMAIL PROTECTED] wrote: Possibly having to page in the process and switching to it would add to the live migration time. More importantly, having to

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Herbert Xu
Chris Wright [EMAIL PROTECTED] wrote: + netdev-features= NETIF_F_IP_CSUM; Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter would seem to be in fact easier for a virtual driver, no? Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu

Re: [Xen-devel] [RFC PATCH 34/35] Add the Xen virtual network device driver.

2006-05-09 Thread Chris Wright
* Herbert Xu ([EMAIL PROTECTED]) wrote: Chris Wright [EMAIL PROTECTED] wrote: + netdev-features= NETIF_F_IP_CSUM; Any reason why IP_CSUM was chosen instead of HW_CSUM? Doing the latter would seem to be in fact easier for a virtual driver, no? That, I really don't know.