On Fri, 11 May 2007 14:40:45 +0900
Kenji Kaneshige [EMAIL PROTECTED] wrote:
Hi,
I encountered the following error when I was hot-plugging network card
using pci hotplug driver.
kobject_add failed for eth8 with -EEXIST, don't try to register things with
the same name in the same
On Fri, 11 May 2007 14:40:45 +0900
Kenji Kaneshige [EMAIL PROTECTED] wrote:
Hi,
I encountered the following error when I was hot-plugging network card
using pci hotplug driver.
kobject_add failed for eth8 with -EEXIST, don't try to register things with
the same name in the same
These are all bug fixes for 2.6.22. I'll spin a set for the
2.6.21 stable kernel after that.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
If the device is fails during module startup for some reason like
unsupported chip version then the driver would crash dereferencing a
null pointer, on shutdown or suspend/resume.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 10 ++
1 file changed, 10
Use DMI to add a blacklist of broken boards (so far only one).
Hopefully, the problems will be solved later, and the the whole
blacklist can disappear.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 41 ++---
1 file changed, 30
The driver is not ready to support 88e8071 chip.
If this chip is present, system will hang on boot.
So remove it from PCI device id's for now.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- sky2-2.6.21
If device is not fails during module startup (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c |9 +
1 file changed, 9 insertions(+)
--- sky2
On Sun, 13 May 2007 21:42:36 +0900 (JST)
Hirokazu Takahashi [EMAIL PROTECTED] wrote:
Hi,
I'm now thinking I can make it just hold a TSO packet until
p-tokens reaches the size of the packet. I think it is
straightforward implementation. I'll try this.
I re-implemented the patch, which
On Mon, 14 May 2007 10:33:01 +0900
Kenji Kaneshige [EMAIL PROTECTED] wrote:
Hi Stephen,
Thank you for comments. I'll try your patch.
I have one concern about your patch, though I don't know very much
about netdev codes.
@@ -3411,6 +3410,9 @@ void unregister_netdevice(struct net_dev
order slightly. It hold a removes the sysfs
entries earlier (on unregister_netdevice), but holds a kobject reference.
Then when todo runs the actual last put free happens.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/core/dev.c | 10 ++
net/core/net-sysfs.c |8
On Mon, 14 May 2007 10:20:26 -0400
Michael Stone [EMAIL PROTECTED] wrote:
On Tue, May 08, 2007 at 10:15:18AM -0700, Stephen Hemminger wrote:
On Tue, 08 May 2007 08:00:36 -0400
Michael Stone [EMAIL PROTECTED] wrote:
2.6.21 seems to have fixed the stability issues I was seeing when using
On Sun, 13 May 2007 11:55:29 -0400
Daniel Drake [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
I can use DMI to narrow down to one motherboard.
Or just let everything through and let user's discover what's unstable, it
fails
relatively quickly.
Could you please get full PCI
This workaround was added to deal with NAPI core and how
it affected dual port shared polling. It turned out not to
be necessary. Stopping device 0 only doesn't stop NAPI from
working completely after that.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |7
Make sure that if we ever get a MIB counter overflow interrupt (normally
masked off), that the IRQ is cleared.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |6 ++
1 file changed, 6 insertions(+)
--- 2.6.21-rc1.orig/drivers/net/sky2.c 2007-05-14 12:10
When driver can't allocate receive buffer it drops incoming
packet. Keep a counter.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- 2.6.21-rc1.orig/drivers/net/sky2.c 2007-05-14 12:10:13.0 -0700
The problems with Gigabyte motherboards are system configuration dependent.
Since it works fine for some users, it doesn't make sense to deprive
them.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 30 --
1 file changed, 30 deletions
These are less serious than the last group, and are mostly
one liners. I decided to give up blacklisting the 88e8056
problem in the driver, if the driver can't identify what configuration
is good/bad, then it has no business trying to enforce the policy.
--
Stephen Hemminger [EMAIL PROTECTED
);
+ /* end of interrupt, re-enables also acts as I/O
synchronization */
sky2_read32(hw, B0_Y2_SP_LISR);
return 0;
} else {
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
only)
version.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- 2.6.21-rc1.orig/drivers/net/sky2.c 2007-05-14 12:06:25.0 -0700
+++ 2.6.21-rc1/drivers/net/sky2.c 2007-05-14 12:10:13.0
On Mon, 14 May 2007 00:53:42 -0400
Florin Malita [EMAIL PROTECTED] wrote:
Hi Stephen,
Stephen Hemminger wrote:
Use DMI to add a blacklist of broken board. For now only one is known
bad. Gentoo users report driver works on other motherboards (strange).
[snip]
+ .ident
On Tue, 15 May 2007 15:43:39 -0400
[EMAIL PROTECTED] wrote:
Hello, Stephen,
RE: sky2 88e8056 Gigabyte GA-965GM-S2 uATX motherboard
A couple days ago I posted my observations that this was a hardware problem.
My boards are now working!
I used the GIGABYTE MOTHERBOARD webpage for
This is a backport of all the bugfixes in 2.6.22-rc1 (or later)
to 2.6.21.y
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The driver is not ready to support 88e8071 chip, it requires several
more changes (not done yet). If this chip is present, system will hang on boot.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux
Wake On Lan works correctly on Yukon-FE and other variants.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]a
---
drivers/net/skge.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
--- linux-2.6.21.y.orig/drivers/net/skge.c 2007-05-10 12:10:38.0
-0700
It looks like the problems of Gigabyte 88E8056 are unique to that chip
motherboard and maybe fixable by EEPROM update.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |3 ---
1 file changed, 3 deletions(-)
--- linux-2.6.21.y.orig/drivers/net/sky2.c 2007-05-15
If the device fails during module startup for some reason like unsupported chip
version then the driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 10 ++
1 file changed, 10
If device fails during module startup for some reason (like unsupported chip
version) then driver would crash dereferencing a null pointer, on shutdown
or suspend/resume.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/skge.c |9 +
1 file changed, 9 insertions
By default, the skge driver now enables wake on magic and wake on PHY.
This is a bad default (bug), wake on PHY means machine will never shutdown
if connected to a switch.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]a
---
drivers/net/skge.c |4 +++-
1 file changed, 3 insertions(+), 1
Add more comments to describe our version of tcp_slow_start().
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/ipv4/tcp_cong.c | 40 ++--
1 files changed, 22 insertions(+), 18 deletions(-)
diff --git a/net/ipv4/tcp_cong.c b/net/ipv4/tcp_cong.c
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops'. This will save memory for the
case of lots of devices, as well as reduce initialization code.
Rough plan:
1. Introduce inline accessors so protocols don't dereference dev-XXX directly.
2. Fix
On Thu, 17 May 2007 22:05:29 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Jeff Garzik [EMAIL PROTECTED]
Date: Fri, 18 May 2007 00:54:13 -0400
Stephen Hemminger wrote:
I want to take all the function pointers of 'struct net_device' and
move them to 'struct net_device_ops
On Fri, 18 May 2007 14:09:03 -0400
John W. Linville [EMAIL PROTECTED] wrote:
On Wed, May 16, 2007 at 05:01:27PM -0400, Florin Malita wrote:
In libertas_process_rxed_packet() and process_rxed_802_11_packet() the
skb is dereferenced after being passed to netif_rx (called from
of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Looks more like the IPV6 SNMP6 OOPS, I saw and fixed with:
commit 5632c5152aa621885d87ea0b8fdd5a6bb9f69c6f
Author: Stephen Hemminger [EMAIL PROTECTED]
Date: Sat Apr 28 21:16:39 2007 -0700
[IPV6
the the return value is informational only.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
(inet-saddr), ntohs(inet-sport),
NIPQUAD(inet-daddr), ntohs(inet-dport),
skb-len, tp-snd_nxt, tp-snd_una,
Looks good thanks
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message
The function in tcp_probe is printf like, use GCC to check the args.
Sighed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/ipv4/tcp_probe.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
--- a/net/ipv4/tcp_probe.c 2007-05-21 08:48:29.0 -0700
+++ b/net/ipv4
);
+}
+
+if ( (--accelerator-hooks_usecount) == 0 )
+accelerator_remove_hooks(accelerator);
+spin_unlock_irqrestore(accelerators_lock,
flags);
Your mailer is word wrapping the patch so it won't apply as is.
--
Stephen Hemminger
to be.
If you just used RCU for access, and depended on the existing RT netlink
mutex (a.k.a big network lock), for setup; then you wouldn't need to
do any of your own locking.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body
a macro... See earlier comments about suing RCU and eliminating
the refcount and locking overhead.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org
* in rcu callback you do last step
like drop module refcount and free.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 22 May 2007 21:47:22 +
Thomas B. Rücker [EMAIL PROTECTED] wrote:
hi,
a friend of mine recently contacted me about what he at first thought
were IPv6 issues with some java software.
As it turns out it probably is a general IP issue with the Linux kernel:
He wrote this piece
.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
. Actual usage varies
with chip type, and we don't need to mess with them (yet).
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.c2007-05-23 08:44:09.0 -0700
+++ b/drivers/net/sky2.c2007-05-23 08:47:11.0 -0700
@@ -658,7 +658,7 @@ static void
On Wed, 23 May 2007 16:59:02 -0500
Tony Petz [EMAIL PROTECTED] wrote:
I'm working on a research project that requires two simultaneously
running but independent TCP implementations. Searching the archives I
was only able to come up with this:
The following are non-critical fixes found during review
of code. I don't expect them to fix the outstanding bugzilla
or mailing list problem reports. Mostly they are of the form,
don't touch bits that aren't used on that chip.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from
Don't want IRQ on FIFO error because there is nothing useful to do with it.
But do want IRQ on duplex change.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.h2007-05-22 10:42:36.0 -0700
+++ b/drivers/net/sky2.h2007-05-22 10:44:35.0 -0700
Some chips need to have internal clocks enabled (via PCI config)
before the PCI space is readable.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 102 ++---
drivers/net/sky2.h | 19 +
2 files changed, 92
Driver was not correctly setting up transmit descriptor when doing
VLAN tag insertion with checksum offload.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.c2007-05-22 10:42:36.0 -0700
+++ b/drivers/net/sky2.c2007-05-22 10:43:12.0 -0700
Several of the PHY registers are multiplexed; access to
register must be proceeded by setting page register.
The driver setup is safer if this is done before the access
rather than depending on the last value.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 25
This code inherited from the sk98lin driver is incorrect on the Yukon2.
The GPHY_CTRL register values are specific to the internal PHY of the chip
and the values used were leftovers.
Driver was setting bit 13 which is now the INT polarity for the PHY!
Signed-off-by: Stephen Hemminger [EMAIL
Why? Most bug reports on vendor kernels with backported
drivers.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/net/sky2.c2007-05-24 11:20:26.0 -0700
+++ b/drivers/net/sky2.c
Driver was reading value from one register, setting bit and then
writing the wrong register.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/drivers/net/sky2.c2007-05-22 10:43:12.0 -0700
+++ b/drivers/net/sky2.c2007-05-22 10:44:32.0 -0700
@@ -364,7 +364,7
that depend on local variables are evil!!
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
-info.html
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
).
There is a regression since 2.6.22-rc1 where the b44 driver has
receive performance/interrupt lockup issues.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
.
It is not very clear how SYN segments should be handled, so I
choose to follow the previous implementation in this respect.
Since we don't invoke congestion control modules until after the SYN
handshake this is not a problem.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send
and not
NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty
function. This seems to be a bug though, vlan_rx_add_vid is only
required with NETIF_F_HW_VLAN_FILTER. Ben?
I put it in the next sky2 patch set. Still waiting for Jeff
to take the last one.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe
On Tue, 29 May 2007 23:07:00 +0300 (EEST)
Ilpo Järvinen [EMAIL PROTECTED] wrote:
On Tue, 29 May 2007, Stephen Hemminger wrote:
On Mon, 28 May 2007 13:27:03 +0300 (EEST)
Ilpo Järvinen [EMAIL PROTECTED] wrote:
On Sun, 27 May 2007, Ilpo Järvinen wrote:
[PATCH] [TCP]: Fix GSO
;
if(sacked TCPCB_SACKED_ACKED)
-
The proposed fix for TSO and packets acked callback will fix this as well.
Your fix makes sense for kernels 2.6.22, but with 2.6.22 this would
fix it:
http://article.gmane.org/gmane.linux.network/63101
--
Stephen Hemminger [EMAIL
it seems moot.
IMHO the correct solution would be to get rid if NETIF_F_HW_SUM and make a new
flag
NETIF_F_IPV6_SUM. Devices that can checksum both could do
NETIF_F_IPV4_SUM|NETI_F_IPV6_SUM.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev
I am busy bisecting the real cause. Unfortunately, oprofile doesn't work
on the laptop, and build time sucks...
This how I think the IRQ should work:
--- a/drivers/net/b44.c 2007-05-29 09:47:53.0 -0700
+++ b/drivers/net/b44.c 2007-05-29 09:49:50.0 -0700
@@ -908,9 +908,11 @@
On Tue, 29 May 2007 23:14:58 +0200
Francois Romieu [EMAIL PROTECTED] wrote:
The irq handling thread (b44_interrupt) uses the same lock as the NAPI
thread. This change should prevent a deadlock if something interrupts
the b44 NAPI thread and tries to printk through netconsole.
Signed-off-by:
On Wed, 30 May 2007 07:36:18 +1000
Herbert Xu [EMAIL PROTECTED] wrote:
On Tue, May 29, 2007 at 01:58:13PM -0700, Stephen Hemminger wrote:
The flag NETIF_F_HW_SUM is being misused. The definition says that the
device
is capable of checksumming any packet. When in fact from usage it seems
as signed?
On 5/29/07, Stephen Hemminger [EMAIL PROTECTED] wrote:
On Tue, 29 May 2007 12:18:19 +0300
Lior Dotan [EMAIL PROTECTED] wrote:
Hi,
I had a divide by zero on kernel 2.4.33 running with Vegas enabled.
I don't think anyone has backported the other vegas fixes from 2.6.21
to 2.4
On Wed, 30 May 2007 00:20:41 +0200
Francois Romieu [EMAIL PROTECTED] wrote:
Stephen Hemminger [EMAIL PROTECTED] :
⅜...]
Better to just get rid of using the lock as a transmit lock and
use netif_tx_lock instead.
--- a/drivers/net/b44.c 2007-05-29 09:51:43.0 -0700
+++ b
to trouble of computing all the
offsets and they are already there in skb...
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
It doesn't look like spidernet hardware can really checksum all protocols,
the code looks like it does IPV4 only. If so, it should use NETIF_F_IP_CSUM
instead of NETIF_F_HW_CSUM.
The driver doesn't need it's own get/set for ethtool tx csum, and it
should use the standard ethtool_op_get_link.
problems
than it causes already. So change the code to drop lock before calling
poll handler.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/net/core/netpoll.c2007-05-08 14:19:32.0 -0700
+++ b/net/core/netpoll.c2007-05-29 15:28:22.0 -0700
@@ -250,22 +250,23
Jeff Garzik wrote:
Stephen Hemminger wrote:
Some chips need to have internal clocks enabled (via PCI config)
before the PCI space is readable.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 102
++---
drivers/net
Here is a proposed change to address hardware that can do IPV6 checksum
offload, but doesn't truly do generic hw checksumming. The bnx2 and tg3
are like this for some revisions, and upcoming Marvell 88e8071 is similar.
--- a/drivers/net/bnx2.c2007-05-30 08:26:18.0 -0700
+++
It isn't worth inlining qdisc_run, into two parts. The code is
cleaner (and smaller) to just have it as one routine.
--- a/include/net/pkt_sched.h 2007-05-02 12:26:34.0 -0700
+++ b/include/net/pkt_sched.h 2007-05-30 09:12:22.0 -0700
@@ -80,14 +80,7 @@ extern struct
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
The bridge code already has a more complete/complex recompute
routine to handle this.
--
Stephen Hemminger [EMAIL
On Wed, 30 May 2007 10:49:54 +0300 (EEST)
Ilpo Järvinen [EMAIL PROTECTED] wrote:
On Tue, 29 May 2007, Stephen Hemminger wrote:
On Tue, 29 May 2007 20:23:45 +0200
Lior Dotan [EMAIL PROTECTED] wrote:
NTP was not running. I'm not sure what do you mean by fixing the -1.
The trace
On Wed, 30 May 2007 09:58:38 -0700
Laurent Chavey [EMAIL PROTECTED] wrote:
should we then move/integrate that code as part of the bonding driver ?
On 5/30/07, Stephen Hemminger [EMAIL PROTECTED] wrote:
On Tue, 29 May 2007 17:41:45 -0700
Laurent Chavey [EMAIL PROTECTED] wrote
the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED
On Wed, 30 May 2007 09:56:18 -0400
Jeff Garzik [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
Some chips need to have internal clocks enabled (via PCI config)
before the PCI space is readable.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/sky2.c | 102
2.0 which is pretty
significant, too.
Alternatively, we could change to a timer that is pushed forward after each
TX, maybe using hrtimer and hrtimer_forward(). That way the timer would
never run in normal case.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send
On Wed, 30 May 2007 20:57:33 +0200
Oliver Hartkopp [EMAIL PROTECTED] wrote:
Does 'unneeded' belong to always the last line of the quoted code snippet?
They are all places where you assign zero (or NULL) to something that is
already initialized to zero by alloc_netdev.
--
Stephen
Even [EMAIL PROTECTED]
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- 2.6.22-rc2/net/bridge/br_fdb.c 2007-05-20 00:51:11.0 +0300
+++ 2.6-rc2/net/bridge/br_fdb.c 2007-05-20 00:50:31.0 +0300
@@ -121,6 +121,7 @@
{
struct net_bridge *br = (struct net_bridge
Peroidic STP timers don't have to be exact.
The hold timer runs at 1HZ, and the hello timer normally runs
at 2HZ; save power by aligning it them to next second.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
net/bridge/br_stp.c |3 ++-
net/bridge/br_stp_timer.c |2 +-
2
On Wed, 30 May 2007 12:55:51 -0700 (PDT)
David Miller [EMAIL PROTECTED] wrote:
From: Patrick McHardy [EMAIL PROTECTED]
Date: Wed, 30 May 2007 20:42:32 +0200
Stephen Hemminger wrote:
Index: linux-2.6.22-rc-mm/net/sched/sch_generic.c
This is better.
There is still a possiblity when a device allows IPV6 and not IPV4
checksumming, that the checksum will be done in the fixup code in
dev_queue_xmit.
The existing model for checksum offload does not correctly handle
devices that can offload IPV4 and IPV6 only. The NETIF_F_HW_CSUM
Found while looking at drivers that are doing NETIF_F_HW_CSUM
incorrectly.
The first is a bug fix. Second is cleanup, Third is an enhancement.
--
Stephen Hemminger [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED
The code for checksum is more complex than needed when dealing with VLAN's;
the higher layers already pass down the location of the IP header.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/qla3xxx.c | 37
Reading the code for ql_hw_csum_setup(), it is obvious that
this driver is broken for IPV6. The driver sets the NETIF_F_HW_SUM
flag, but the code for checksum setup only deals with IPV4.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers
Add the ability to control scatter/gather and checksumming
via ethtool.
Compile tested only, no hardware available.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/qla3xxx.c | 33 +
1 file changed, 33 insertions(+)
--- a/drivers/net
;
+}
+
This code seems to be duplicating a lot (but not all) of the TCP/IP
input path validation checks. This is a security problem if nothing else...
Also, how do you prevent DoS attacks from hostile TCP senders that send
huge number of back to back frames?
--
Stephen Hemminger [EMAIL PROTECTED
and not
NETIF_F_HW_VLAN_FILTER is set, so this patch keeps an empty
function. This seems to be a bug though, vlan_rx_add_vid is only
required with NETIF_F_HW_VLAN_FILTER. Ben?
Reading other drivers, it looks like a better patch would be to
handle mode change in both set and kill.
Signed-off-by: Stephen Hemminger
On Thu, 31 May 2007 19:37:07 +0200
Patrick McHardy [EMAIL PROTECTED] wrote:
Stephen Hemminger wrote:
On Sun, 27 May 2007 20:44:04 +0200
Patrick McHardy [EMAIL PROTECTED] wrote:
Fix sky2 disabling VLAN completely when the first vid is unregistered.
For some reason the VLAN code
I am working on a multi-driver cleanup patch right now...
-
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Patrick's fix for sky2 VLAN unregister, started me looking at
other drivers. Many drivers had bogus kill_vid hooks, and the whole
interface for kill_vid is only useful for devices that do receive
filtering, so fix the interface and the drivers.
--
Stephen Hemminger [EMAIL PROTECTED
kill_vid routine that called vlan_group_set_device, with
NULL, but that is done already.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
--- a/net/8021q/vlan.c 2007-06-01 08:18:32.0 -0700
+++ b/net/8021q/vlan.c 2007-06-01 08:28:02.0 -0700
@@ -240,10 +240,8 @@ static int
The 8139cp driver did VLAN unregistration incorrectly.
It disables VLAN completely when the first VID is unregistered. It
should instead disable VLAN when the group is unregistered by calling
cp_vlan_rx_register with a NULL grp.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers
Many drivers had code that did kill_vid, but they weren't doing vlan
filtering. With new API the stub is unneeded unless device sets
NETIF_F_HW_VLAN_FILTER.
Bad habit: I couldn't resist fixing a couple of nearby style things
in acenic, and forcedeth.
Signed-off-by: Stephen Hemminger [EMAIL
]
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
drivers/net/sky2.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
--- a/drivers/net/sky2.c2007-06-01 08:20:39.0 -0700
+++ b/drivers/net/sky2.c2007-06-01 08:29:05.0 -0700
This driver has unneeded stubs for VLAN filtering.
Signed-off-by: Stephen Hemminger [EMAIL PROTECTED]
---
drivers/net/atl1/atl1_main.c | 25 +
---
drivers/net/atl1/atl1_main.c | 33 +
1 file changed, 1 insertion(+), 32 deletions
On Fri, 25 May 2007 09:37:09 +0200
Nicklas Bondesson [EMAIL PROTECTED] wrote:
I am trying to setup two vlans (one tagged and one untagged) using the
native via-velocity driver in kernel 2.6.21.1 on a single nic.
I can set it up tagged or untagged without any problems, but not both at the
it really wants
CHECKSUM_PARTIAL skb's to work on. And CHECKSUM_PARTIAL skbs are only
setup for paths that advertise the NETIF_F_HW_CSUM capability.
CHECKSUM_PARTIAL is used on xmit for both NETIF_F_HWCSUM and NETIF_F_IPCSUM
See acenic, 3c59x, ...
--
Stephen Hemminger [EMAIL PROTECTED
({1180973757, 172797}, NULL) = 0
gettimeofday({1180973757, 172817}, NULL) = 0
nanosleep({0, 0}, NULL) = 0
nanosleep({0, 0}, NULL) = 0
close(4) = 0
futex(0x8055d04, 0x5 /* FUTEX_??? */, 1) = 1
futex(0x8055d30, FUTEX_WAKE, 1) = 0
_exit(0)
--
Stephen Hemminger [EMAIL
On Mon, 04 Jun 2007 18:35:58 +0200
Thomas Gleixner [EMAIL PROTECTED] wrote:
On Mon, 2007-06-04 at 09:09 -0700, Stephen Hemminger wrote:
I did the test with an 2.6.22-rc3-git4 kernel and the p54 driver built
external as module.
Can you look at iperf to figure out, whether it does
1 - 100 of 5336 matches
Mail list logo
