JacquesLeRoux commented on PR #668:
URL: https://github.com/apache/ofbiz-framework/pull/668#issuecomment-1695980547
Hi,
Your PR is OK with me, but I'll apply as a patch locally because of
indentation in SecuredUpload.
Also we normally create Jira for bugs and improvements and use
JacquesLeRoux merged PR #669:
URL: https://github.com/apache/ofbiz-framework/pull/669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JacquesLeRoux commented on PR #673:
URL: https://github.com/apache/ofbiz-framework/pull/673#issuecomment-1761666534
Thanks Daniel,
I did not get into all details, but as it works for trunk and next demos I
see no reason why it would not work for stable
+1 for pushing
--
This is
dixitdeepak commented on PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674#issuecomment-1788459559
> Hi Deepak,
>
> It's something "special" to test, but I can't see any side affects by
adding the lines as your did => +1
Hi Jacques,
## Steps to Reproduce the
dixitdeepak merged PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JacquesLeRoux commented on PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674#issuecomment-1786815127
Hi Deepak,
It's something "special" to test, but I can't see any side affects by adding
the lines as your did => +1
--
This is an automated message from the Apache
mbrohl commented on PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674#issuecomment-1786894247
+1 would be good if this could be squashed into 1 commit.
Thanks Deepak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
JacquesLeRoux commented on PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674#issuecomment-1786995659
We have by default the Squash and merge button by default ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
sonarcloud[bot] commented on PR #674:
URL: https://github.com/apache/ofbiz-framework/pull/674#issuecomment-1785316470
Kudos, SonarCloud Quality Gate passed! [ from 3.0.5 to 3.0.6.
Release notes
Sourced from https://github.com/cure53/DOMPurify/releases;>dompurify's
releases.
sonarcloud[bot] commented on PR #670:
URL: https://github.com/apache/ofbiz-framework/pull/670#issuecomment-1739154728
Kudos, SonarCloud Quality Gate passed! [ and 22.01:
https://demo-trunk.ofbiz.apache.org/rest/ (returns
sonarcloud[bot] commented on PR #88:
URL: https://github.com/apache/ofbiz-plugins/pull/88#issuecomment-1738657311
Kudos, SonarCloud Quality Gate passed! [ from 8.4.27 to 8.4.31.
Release notes
Sourced from https://github.com/postcss/postcss/releases;>postcss's
releases.
8.4.31
sonarcloud[bot] commented on PR #89:
URL: https://github.com/apache/ofbiz-plugins/pull/89#issuecomment-1751874675
Kudos, SonarCloud Quality Gate passed! [
from 7.22.8 to 7.23.2.
Release notes
Sourced from
sonarcloud[bot] commented on PR #90:
URL: https://github.com/apache/ofbiz-plugins/pull/90#issuecomment-1770781184
Kudos, SonarCloud Quality Gate passed! [
from 1.19.5 to 1.20.0.
Release notes
Sourced from
sonarcloud[bot] commented on PR #672:
URL: https://github.com/apache/ofbiz-framework/pull/672#issuecomment-1757189740
Kudos, SonarCloud Quality Gate passed! [
Thanks: Benjamin Jugl
--
This is an automated message from the Apache Git Service.
To respond to the message, please
originalnichtskoenner opened a new pull request, #668:
URL: https://github.com/apache/ofbiz-framework/pull/668
Read file name validation pattern from security.properties to allow
customization
Explanation
Hard coding the pattern made it difficult to adjust file name
sonarcloud[bot] commented on PR #668:
URL: https://github.com/apache/ofbiz-framework/pull/668#issuecomment-1695527163
Kudos, SonarCloud Quality Gate passed! [ from 3.7.0 to 3.7.1.
Commits
https://github.com/jquery/jquery/commit/f79d5f1a337528940ab7029d4f8bbba72326f269;>f79d5f1
sonarcloud[bot] commented on PR #669:
URL: https://github.com/apache/ofbiz-framework/pull/669#issuecomment-1695730352
Kudos, SonarCloud Quality Gate passed! [
URL: https://github.com/apache/ofbiz-framework/pull/581
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
JacquesLeRoux commented on PR #581:
URL: https://github.com/apache/ofbiz-framework/pull/581#issuecomment-1403417863
Done already
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
danwatford commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1088062833
##
applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy:
##
@@ -30,25 +30,25 @@ invoiceItemTypes =
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1088104573
##
applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy:
##
@@ -30,25 +30,25 @@ invoiceItemTypes =
cshan-ecomify opened a new pull request, #580:
URL: https://github.com/apache/ofbiz-framework/pull/580
Fixed escape syntax for <>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
JacquesLeRoux merged PR #580:
URL: https://github.com/apache/ofbiz-framework/pull/580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1088742354
##
applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy:
##
@@ -30,25 +30,25 @@ invoiceItemTypes =
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089171839
##
applications/accounting/groovyScripts/admin/FilterOutReceipts.groovy:
##
@@ -20,4 +20,4 @@
Review Comment:
Reviewed
--
This is an automated message
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089170578
##
applications/accounting/groovyScripts/admin/ListInvoiceItemTypesGlAccount.groovy:
##
@@ -20,8 +20,8 @@
import
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089170827
##
applications/accounting/groovyScripts/admin/AcctgAdminServices.groovy:
##
@@ -25,45 +25,47 @@ import org.apache.ofbiz.entity.GenericValue
import
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089174447
##
framework/webtools/src/main/groovy/org/apache/ofbiz/webtools/log/FetchLogs.groovy:
##
@@ -16,23 +16,22 @@
* specific language governing permissions and
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1089173659
##
settings.gradle:
##
@@ -20,8 +20,8 @@
apply from: 'common.gradle'
Review Comment:
Reviewed
--
This is an automated message from the Apache Git
JacquesLeRoux commented on PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1407368649
Thanks to Daniel and Gil, you can post your review results at
https://cwiki.apache.org/confluence/display/OFBIZ/Codenarc+integration+review+tracker
--
This is an automated
JacquesLeRoux commented on PR #354:
URL: https://github.com/apache/ofbiz-framework/pull/354#issuecomment-1407376913
This is now handled at https://issues.apache.org/jira/browse/OFBIZ-12400
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
JacquesLeRoux closed pull request #354: Improved: Upgrade to gradle 7.3 to
support jdk 11 -> 17 (OFBIZ-12400)
URL: https://github.com/apache/ofbiz-framework/pull/354
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
christ opened a new pull request, #8:
URL: https://github.com/apache/ofbiz-site/pull/8
work being tracked via https://issues.apache.org/jira/browse/INFRA-24152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
sonarcloud[bot] commented on PR #601:
URL: https://github.com/apache/ofbiz-framework/pull/601#issuecomment-1460548908
Kudos, SonarCloud Quality Gate passed! [ from 3.6.3 to 3.6.4.
Release notes
Sourced from https://github.com/jquery/jquery/releases;>jquery's releases.
jQuery
JacquesLeRoux merged PR #602:
URL: https://github.com/apache/ofbiz-framework/pull/602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #602:
URL: https://github.com/apache/ofbiz-framework/pull/602#issuecomment-1463850751
Kudos, SonarCloud Quality Gate passed! [ {
// make
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1132562408
##
applications/order/groovyScripts/entry/AdditionalPartyListing.groovy:
##
@@ -26,20 +26,20 @@ roleData = [:]
partyData = [:]
additionalPartyRole.each {
danwatford merged PR #603:
URL: https://github.com/apache/ofbiz-framework/pull/603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
danwatford merged PR #597:
URL: https://github.com/apache/ofbiz-framework/pull/597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1135270359
##
applications/accounting/src/main/groovy/org/apache/ofbiz/accounting/InvoicePerShipmentTests.groovy:
##
@@ -34,152 +31,155 @@ import
danwatford merged PR #606:
URL: https://github.com/apache/ofbiz-framework/pull/606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
danwatford commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1135741048
##
applications/product/groovyScripts/facility/facility/CountFacilityInventoryByProduct.groovy:
##
@@ -55,166 +57,167 @@ rows = [] as ArrayList
if (action) {
sonarcloud[bot] commented on PR #606:
URL: https://github.com/apache/ofbiz-framework/pull/606#issuecomment-1468144598
Kudos, SonarCloud Quality Gate passed! [ {
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1146194797
##
applications/product/groovyScripts/product/product/ProductServices.groovy:
##
@@ -841,22 +867,24 @@ def checkOrderItemForProductGroupOrder() {
/**
*
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1146353305
##
applications/product/groovyScripts/product/product/ProductServices.groovy:
##
@@ -841,22 +867,24 @@ def checkOrderItemForProductGroupOrder() {
/**
*
danwatford commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1146202300
##
applications/product/groovyScripts/product/product/ProductServices.groovy:
##
@@ -841,22 +867,24 @@ def checkOrderItemForProductGroupOrder() {
/**
*
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147374612
##
applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy:
##
@@ -131,39 +123,30 @@ def updateShoppingListItem() {
/**
* Remove a
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147426708
##
applications/party/groovyScripts/party/EditPaymentMethod.groovy:
##
@@ -38,24 +38,36 @@ context.postalAddressInfos =
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147826282
##
applications/product/groovyScripts/product/promo/ProductPromoActionServices.groovy:
##
@@ -161,9 +169,11 @@ def productGWP() {
}
sonarcloud[bot] commented on PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#issuecomment-1483072556
Kudos, SonarCloud Quality Gate passed! [ {
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147768342
##
applications/accounting/groovyScripts/reports/CostCenters.groovy:
##
@@ -26,50 +25,49 @@ import org.apache.ofbiz.entity.condition.EntityOperator
if
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147859199
##
applications/product/groovyScripts/product/promo/ProductPromoActionServices.groovy:
##
@@ -173,18 +183,19 @@ def productGWP() {
Iterator
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147873079
##
applications/order/groovyScripts/shoppinglist/ShoppingListServices.groovy:
##
@@ -131,39 +123,30 @@ def updateShoppingListItem() {
/**
* Remove a
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147861703
##
applications/party/groovyScripts/party/EditPaymentMethod.groovy:
##
@@ -38,24 +38,36 @@ context.postalAddressInfos =
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147861320
##
applications/product/groovyScripts/product/promo/ProductPromoActionServices.groovy:
##
@@ -161,9 +169,11 @@ def productGWP() {
}
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147865371
##
applications/accounting/groovyScripts/reports/CostCenters.groovy:
##
@@ -26,50 +25,49 @@ import org.apache.ofbiz.entity.condition.EntityOperator
if
JacquesLeRoux commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147866086
##
applications/marketing/groovyScripts/marketing/reports/MarketingCampaignReport.groovy:
##
@@ -23,26 +23,28 @@ import
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147821807
##
applications/party/groovyScripts/party/EditPaymentMethod.groovy:
##
@@ -38,24 +38,36 @@ context.postalAddressInfos =
gilPts commented on code in PR #517:
URL: https://github.com/apache/ofbiz-framework/pull/517#discussion_r1147803806
##
applications/product/groovyScripts/facility/facility/CountFacilityInventoryByProduct.groovy:
##
@@ -55,166 +57,167 @@ rows = [] as ArrayList
if (action) {
1 - 100 of 1289 matches
Mail list logo
