Re: [Nouveau] known MSI errata?

2013-10-24 Thread Ben Skeggs
On Fri, Oct 25, 2013 at 9:10 AM, Robert Morell rmor...@nvidia.com wrote: On Thu, Oct 24, 2013 at 04:03:12PM -0700, Ben Skeggs wrote: On Fri, Oct 25, 2013 at 7:43 AM, Robert Morell rmor...@nvidia.com wrote: On Mon, Sep 30, 2013 at 10:44:12AM -0700, Lucas Stach wrote: Hi, recently we tried

Re: [Nouveau] gk104: disable display underflow reporting

2013-10-24 Thread Ben Skeggs
On Thu, Oct 24, 2013 at 3:34 PM, Andy Ritger arit...@nvidia.com wrote: Hi Nouveau developers, We've posted a short document about disabling display underflow reporting on GK104, which is needed due to an incorrect setting in some production GK104 VBIOSes: Hey Andy, Thanks for the info, I've

Re: [Nouveau] [PATCH] drm/nouveau: Do not show an error if the TMDS table pointer is invalid

2013-10-09 Thread Ben Skeggs
On Thu, Oct 10, 2013 at 5:40 AM, Albert Pool albertp...@solcon.nl wrote: Optimus cards with no outputs trigger this message (NVD7, for example) This commit changes the warning into an informational message. The return value of the function is not used, so I left it at -EINVAL. Signed-off-by:

Re: [Nouveau] NV_PMC_BOOT_0 architecture field

2013-09-27 Thread Ben Skeggs
On Sat, Sep 28, 2013 at 4:03 AM, Andy Ritger arit...@nvidia.com wrote: Hi Ben, Hey Andy, At XDC you asked about the architecture field in NV_PMC_BOOT_0, and how to correctly determine the GPU architecture. It looks like Nouveau is getting the architecture from bits 20-27 in NV_PMC_BOOT_0

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-25 Thread Ben Skeggs
On Thu, Sep 26, 2013 at 12:41 AM, Pasi Kärkkäinen pa...@iki.fi wrote: Hello, On Wed, Sep 04, 2013 at 08:59:13AM +0200, Maarten Lankhorst wrote: Op 04-09-13 05:41, Ben Skeggs schreef: On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 22-08-13 02

Re: [Nouveau] offer to help, DCB

2013-09-24 Thread Ben Skeggs
On Tue, Sep 24, 2013 at 2:44 PM, Andy Ritger arit...@nvidia.com wrote: Hi Nouveau developers, Hey Andy, and all you other NVIDIA guys :) This was a very pleasant shock over breakfast this morning, and is very much appreciated! I look forward to seeing how we can all work together in the

Re: [Nouveau] userspace nouveau on NV15

2013-09-16 Thread Ben Skeggs
On Tue, Sep 17, 2013 at 10:04 AM, Dmitry Eremin-Solenikov dbarysh...@gmail.com wrote: Hello, I'm trying to get userspace nouveau to work on the NV15 card (GeForce2 GTS - ASUS v7700 TVR). Whilte kernel nouveau driver works, userspace nv_init programs hangs during CONFIGURE_MEM. Does this

Re: [Nouveau] [PATCH] drm/nouveau: do not move buffers when not needed

2013-09-10 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 11:25 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 03:24, Ben Skeggs schreef: On Mon, Jul 15, 2013 at 6:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 15-07-13 08:05, Ben Skeggs schreef: On Fri, Jul 12, 2013 at 10:45 PM

Re: [Nouveau] [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-09 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 9:59 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 05:34, Ben Skeggs schreef: On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: There are a lot of places that allocate multiples of 1000, but do not set

Re: [Nouveau] [PATCH] drm/nv10/plane: add plane support for nv10-nv40

2013-09-08 Thread Ben Skeggs
On Sun, Sep 8, 2013 at 10:33 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu --- This has received light testing on NV18 and NV34 cards, using the modetest tool. Userspace support to use this for xv is not yet ready. I decided against creating a

Re: [Nouveau] [PATCH 1/5] drm/nv31/mpeg: no need to set compat mode differently for nv44 gr

2013-09-08 Thread Ben Skeggs
On Sun, Sep 8, 2013 at 11:04 AM, Ilia Mirkin imir...@alum.mit.edu wrote: Signed-off-by: Ilia Mirkin imir...@alum.mit.edu Series merged: http://cgit.freedesktop.org/~darktama/nouveau/commit/?id=997d90216a8318e0a6c4de6377f63a8272f26086 Cheers, Ben. ---

Re: [Nouveau] [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-08 Thread Ben Skeggs
On Wed, Sep 4, 2013 at 10:37 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 04-09-13 05:21, Ben Skeggs schreef: On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: This increases the chance slightly that recovery from lockup can happen

Re: [Nouveau] [PATCH] drm/nv50/disp: prevent false output detection on the original nv50

2013-09-03 Thread Ben Skeggs
On Sat, Aug 24, 2013 at 3:43 AM, Emil Velikov emil.l.veli...@gmail.com wrote: Commit ea9197cc323839ef3d5280c0453b2c622caa6bc7 effectively enabled the use of an improved DAC detection code, but introduced a regression on the original nv50 chipset, causing a ghost monitor to be detected. Hey

Re: [Nouveau] [PATCH] drm/nouveau/i2c: pass the function pointers in at creation time

2013-09-03 Thread Ben Skeggs
On Sat, Aug 24, 2013 at 3:03 AM, Ilia Mirkin imir...@alum.mit.edu wrote: i2c_bit_add_bus can call the pre_xfer function, which expects the func pointer to be set. Pass in func to the port creation logic so that it is set before i2c_bit_add_bus. Merged, thanks! Ben. See

Re: [Nouveau] [PATCH] drm/nouveau: do not move buffers when not needed

2013-09-03 Thread Ben Skeggs
On Mon, Jul 15, 2013 at 6:39 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 15-07-13 08:05, Ben Skeggs schreef: On Fri, Jul 12, 2013 at 10:45 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I have no idea what this bogus restriction on placement is, but it breaks

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-09-03 Thread Ben Skeggs
On Fri, Aug 30, 2013 at 5:11 PM, Lucas Stach d...@lynxeye.de wrote: Am Freitag, den 30.08.2013, 15:36 +1000 schrieb Ben Skeggs: On Fri, Aug 30, 2013 at 12:01 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 9:58 PM, Ben Skeggs skeg...@gmail.com wrote: On Fri, Aug 30, 2013

Re: [Nouveau] [PATCH] drm/nouveau/therm: ack any pending IRQ at init v2

2013-09-03 Thread Ben Skeggs
On Sat, Aug 31, 2013 at 10:06 AM, Martin Peres martin.pe...@free.fr wrote: From: Martin Peres martin.pe...@labri.fr This is safe because ptherm hasn't been configured yet and will be a little further down the initialization path. Ptherm should be safe regarding to runtime reconfiguration. Any

Re: [Nouveau] [PATCH 1/2] drm/nouveau/bios/therm: handle vbioses with duplicate entries (mostly nva5)

2013-09-03 Thread Ben Skeggs
On Sat, Aug 31, 2013 at 9:58 AM, Martin Peres martin.pe...@free.fr wrote: From: Martin Peres martin.pe...@labri.fr Some vbioses have extra useless entries after the end of the table. This is problematic since all of the vbios I found with this issue redefine the pwm freq divider to insane

Re: [Nouveau] [PATCH] drm/nv84-: write fence value on exit, and restore value on init.

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: This increases the chance slightly that recovery from lockup can happen succesfully. I'd *really* love to see proof of this. When channels die, all outstanding fences are marked as signalled. This should

Re: [Nouveau] [PATCH] drm/nv50-: make dma-objects read-only where appropriate

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I don't see why the display engine would need write access to the entirety of vram, when read-only access is enough. Meh, this really doesn't matter... We're doing the same setup as nvidia do here, and I

Re: [Nouveau] [PATCH] drm/nouveau: fix command submission to use vmalloc for big allocations

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: I was getting a order 4 allocation failure from kmalloc when testing some game after a few days uptime with some suspend/resumes. For big allocations vmalloc should be used instead. I've picked up this

Re: [Nouveau] [PATCH] drm/nouveau: force alignment to 0x1000 for gpu objects

2013-09-03 Thread Ben Skeggs
On Tue, Sep 3, 2013 at 12:31 AM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: There are a lot of places that allocate multiples of 1000, but do not set alignment correctly and still require this alignment implicitly or explicitly. This is wrong. Where are the places you think you

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-09-03 Thread Ben Skeggs
On Thu, Aug 22, 2013 at 5:12 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Op 22-08-13 02:10, Ilia Mirkin schreef: The code expects non-VRAM mem nodes to have a pages list. If that's not set, it will do a null deref down the line. Warn on that condition and return an error.

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-29 Thread Ben Skeggs
On Thu, Aug 29, 2013 at 12:20 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Aug 28, 2013 at 8:07 PM, Ben Skeggs skeg...@gmail.com wrote: On Wed, Aug 28, 2013 at 11:54 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Aug 28, 2013 at 3:28 AM, Lucas Stach d...@lynxeye.de wrote: Am

Re: [Nouveau] Fixing nouveau for 4k PAGE_SIZE

2013-08-29 Thread Ben Skeggs
On Sun, Aug 11, 2013 at 7:35 PM, Benjamin Herrenschmidt b...@kernel.crashing.org wrote: On Sun, 2013-08-11 at 11:02 +0200, Maarten Lankhorst wrote: diff --git a/drivers/gpu/drm/nouveau/core/engine/fifo/nv40.c b/drivers/gpu/drm/nouveau/core/engine/fifo/nv40.c index 5c7433d..c314a5f 100644

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-29 Thread Ben Skeggs
On Fri, Aug 30, 2013 at 11:10 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 1:07 AM, Ben Skeggs skeg...@gmail.com wrote: On Thu, Aug 29, 2013 at 3:00 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 12:45 AM, Ben Skeggs skeg...@gmail.com wrote: On Thu

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-29 Thread Ben Skeggs
On Fri, Aug 30, 2013 at 11:58 AM, Ben Skeggs skeg...@gmail.com wrote: On Fri, Aug 30, 2013 at 11:10 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 1:07 AM, Ben Skeggs skeg...@gmail.com wrote: On Thu, Aug 29, 2013 at 3:00 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-29 Thread Ben Skeggs
On Fri, Aug 30, 2013 at 12:01 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 9:58 PM, Ben Skeggs skeg...@gmail.com wrote: On Fri, Aug 30, 2013 at 11:10 AM, Ilia Mirkin imir...@alum.mit.edu wrote: On Thu, Aug 29, 2013 at 1:07 AM, Ben Skeggs skeg...@gmail.com wrote: On Thu

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-28 Thread Ben Skeggs
On Wed, Aug 28, 2013 at 10:00 AM, Lucas Stach d...@lynxeye.de wrote: MSIs were only problematic on some old, broken chipsets. But now that we already see systems where PCI legacy interrupts are somewhat flaky, it's really time to move to MSIs. Signed-off-by: Lucas Stach d...@lynxeye.de ---

Re: [Nouveau] [PATCH 4/6] drm/nouveau: introduce NOUVEAU_GEM_TILE_WCUS

2013-08-28 Thread Ben Skeggs
On Wed, Aug 28, 2013 at 10:00 AM, Lucas Stach d...@lynxeye.de wrote: This flag allows userspace to give the kernel a hint that it should use a non-snooped resource. To guarantee coherency at all times mappings into userspace are done write combined, so userspace should avoid reading back from

Re: [Nouveau] [PATCH 0/9] drm/nouveau: Cleanup event/handler design

2013-08-28 Thread Ben Skeggs
On Wed, Aug 28, 2013 at 6:12 AM, Peter Hurley pe...@hurleysoftware.com wrote: This series was originally motivated by a deadlock, introduced in commit 1d7c71a3e2f77336df536855b0efd2dc5bdeb41b 'drm/nouveau/disp: port vblank handling to event interface', due to inverted lock order between

Re: [Nouveau] [PATCH 0/6] Nouveau on ARM fixes

2013-08-28 Thread Ben Skeggs
On Wed, Aug 28, 2013 at 5:50 PM, Thierry Reding thierry.red...@gmail.com wrote: On Wed, Aug 28, 2013 at 02:00:44AM +0200, Lucas Stach wrote: This is the first set of patches to make Nouveau work on Tegra. Perhaps you should clarify that this patch series allows discrete GPUs to be used via

Re: [Nouveau] [PATCH 6/6] drm/nouveau: use MSI interrupts

2013-08-28 Thread Ben Skeggs
On Wed, Aug 28, 2013 at 11:54 PM, Ilia Mirkin imir...@alum.mit.edu wrote: On Wed, Aug 28, 2013 at 3:28 AM, Lucas Stach d...@lynxeye.de wrote: Am Mittwoch, den 28.08.2013, 17:09 +1000 schrieb Ben Skeggs: On Wed, Aug 28, 2013 at 10:00 AM, Lucas Stach d...@lynxeye.de wrote: MSIs were only

Re: [Nouveau] [PATCH] drm/nouveau: avoid null deref on bad arguments to nouveau_vma_getmap

2013-08-22 Thread Ben Skeggs
On Thu, Aug 22, 2013 at 10:10 AM, Ilia Mirkin imir...@alum.mit.edu wrote: The code expects non-VRAM mem nodes to have a pages list. If that's not set, it will do a null deref down the line. Warn on that condition and return an error. See https://bugs.freedesktop.org/show_bug.cgi?id=64774

Re: [Nouveau] [PATCH] nouveau: Allow 3D accelerators with output ports

2013-04-28 Thread Ben Skeggs
Hm, I expect you can probably just change the mask to 0x00ff, which is what our kernel module accepts anyway. On Sat, Apr 27, 2013 at 5:23 AM, Marek Vasut ma...@denx.de wrote: This patch let's cards with PCI class 0x30200 (3D controller) be operated by the nouveau driver as well. The nv

Re: [Nouveau] [PATCH] drm/nouveau: idle all channels before suspending

2013-04-08 Thread Ben Skeggs
On Mon, Apr 8, 2013 at 10:04 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Seems to make suspend slightly more reliable on my system. NACK. Seems to, and slightly don't make a very good argument for this. Likely all you've done is change the timing of certain things happening.

Re: [Nouveau] [PATCH] drm/nouveau: add lockdep annotations

2013-02-05 Thread Ben Skeggs
On Mon, Feb 04, 2013 at 10:59:28PM +0100, Maarten Lankhorst wrote: Op 04-02-13 22:30, Marcin Slusarz schreef: 1) Lockdep thinks all nouveau subdevs belong to the same class and can be locked in arbitrary order, which is not true (at least in general case). Tell it to distinguish subdevs by

Re: [Nouveau] [PATCH] drm/nouveau/clock: fix support for more than 2 monitors on nve0

2013-01-06 Thread Ben Skeggs
On Fri, Jan 04, 2013 at 06:39:13PM +0200, Aleksi Torhamo wrote: Fixes regression introduced in commit 70790f4f drm/nouveau/clock: pull in the implementation from all over the place When code was moved from nv50_crtc_set_clock to nvc0_clock_pll_set, the PLLs it is used for got limited to only

Re: [Nouveau] [PATCH] drm/nouveau: fix ramht wraparound

2012-12-20 Thread Ben Skeggs
On Thu, Dec 20, 2012 at 11:37:12PM +0100, Marcin Slusarz wrote: When hash collision occurs and it's near ramht object boundary, we could read and possibly overwrite some memory after ramht object. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Cc: sta...@vger.kernel.org ---

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-10 Thread Ben Skeggs
On Sun, Dec 09, 2012 at 12:04:54PM +0100, Marcin Slusarz wrote: On Sun, Dec 09, 2012 at 02:48:49PM +1000, Ben Skeggs wrote: diff --git a/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c b/drivers/gpu/drm/nouveau/core/subdev/fb/nv50.c index 487cb8c..d1120fc 100644 --- a/drivers

Re: [Nouveau] [RFC PATCH] drm/nouveau: report channel owner in error messages

2012-12-08 Thread Ben Skeggs
On Sun, Dec 09, 2012 at 12:26:42AM +0100, Marcin Slusarz wrote: On Fri, Dec 07, 2012 at 02:46:53PM +1000, Ben Skeggs wrote: On Wed, Dec 05, 2012 at 11:56:22PM +0100, Marcin Slusarz wrote: Full piglit run with this patch: http://people.freedesktop.org/~mslusarz/chan_owners.txt

Re: [Nouveau] [PATCH] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-11-06 Thread Ben Skeggs
On Tue, Nov 06, 2012 at 10:48:52PM +0100, Marcin Slusarz wrote: Now it outputs: nouveau E[ PGRAPH][:02:00.0] PGRAPH TLB flush idle timeout fail nouveau E[ PGRAPH][:02:00.0] PGRAPH_STATUS: BUSY DISPATCH VFETCH CCACHE_UNK4 STRMOUT_GSCHED_UNK5 UNK14XX UNK1CXX CLIPID ZCULL ENG2D UNK34XX

Re: [Nouveau] [PATCH] drm/nouveau: fix nouveau_mm/nouveau_mm_node leak

2012-10-19 Thread Ben Skeggs
On Thu, Oct 11, 2012 at 11:53:09PM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/gpuobj.c | 6 +- drivers/gpu/drm/nouveau/core/include/core/gpuobj.h | 3 +++ 2 files changed, 8 insertions(+), 1

Re: [Nouveau] [PATCH] drm/nouveau: handle same-fb page flips

2012-10-17 Thread Ben Skeggs
On Fri, Oct 05, 2012 at 09:37:59PM +0200, Marcin Slusarz wrote: It's questionable use case, but weston/wayland already relies on this behaviour, and other drivers don't care about it, so it's a matter of compatibility. Without it, process invoking such page flip hangs in unkillable state,

Re: [Nouveau] [PATCH] drm/nouveau: remove redundant comments listing classes

2012-10-17 Thread Ben Skeggs
On Tue, Oct 16, 2012 at 11:45:30PM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com NACK on this one. I did ponder doing such a thing myself when I first added the defines for the class names too, and decided against it as this will (at some point) become a

Re: [Nouveau] [PATCH] drm/nouveau: remove 1 sclass support from nouveau_parent_create_

2012-10-07 Thread Ben Skeggs
On Mon, Oct 08, 2012 at 12:49:30AM +0200, Marcin Slusarz wrote: It's unused (only one codepath passes sclass at all and it's always one), broken (overwrites the same field, leaking previous one) and confusing. It's only *currently* unused, I have WIP code in branches that uses it, otherwise it

Re: [Nouveau] [PATCH] drm/nouveau: comment out unused _nouveau_parent_ctor

2012-10-07 Thread Ben Skeggs
On Mon, Oct 08, 2012 at 12:49:28AM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/core/core/parent.c | 2 ++ drivers/gpu/drm/nouveau/core/include/core/parent.h | 3 +++ 2 files changed, 5 insertions(+) Feel free to just

Re: [Nouveau] [PATCH] drm/nouveau/i2c: correct default settings for i2c ports

2012-09-25 Thread Ben Skeggs
On Sat, Sep 22, 2012 at 09:33:50PM +0400, Dmitry Eremin-Solenikov wrote: Fix typo introduced when converting to core infrastructure. Signed-off-by: Dmitry Eremin-Solenikov dmitry_ere...@mentor.com Thanks, pushed! I'll likely squash this into the offending commit and note your corrections in

Re: [Nouveau] [PATCH] drm/nouveau: fix pm initialization order

2012-09-25 Thread Ben Skeggs
On Tue, Sep 25, 2012 at 10:31:40AM +0400, Dmitry Eremin-Solenikov wrote: If nouveau_pm_perflvl_get() fails, pm-profiles list will be left uninitialized, which causes oops during nouveau_pm_fini(). Move INIT_LIST_HEAD before call to nouveau_pm_perflvl_get(). Pushed, thanks! Signed-off-by:

Re: [Nouveau] Nouveau core in userspace

2012-09-19 Thread Ben Skeggs
On Tue, Sep 18, 2012 at 08:25:32PM +0400, Dmitry Eremin-Solenikov wrote: Hello, I saw in the core commit message that you worked on the nouveau core code in userspace. I'm currently digging into some old cards support and would benefit from not having to tickle with kernel/reboot/etc. on

Re: [Nouveau] [PATCH] drm/nouveau: POST the card before GPIO initialization

2012-09-18 Thread Ben Skeggs
On Mon, Sep 17, 2012 at 01:15:24AM +0200, Marcin Slusarz wrote: On Fri, Sep 14, 2012 at 01:45:18PM +0200, Marcin Slusarz wrote: On Fri, Sep 14, 2012 at 04:44:59PM +1000, Ben Skeggs wrote: On Fri, Sep 14, 2012 at 12:21:33AM +0200, Marcin Slusarz wrote: Otherwise my card (nv92) never

Re: [Nouveau] [PATCH] drm/nouveau: POST the card before GPIO initialization

2012-09-14 Thread Ben Skeggs
On Fri, Sep 14, 2012 at 12:21:33AM +0200, Marcin Slusarz wrote: Otherwise my card (nv92) never resumes from suspend to ram, hanging on nv_mask in nv50_gpio_drive. Before rework, initialization was done only from POST, so this patch restores previous behaviour. This patch would break the

Re: [Nouveau] [PATCH] drm/nouveau: POST the card before GPIO initialization

2012-09-14 Thread Ben Skeggs
On Fri, Sep 14, 2012 at 01:45:18PM +0200, Marcin Slusarz wrote: On Fri, Sep 14, 2012 at 04:44:59PM +1000, Ben Skeggs wrote: On Fri, Sep 14, 2012 at 12:21:33AM +0200, Marcin Slusarz wrote: Otherwise my card (nv92) never resumes from suspend to ram, hanging on nv_mask in nv50_gpio_drive

Re: [Nouveau] [PATCH] drm/nouveau: add default debug level override

2012-09-13 Thread Ben Skeggs
On Thursday, September 13, 2012, Marcin Slusarz wrote: On Thu, Sep 13, 2012 at 12:09:20PM +1000, Ben Skeggs wrote: On Thu, Sep 13, 2012 at 12:50:06AM +0200, Marcin Slusarz wrote: Useful when we don't know which subsystem is failing. This is really unnecessary unless I'm missing something

Re: [Nouveau] [PATCH] drm/nouveau: inline nv_printk into nv_assert

2012-09-13 Thread Ben Skeggs
On Thu, Sep 13, 2012 at 12:49:23AM +0200, Marcin Slusarz wrote: nv_object uses nv_assert, nv_assert uses nv_printk and nv_printk uses nv_object - which leads to recursion: drivers/gpu/drm/nouveau/core/include/core/object.h:31:1: sorry, unimplemented: inlining failed in call to

Re: [Nouveau] [PATCH] drm/nouveau: add default debug level override

2012-09-12 Thread Ben Skeggs
/gpu/drm/nouveau/core/core/option.c +++ b/drivers/gpu/drm/nouveau/core/core/option.c @@ -22,9 +22,16 @@ * Authors: Ben Skeggs */ +#include linux/module.h #include core/option.h #include core/debug.h +MODULE_PARM_DESC(debug_level, nv_printk level (0- + __stringify

Re: [Nouveau] [PATCH] drm/nouveau: restore hw accelerated buffer copies

2012-08-20 Thread Ben Skeggs
On Fri, Aug 17, 2012 at 11:47:44PM +0200, Marcin Slusarz wrote: Regression from drm/nve0: use async copy engine for ttm buffer moves if available. Oops, my bad. Applied, thanks! Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_bo.c |4 ++--

Re: [Nouveau] [PATCH 01/10] drm/nv50: decode PGRAPH status registers on TLB flush fail

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 10:59:56PM +0200, Marcin Slusarz wrote: Now it outputs: nouveau E[ PGRAPH][:02:00.0] PGRAPH TLB flush idle timeout fail nouveau E[ PGRAPH][:02:00.0] PGRAPH_STATUS: BUSY DISPATCH VFETCH CCACHE_UNK4 STRMOUT_GSCHED_UNK5 UNK14XX UNK1CXX CLIPID ZCULL ENG2D UNK34XX

Re: [Nouveau] [PATCH 06/10] drm/nouveau: sparse fixes

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 11:00:01PM +0200, Marcin Slusarz wrote: drivers/gpu/drm/nouveau/core/core/object.c:452:22: warning: non-ANSI function declaration of function 'nouveau_object_debug' drivers/gpu/drm/nouveau/core/subdev/device/base.c:64:10: warning: Initializer entry defined twice

Re: [Nouveau] [PATCH 08/10] drm/nouveau: use ioread32_native/iowrite32_native for fifo control registers

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 11:00:03PM +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- Do I miss something important why was it written this way? Nope, you didn't. It's a left-over from a *really* early revision of the userspace version of the kernel module.

Re: [Nouveau] [PATCH 09/10] drm/nv50/evo: store iomem pointer in properly typed field

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 11:00:04PM +0200, Marcin Slusarz wrote: Abuse of function pointer was noticed by sparse. I'm aware of this horror, however I didn't apply the patch. I have work in progress that'll get rid of this nasty stuff before the tree goes upstream, doing it this way was a quick

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Ben Skeggs
On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less wasteful, but didn't take into account already existing off-by-one bugs :). So: - ib_max is the last entry, so we need to

Re: [Nouveau] [PATCH 10/10] drm/nouveau: fix off-by-one bugs related to command submission in IB mode

2012-08-20 Thread Ben Skeggs
Am Dienstag, 21. August 2012 schrieb Marcin Slusarz : On Mon, Aug 20, 2012 at 04:33:24PM +1000, Ben Skeggs wrote: On Sun, Aug 19, 2012 at 11:02:00PM +0200, Marcin Slusarz wrote: Commit drm/nouveau: port all engines to new engine module format changed IB size calculation to be less

Re: [Nouveau] nouveau Macbook EDID fix upstreaming...

2012-08-19 Thread Ben Skeggs
On Fri, Aug 17, 2012 at 04:33:25PM +0800, Daniel J Blueman wrote: It looks like Ryan's Nouveau patch [1,2] to get the I2C working for EDID (thus modelines) is crucial for avoiding the Nvidia binary drivers on MacbookPro 2012s. Any plans/chance for it to be upstreamed to eg 3.6-rc3? Not at

Re: [Nouveau] [bisected] nouveau: Failed to idle channel x after resume

2012-08-08 Thread Ben Skeggs
On Mon, Aug 06, 2012 at 11:38:04PM +0300, Maxim Levitsky wrote: On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote: On Thu, Jul 5, 2012 at 11:24 PM, Martin Nyhus martin.ny...@gmx.com wrote: On Mon, 11 Jun 2012

Re: [Nouveau] [bisected] nouveau: Failed to idle channel x after resume

2012-08-08 Thread Ben Skeggs
On Wed, Aug 08, 2012 at 08:00:21AM +0200, Sven Joachim wrote: On 2012-08-08 07:37 +0200, Ben Skeggs wrote: On Mon, Aug 06, 2012 at 11:38:04PM +0300, Maxim Levitsky wrote: On Sat, 2012-08-04 at 17:41 +0300, Maxim Levitsky wrote: On Mon, 2012-07-23 at 18:25 +0300, Aioanei Rares wrote

[Nouveau] BIG changes to kernel module

2012-08-04 Thread Ben Skeggs
Hey all, I've just pushed a major rework/rewrite of the Nouveau kernel module to git[1]. Details of the whys and what-nots of the rework are in the various commit messages. At this point don't expect any exciting cool functionality, the work so far is merely a restructure to allow moving

Re: [Nouveau] [PATCH] nvc0: Add and enable vblank support

2012-08-04 Thread Ben Skeggs
On Fri, Jul 27, 2012 at 10:38 PM, Maarten Lankhorst maarten.lankho...@canonical.com wrote: Based on the original patch by Christoph Bumiller, but since it depends on kernel support patched I cannot push it yet. Hey Maarten, I've pushed support for sync-to-vblank on fermi and up (tested on NVC0,

Re: [Nouveau] [PATCH] nouveau: Do not use nva3 engine for 0xaf chipset

2012-08-04 Thread Ben Skeggs
On Sat, Aug 04, 2012 at 08:00:45AM +0200, Henrik Rydberg wrote: The nva3 copy engine exhibits random memory corruption in at least one case, the GeForce 320M (nv50, 0xaf) in the MacBookAir3,1. This patch omits creating the engine for the specific chipset, falling back to M2MF, which kills the

Re: [Nouveau] [REGRESSION] nouveau: Memory corruption using nva3 engine for 0xaf

2012-07-05 Thread Ben Skeggs
) in the MacBookAir3,1. This patch omits creating the engine for the specific chipset, falling back to M2MF, which kills the symptoms. --- Signed-off-by: Ben Skeggs bske...@redhat.com drivers/gpu/drm/nouveau/nouveau_state.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau

Re: [Nouveau] Regression: Blank screen with kernel 3.4

2012-06-15 Thread Ben Skeggs
Am Samstag, 16. Juni 2012 schrieb Karol Babioch : Hi, there seems to be a quite serious regression in kernel 3.4, at least for me. As soon as the nouveau module gets loaded my screen goes blank. There is already a bug reported on this issue in your bug tracker, see [1]. Interestingly

Re: [Nouveau] [PATCH] drm/nv50: rename INVALID_QUERY_OR_TEXTURE error to INVALID_OPERATION

2012-06-14 Thread Ben Skeggs
On Thu, Jun 14, 2012 at 11:58:08PM +0200, Marcin Slusarz wrote: Current name is misleading, because this error can be triggered by other conditions, like changing STRMOUT parameter without disabling STRMOUT first. Applied, thanks. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com ---

Re: [Nouveau] [PATCH] drm/nv84: decode PCRYPT errors

2012-06-13 Thread Ben Skeggs
On Mon, Jun 11, 2012 at 12:21:12AM +0200, Marcin Slusarz wrote: Pushed, thanks. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nv84_crypt.c | 19 --- 1 files changed, 16 insertions(+), 3 deletions(-) diff --git

Re: [Nouveau] [PATCH] nv04/exa: Reset destination surface offset in the same call of NV04EXACopy

2012-06-08 Thread Ben Skeggs
On Thu, Jun 07, 2012 at 02:51:00PM +0200, Marcin Slusarz wrote: On Sat, May 26, 2012 at 10:15:20PM +0200, Viktor Novotný wrote: Fixes FDO bug #48954. Signed-off-by: Viktor Novotný novik...@seznam.cz --- Reviewed-by: Marcin Slusarz marcin.slus...@gmail.com Thanks a lot, nice catch.

Re: [Nouveau] still seeking way to recover card after cursor disappears or card locks up

2012-05-30 Thread Ben Skeggs
On Wed, May 30, 2012 at 08:55:49PM -0700, Robert M. Riches Jr. wrote: Date: Wed, 30 May 2012 13:24:55 +0200 From: Arvydas Sidorenko asi...@gmail.com To: Robert M. Riches Jr. rm.ric...@jacob21819.net Cc: nouveau@lists.freedesktop.org On Wed, May 30, 2012 at 6:25 AM, Robert M. Riches Jr.

Re: [Nouveau] [PATCH] drm/nouveau/pm: fix oops on get/set_perflvl

2012-05-29 Thread Ben Skeggs
On Sun, May 27, 2012 at 10:00:41PM +0200, Marcin Slusarz wrote: Regression from drm/nouveau: very scary looking cleanup commit Thanks, pushed. Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com --- drivers/gpu/drm/nouveau/nouveau_pm.c |6 -- 1 files changed, 4 insertions(+), 2

Re: [Nouveau] nouveau_subdev misc patches

2012-05-21 Thread Ben Skeggs
On Mon, May 21, 2012 at 12:14:49AM +0100, Emil Velikov wrote: Hello all, this series includes a wide range of fixes - from a few month's old one-liners from Andreas Heider regarding vga_switcheroo, via a null pointer dereference and double memory allocation, to a buffer overflow. Hey, Thanks

Re: [Nouveau] [PATCH 03/14] drm/nouveau/device: Simplify init, fini fuction

2012-05-21 Thread Ben Skeggs
On Mon, May 21, 2012 at 12:14:52AM +0100, Emil Velikov wrote: Removes unnecessary goto statement I dropped these changes from this patch for the moment, I might want them yet. fini subdevices before destroying them I took this hunk, and reworded the commit message to match. Signed-off-by:

Re: [Nouveau] [PATCH 14/14] drm/nouveau/therm: Rework nouveau_therm_create()

2012-05-21 Thread Ben Skeggs
On Mon, May 21, 2012 at 12:15:03AM +0100, Emil Velikov wrote: It contains a few changes mainly targeting the following * Therm table is present in BIT vbios * Parse the vbios table before hooking temp_get(), as it contains the therm sensor calibration data * Add dummy_therm_temp_get()

Re: [Nouveau] [PATCH 14/14] drm/nouveau/therm: Rework nouveau_therm_create()

2012-05-21 Thread Ben Skeggs
On Mon, May 21, 2012 at 07:13:54AM +0100, Emil Velikov wrote: On Mon, 21 May 2012 07:30:32 +0100, Ben Skeggs skeg...@gmail.com wrote: On Mon, May 21, 2012 at 12:15:03AM +0100, Emil Velikov wrote: It contains a few changes mainly targeting the following * Therm table is present in BIT vbios

Re: [Nouveau] [PATCH] drm/nouveau/nvd9: Fix GPIO initialisation sequence.

2012-05-21 Thread Ben Skeggs
On Mon, May 21, 2012 at 02:51:50PM +0200, Marcin Kościelnicki wrote: Signed-off-by: Marcin Kościelnicki koria...@0x04.net Applied, thanks! --- drivers/gpu/drm/nouveau/nouveau_gpio.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Nouveau] [PATCH 1/4] nv30: Fix generic passing to fragment program in NV34

2012-05-11 Thread Ben Skeggs
Am Samstag, den 12.05.2012, 03:42 +0200 schrieb Roy Spliet: fixes over 800 piglit cases in quick-driver suite for NV34 Signed-off-by: Roy Spliet r.spl...@student.tudelft.nl --- src/gallium/drivers/nv30/nv30_fragprog.c |2 +- src/gallium/drivers/nv30/nv30_state.h|2 +-

Re: [Nouveau] [Patches] mesa/nv30: Diverse set of patches that improve NV3x render quality V2

2012-05-11 Thread Ben Skeggs
Am Samstag, den 12.05.2012, 03:42 +0200 schrieb Roy Spliet: A reworked version of 3 out of 4 patches mentioned earlier. [1/4]: Fixes nearly all piglit vertprog testcases, due to now being able to pass the results on to the fragment shader. V2: rename samplers to texcoords. [2/4]: Fixes

Re: [Nouveau] [kernel PATCH v2] drm/nv50: decode PGRAPH DATA_ERROR = 0x24

2012-05-08 Thread Ben Skeggs
On Sun, 2012-05-06 at 23:08 +0200, Marcin Slusarz wrote: Signed-off-by: Marcin Slusarz marcin.slus...@gmail.com Pushed, thanks! --- v2: sync name to envytools --- drivers/gpu/drm/nouveau/nv50_graph.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

Re: [Nouveau] NV43: Native resolution not available on Dell 2007FP

2012-05-04 Thread Ben Skeggs
On Saturday, 5 May 2012, Mark Hills wrote: On Sat, 5 May 2012, Maarten Maathuis wrote: On Fri, May 4, 2012 at 5:55 PM, Mark Hills m...@pogo.org.uk wrote: I have a Dell 2007FP monitor. NV43 (GeForce 6600) can not use the native resolution. 1600x1200 is listed under DDC gathered

Re: [Nouveau] [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-05-02 Thread Ben Skeggs
On Sat, 2012-04-28 at 16:49 +0200, Marcin Slusarz wrote: On Thu, Apr 26, 2012 at 05:32:29PM +1000, Ben Skeggs wrote: On Wed, 2012-04-25 at 23:20 +0200, Marcin Slusarz wrote: Overall idea: Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, handle them at ioctl

Re: [Nouveau] [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-05-02 Thread Ben Skeggs
On Wed, 2012-05-02 at 15:33 +0200, Martin Peres wrote: On 02/05/2012 13:28, Ben Skeggs wrote: Right, again, I don't disagree :) I think we can improve a lot on the big-hammer-suspend-the-gpu solution though, and instead reset only the faulting engine. It's (in theory) almost possible

Re: [Nouveau] [PATCH v2 4/4] drm/nouveau: gpu lockup recovery

2012-04-26 Thread Ben Skeggs
On Wed, 2012-04-25 at 23:20 +0200, Marcin Slusarz wrote: Overall idea: Detect lockups by watching for timeouts (vm flush / fence), return -EIOs, handle them at ioctl level, reset the GPU and repeat last ioctl. GPU reset is done by doing suspend / resume cycle with few tweaks: - CPU-only bo

Re: [Nouveau] [WIP PATCH] dri/nouveau: Add S3TC support for nv20.

2012-04-24 Thread Ben Skeggs
On Fri, 2012-04-06 at 17:40 +0200, Viktor Novotný wrote: --- Hi, Hey Viktor! Thanks for the patch! this is still WIP, but already passes piglit's s3tc-teximage, s3tc-texsubimage and fbo-generatemipmap-formats(s3tc tests) and even Wolfenstein:Enemy-Territory works on my nv25. It's based

Re: [Nouveau] [RFC PATCH 5/5] drm/nouveau: gpu lockup recovery

2012-04-24 Thread Ben Skeggs
On Tue, 2012-04-24 at 21:31 +0200, Marcin Slusarz wrote: On Mon, Apr 23, 2012 at 06:56:44PM +0200, Martin Peres wrote: Le 23/04/2012 18:32, Marcin Slusarz a écrit : Just run piglit. Even quick tests can cause ~5 lockups (it eventually messes up DDX channel, but this patchset can't

Re: [Nouveau] rendering problems with latest ddx driver (nv50)

2012-04-24 Thread Ben Skeggs
On Tue, 2012-04-24 at 20:14 +0200, Maarten Maathuis wrote: Do you get rendering errors also when using a nv50 class gpu? I seem to get them in firefox. Hmm, I haven't noticed anything on my NVA8 laptop. I also noticed a huge amount of failures when running rendercheck -t gradients, which i

Re: [Nouveau] [PATCH 2/5] drm/nouveau: base fence timeout on time of emission

2012-04-23 Thread Ben Skeggs
On Mon, 2012-04-23 at 00:18 +0200, Marcin Slusarz wrote: Wait loop can be interrupted by signal, so if signals are raised periodically (e.g. SIGALRM) this loop may never finish. Use emission time as a base for fence timeout. Ah, thanks for tackling this issue. It's been long on my list of

Re: [Nouveau] [PATCH] drm/nv50/vm: Prevent kernel freeze

2012-02-29 Thread Ben Skeggs
On Mon, 2012-02-27 at 21:01 +, Emil Velikov wrote: Commit 'drm/nv50-nvc0/vm: support unsnooped system memory' caused a regression on certain nv50 IGP due to not passing the correct target type to nv50_vm_addr() Thanks for this, I've pushed it to the nouveau tree. Ben. Fixes:

Re: [Nouveau] [Patches][nouveau/ddx]: Improvements to bufferswap implementation and timestamping

2012-02-28 Thread Ben Skeggs
On Thu, 2012-02-16 at 00:45 +0100, Mario Kleiner wrote: Hi, Hey Mario, What's your plan with this patchset? Do you intend on taking Michel's comments into account? CC'ing Francisco as he had some comments on IRC. I'd like to get this all sorted and merged so I can rebase the

Re: [Nouveau] [PATCH 2/2] nouveau: implement precise vblank timestamping

2012-02-15 Thread Ben Skeggs
On Wed, 2012-02-15 at 23:55 +0100, Mario Kleiner wrote: From: Lucas Stach d...@lynxeye.de This patch implements the drivers hooks needed for precise vblank timestamping. This is a complementary patch to Mario Kleiner's patches to improve swap scheduling. With the complete patchset applied

Re: [Nouveau] [PATCH RFC] drm/nouveau/dp: fix bad comparison in dp_link_train_commit()

2012-02-05 Thread Ben Skeggs
On Fri, 2012-02-03 at 11:13 -0500, Xi Wang wrote: The comparison (lpre == DP_TRAIN_PRE_EMPHASIS_9_5) is always false: lpre is initialized as (lane 0x0c) 2, which is at most 3, while DP_TRAIN_PRE_EMPHASIS_9_5 is defined as (3 3). I've picked up the patch. Thank you! Ben. Signed-off-by:

Re: [Nouveau] properly check for _DSM function support and Optimus support for vga_switcheroo

2012-01-09 Thread Ben Skeggs
On Mon, 2012-01-09 at 00:13 +0100, Lekensteyn wrote: Any activity on this? The newly attached patch contains one difference with the previous one: a dummy function has been added to avoid an error if ACPI is disabled. Dave, Any thoughts on this? Ben. Regards, Lekensteyn On Mon, Dec

Re: [Nouveau] Bisect: i2c regression in 63daa9589cb88617d9cc8a0b0282564682a975b7

2012-01-02 Thread Ben Skeggs
On Sun, 2012-01-01 at 22:38 +0100, Vincent Pelletier wrote: Hi. Hey, Updating nouveau module to a newer git revision, I noticed I lost hwmon. I ran a bisect, which identified 63daa9589cb88617d9cc8a0b0282564682a975b7 as being the first bad commit. Adding printk traces, I saw that

Re: [Nouveau] enable ctxprog xfer only when we need it to save power introduces big performance regression

2011-10-29 Thread Ben Skeggs
On Sat, 2011-10-29 at 20:00 +0200, Maarten Maathuis wrote: On Sat, Oct 29, 2011 at 7:29 PM, Marcin Slusarz marcin.slus...@gmail.com wrote: On Sat, Oct 29, 2011 at 07:08:01PM +0200, Marcin Slusarz wrote: Hi I've bisected pretty big performance regression (nv92): $ git bisect good

Re: [Nouveau] geforce 9800m gt HDMI

2011-10-11 Thread Ben Skeggs
On Tue, 2011-10-11 at 23:31 +0200, Michele Cane wrote: Hi all, Hey, I have compiled the latest kernel to test HDMI sound but is not working. I would like to know if my card geforce 9800m gt (NV92 NV50 family) is supposed to support this feature. It's not expected to work at all with

<    4   5   6   7   8   9   10   11   >