Re: How to create patch?

2007-06-01 Thread Dennis Kubes
Take a look at this from the wiki: http://wiki.apache.org/nutch/Becoming_A_Nutch_Developer It shows how to create a patch from SVN. To apply a patch to your source code you would use the patch command (on linux) like this: patch -p0 your_patch_file.patch Dennis Kubes Manoharam Reddy

[jira] Commented: (NUTCH-392) OutputFormat implementations should pass on Progressable

2007-06-01 Thread JIRA
[ https://issues.apache.org/jira/browse/NUTCH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500603 ] Doğacan Güney commented on NUTCH-392: - From what I understand of MapFile.Writer code in hadoop, if you give

Re: How to create patch?

2007-06-01 Thread Marcin Okraszewski
http://wiki.apache.org/nutch/HowToContribute On 6/1/07, Manoharam Reddy [EMAIL PROTECTED] wrote: I have seen some patches been exchanged in the list. I want to know how this patch is created and how is it applied? Any pointers to tutorials on net or wiki or a plain reply here would be

[jira] Commented: (NUTCH-392) OutputFormat implementations should pass on Progressable

2007-06-01 Thread Andrzej Bialecki (JIRA)
[ https://issues.apache.org/jira/browse/NUTCH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500635 ] Andrzej Bialecki commented on NUTCH-392: - Good point. We can change it to use the following pattern (as

[jira] Commented: (NUTCH-392) OutputFormat implementations should pass on Progressable

2007-06-01 Thread Andrzej Bialecki (JIRA)
[ https://issues.apache.org/jira/browse/NUTCH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500728 ] Andrzej Bialecki commented on NUTCH-392: - I think it is okay to allow BLOCK compression for linkdb,

Re: Plugins and Thread Safety

2007-06-01 Thread Andrzej Bialecki
Briggs wrote: What is the design contract on plugins when it comes to thread safety? I was under the assumption that plugins should be thread safe, but I have been running into concurrent modification exceptions from the language identifier plugin while indexing. My application is a bit They

Plugins and Thread Safety

2007-06-01 Thread Briggs
What is the design contract on plugins when it comes to thread safety? I was under the assumption that plugins should be thread safe, but I have been running into concurrent modification exceptions from the language identifier plugin while indexing. My application is a bit different from the

Re: Plugins and Thread Safety

2007-06-01 Thread Briggs
Oh, you want me to change the getSorted method to be synchronized? I'll put a lock in there and see what happens, if that is what you are referring to. On 6/1/07, Andrzej Bialecki [EMAIL PROTECTED] wrote: Briggs wrote: What is the design contract on plugins when it comes to thread safety? I

Re: Plugins and Thread Safety

2007-06-01 Thread Andrzej Bialecki
Briggs wrote: Oh, you want me to change the getSorted method to be synchronized? I'll put a lock in there and see what happens, if that is what you are referring to. Yes, please try this change. -- Best regards, Andrzej Bialecki ___. ___ ___ ___ _ _ __

Re: Plugins and Thread Safety

2007-06-01 Thread Briggs
I will get back to you. It isn't the easiest bug to test. So, will let you know soon! On 6/1/07, Andrzej Bialecki [EMAIL PROTECTED] wrote: Briggs wrote: Oh, you want me to change the getSorted method to be synchronized? I'll put a lock in there and see what happens, if that is what you are

[jira] Commented: (NUTCH-392) OutputFormat implementations should pass on Progressable

2007-06-01 Thread Doug Cutting (JIRA)
[ https://issues.apache.org/jira/browse/NUTCH-392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500822 ] Doug Cutting commented on NUTCH-392: Anchors, explain, and the cache are used relatively infrequently,

[PATCH] Moving HitDetails construction to a HitDetails constructor (v2).

2007-06-01 Thread Nicolás Lichtmaier
This is a fixed version of the previous patch. Please, don't ignore me =). I'm trying to use Lucene queries with Nutch and this patch will help. This patch also removes a deprecated API usage, removes useless object creation and array copying. Thanks! Index:

Re: [PATCH] Moving HitDetails construction to a HitDetails constructor (v2).

2007-06-01 Thread Andrzej Bialecki
Nicolás Lichtmaier wrote: This is a fixed version of the previous patch. In the future, please use JIRA bug tracking system to submit patches. Please, don't ignore me =). We don't - but there's only so much ou can do in 24 hrs/day, and Nutch developers have their own lives to attend to