Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-07 Thread Dawid Weiss
My feeling was simply that the closest we are to Nutch-1.0, the more be need some QA metrics (for us and for nutch users). No? I absolutely agree Jérôme, really. It's just that developers usually tend to hook up dozens of QA plugins and never look at what they output (that's the usual

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-07 Thread Jérôme Charron
My feeling was simply that the closest we are to Nutch-1.0, the more be need some QA metrics (for us and for nutch users). No? I absolutely agree Jérôme, really. It's just that developers usually tend to hook up dozens of QA plugins and never look at what they output (that's the usual

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-06 Thread Dawid Weiss
Other options (raised on the Hadoop list) are Checkstyle: PMD seems to be the best choice for an Apache project and they all seem to perform at a similar level. Anything that generates a lot of false positives is bad: it either causes us to skip analysis of lots of files, or ignore the

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-06 Thread Piotr Kosiorowski
+1 - I offer my help - we can coordinate it and I can do a part of work. I will also try to commit your patches quickly. Piotr On 4/6/06, Dawid Weiss [EMAIL PROTECTED] wrote: Other options (raised on the Hadoop list) are Checkstyle: PMD seems to be the best choice for an Apache project and

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-06 Thread Dawid Weiss
All right, I though I'd give it a go since I have a spare few minutes. Jura is off, so I made the patches available here -- http://ophelia.cs.put.poznan.pl/~dweiss/nutch/ pmd.patch is the build file patch and libraries (binaries are in a separate zip file pmd-ext.zip). pmd-fixes.patch

PMD integration (was: Re: Add .settings to svn:ignore on root Nutch folder?)

2006-04-06 Thread Piotr Kosiorowski
Hi, I have downloaded the patches and generally like them (I had only read them not applied yet). I have one question - am I reading it correctly that right now it is checking only main code (without plugins?). P. Dawid Weiss wrote: All right, I though I'd give it a go since I have a spare

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-06 Thread Jérôme Charron
With code coverage... I don't know. It's up to you guys -- you spend much more time on Nutch code than I do and you know best what is needed and what isn't. My feeling was simply that the closest we are to Nutch-1.0, the more be need some QA metrics (for us and for nutch users). No? Jérôme

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-05 Thread Dawid Weiss
One can presumably disable such minor warnings in Eclipse. Arguably the bug is that Eclipse warns about such things by default, rather than in a 'pedantic' mode. I agree -- some of them are really annoying. Plus, Eclipse has been having notorious problems showing warnings for unused

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-05 Thread Jérôme Charron
PMD looks like a useful such tool: http://pmd.sourceforge.net/ant-task.html I would not be opposed to integrating PMD or something similar into Nutch's build.xml. What do others think? Any volunteers? +1 (Very configurable, very good tool!)

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-05 Thread Dawid Weiss
I'm a fan of automated testing and code analysis utilities, but I must say they only make sense if people actually use them and look at their results. So it's not really just about integration -- it's about looking at the results of these tools. PMD is neat because it can simply interrupt

Re: Add .settings to svn:ignore on root Nutch folder?

2006-04-05 Thread Doug Cutting
Other options (raised on the Hadoop list) are Checkstyle: http://checkstyle.sourceforge.net/ and FindBugs: http://findbugs.sourceforge.net/ Although these are both under LGPL and thus harder to include in Apache projects. Anything that generates a lot of false positives is bad: it either

Add .settings to svn:ignore on root Nutch folder?

2006-04-04 Thread Dawid Weiss
Would it be a problem to add Eclipse's .settings folder to ignored files (since Eclipse project files are already there anyway). This file is used when one wants to override default project configuration (code formatting, specific JVM etc). Dawid