Re: [PATCH] tools/testing/nvdimm: Drop empty platform remove function

2023-06-06 Thread Dan Williams
Uwe Kleine-König wrote: > Hello Dan, > > On Tue, May 09, 2023 at 07:55:46AM +0200, Uwe Kleine-König wrote: > > On Tue, Dec 13, 2022 at 11:09:23AM -0800, Dan Williams wrote: > > > Uwe Kleine-König wrote: > > > > A remove callback just returning 0 is equivalent to no remove callback > > > > at all.

Re: [PATCH 4/4] dax: Cleanup extra dax_region references

2023-06-06 Thread Ira Weiny
Fan Ni wrote: > The 06/02/2023 23:14, Dan Williams wrote: > > Now that free_dev_dax_id() internally manages the references it needs > > the extra references taken by the dax_region drivers are not needed. > > > > Reported-by: Ira Weiny > > Signed-off-by: Dan Williams > > Reviewed-by: Fan Ni >

Re: [PATCH 4/4] dax: Cleanup extra dax_region references

2023-06-06 Thread Fan Ni
The 06/02/2023 23:14, Dan Williams wrote: > Now that free_dev_dax_id() internally manages the references it needs > the extra references taken by the dax_region drivers are not needed. > > Reported-by: Ira Weiny > Signed-off-by: Dan Williams Reviewed-by: Fan Ni One minor comment as below. >

Re: [PATCH] tools/testing/nvdimm: Drop empty platform remove function

2023-06-06 Thread Uwe Kleine-König
Hello Dan, On Tue, May 09, 2023 at 07:55:46AM +0200, Uwe Kleine-König wrote: > On Tue, Dec 13, 2022 at 11:09:23AM -0800, Dan Williams wrote: > > Uwe Kleine-König wrote: > > > A remove callback just returning 0 is equivalent to no remove callback > > > at all. So drop the useless function. > > >