Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT

2023-08-01 Thread Chaitanya Kulkarni
On 8/1/23 10:49, Jeff Moyer wrote: > Hi, Christoph, > > Christoph Hellwig writes: > >> On Tue, Aug 01, 2023 at 11:23:36AM -0400, Jeff Moyer wrote: >>> I am slightly embarrassed to have to ask this question, but what are the >>> implications of setting this queue flag? Is the submit_bio routine

Re: [PATCH ndctl v2] ndctl/cxl/test: Add CXL event test

2023-08-01 Thread Ira Weiny
Verma, Vishal L wrote: > On Mon, 2023-07-31 at 16:53 -0700, Ira Weiny wrote: > > Previously CXL event testing was run by hand.  This reduces testing > > Reduces or increases / improves? Or did you mean running by hand > reduced coverage. Running by hand reduces test coverage. > > Maybe this

Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT

2023-08-01 Thread Jeff Moyer
Hi, Christoph, Christoph Hellwig writes: > On Tue, Aug 01, 2023 at 11:23:36AM -0400, Jeff Moyer wrote: >> I am slightly embarrassed to have to ask this question, but what are the >> implications of setting this queue flag? Is the submit_bio routine >> expected to never block? > > Yes, at least

Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT

2023-08-01 Thread Christoph Hellwig
On Tue, Aug 01, 2023 at 11:23:36AM -0400, Jeff Moyer wrote: > I am slightly embarrassed to have to ask this question, but what are the > implications of setting this queue flag? Is the submit_bio routine > expected to never block? Yes, at least not significantly. > Is the I/O expected to be

Re: [PATCH V2 1/1] pmem: set QUEUE_FLAG_NOWAIT

2023-08-01 Thread Jeff Moyer
Chaitanya Kulkarni writes: > Set the QUEUE_FLAG_NOWAIT. Following are the performance numbers with > io_uring fio engine for random read, note that device has been populated > fully with randwrite workload before taking these numbers :- I am slightly embarrassed to have to ask this question,