Re: [ndctl PATCH v5 3/5] cxl/list: collect and parse the poison list records

2023-12-06 Thread Dan Williams
alison.schofield@ wrote: > From: Alison Schofield > > Poison list records are logged as events in the kernel tracing > subsystem. To prepare the poison list for cxl list, enable tracing, > trigger the poison list read, and parse the generated cxl_poison > events into a json representation. > >

[PATCH 0/2] Add DAX ABI for memmap_on_memory

2023-12-06 Thread Vishal Verma
The DAX drivers were missing sysfs ABI documentation entirely. Add this missing documentation for the sysfs ABI for DAX regions and Dax devices in patch 1. Add a new ABI for toggling memmap_on_memory semantics in patch 2. The missing ABI was spotted in [1], this series is a split of the new ABI

[PATCH 2/2] dax: add a sysfs knob to control memmap_on_memory behavior

2023-12-06 Thread Vishal Verma
Add a sysfs knob for dax devices to control the memmap_on_memory setting if the dax device were to be hotplugged as system memory. The default memmap_on_memory setting for dax devices originating via pmem or hmem is set to 'false' - i.e. no memmap_on_memory semantics, to preserve legacy behavior.

Re: [ndctl PATCH v5 4/5] cxl/list: add --poison option to cxl list

2023-12-06 Thread Dan Williams
alison.schofield@ wrote: > From: Alison Schofield > > The --poison option to 'cxl list' retrieves poison lists from > memory devices supporting the capability and displays the > returned poison records in the cxl list json. This option can > apply to memdevs or regions. > > Example usage in the

Re: [PATCH] tools/testing/nvdimm: Add compile-test coverage for ndtest

2023-12-06 Thread Ira Weiny
Dan Williams wrote: > Greg lamented: > "Ick, sorry about that, obviously this test isn't actually built by any > bots :(" > > A quick and dirty way to prevent this problem going forward is to always > compile ndtest.ko whenever nfit_test is built. While this still does not > expose the test code

[PATCH] tools/testing/nvdimm: Add compile-test coverage for ndtest

2023-12-06 Thread Dan Williams
Greg lamented: "Ick, sorry about that, obviously this test isn't actually built by any bots :(" A quick and dirty way to prevent this problem going forward is to always compile ndtest.ko whenever nfit_test is built. While this still does not expose the test code to any of the known build bots, it

RE: [ndctl PATCH 3/3] test/cxl-region-sysfs.sh: Fix cxl-region-sysfs.sh: line 107: [: missing `]'

2023-12-06 Thread Dan Williams
Li Zhijian wrote: > Signed-off-by: Li Zhijian Please no patches with empty changelogs. Commentary on the impact of the change is always welcome. Otherwise change looks good to me, and I wonder why this error is only triggering now? Acked-by: Dan Williams > --- > test/cxl-region-sysfs.sh | 2

RE: [ndctl PATCH 2/3] test/cxl-region-sysfs.sh: use operator '!=' to compare hexadecimal value

2023-12-06 Thread Dan Williams
Li Zhijian wrote: > Fix errors: > line 111: [: 0x8000: integer expression expected > line 112: [: 0x3ff11000: integer expression expected > line 141: [: 0x8000: integer expression expected > line 143: [: 0x3ff11000: integer expression expected Similar commentary on how found and

RE: [ndctl PATCH 1/3] test/cxl-region-sysfs.sh: covert size and resource to hex before test

2023-12-06 Thread Dan Williams
I would summarize this as "Fix hex vs decimal confusion" Li Zhijian wrote: > size and resource are both decimal Please always describe the "why" in the changelog including the motivation for the change and the effect of not applying the patch. I.e. how would someone know that they are hitting