On Tue, 2023-12-05 at 13:22 -0800, Ira Weiny wrote:
> Verma, Vishal L wrote:
>
> [snip]
>
> > > >
> > >
> > Correct, the set -e will cause the script to abort with an error exit
> > code whenever a command fails.
> >
> > I do wonder if we need this new test - with Dave's patch here[1],
>
>
Verma, Vishal L wrote:
[snip]
> > > > +# Find a memory device to create regions on to test the destroy
> > > > +readarray -t mems < <("$CXL" list -b cxl_test -M | jq -r '.[].memdev')
> > > > +for mem in ${mems[@]}; do
> > > > + ramsize=$($CXL list -m $mem | jq -r '.[].ram_size')
> > > > +
On Mon, 2023-12-04 at 10:05 -0800, Ira Weiny wrote:
> Alison Schofield wrote:
> > On Thu, Nov 30, 2023 at 08:06:13PM -0800, Ira Weiny wrote:
>
> [snip]
>
> > > +
> > > +check_destroy_devdax()
> > > +{
> > > + mem=$1
> > > + decoder=$2
> > > +
> > > + region=$($CXL create-region
Alison Schofield wrote:
> On Thu, Nov 30, 2023 at 08:06:13PM -0800, Ira Weiny wrote:
[snip]
> > +
> > +check_destroy_devdax()
> > +{
> > + mem=$1
> > + decoder=$2
> > +
> > + region=$($CXL create-region -d "$decoder" -m "$mem" | jq -r ".region")
> > + if [ "$region" == "null" ]; then
> >
On Thu, Nov 30, 2023 at 08:06:13PM -0800, Ira Weiny wrote:
> Commit 9399aa667ab0 ("cxl/region: Add -f option for disable-region")
> introduced a regression when destroying a region.
>
> Add a tests for destroying a region.
>
> Cc: Dave Jiang
> Signed-off-by: Ira Weiny
> ---
>
On 11/30/23 21:06, Ira Weiny wrote:
> Commit 9399aa667ab0 ("cxl/region: Add -f option for disable-region")
> introduced a regression when destroying a region.
>
> Add a tests for destroying a region.
>
> Cc: Dave Jiang
> Signed-off-by: Ira Weiny
Reviewed-by: Dave Jiang
> ---
>
Commit 9399aa667ab0 ("cxl/region: Add -f option for disable-region")
introduced a regression when destroying a region.
Add a tests for destroying a region.
Cc: Dave Jiang
Signed-off-by: Ira Weiny
---
test/cxl-destroy-region.sh | 76 ++
