[okular] [Bug 386408] Text color printed incorrectly

https://bugs.kde.org/show_bug.cgi?id=386408 --- Comment #2 from SP --- (In reply to Albert Astals Cid from comment #1) > Does print preview show the colors correctly? Yes -- You are receiving this mail because: You are the assignee for the bug.

KDE CI: Applications okular kf5-qt5 FedoraQt5.8 - Build # 92 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FedoraQt5.8/92/ Project: Applications okular kf5-qt5 FedoraQt5.8 Date of build: Thu, 02 Nov 2017 22:41:53 + Build duration: 12 min and counting JUnit Tests

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 98 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/98/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 02 Nov 2017 22:41:53 + Build duration: 7 min 0 sec and counting JUnit Tests

[okular] [Bug 385980] Darstellungs Problem

https://bugs.kde.org/show_bug.cgi?id=385980 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 386408] Text color printed incorrectly

https://bugs.kde.org/show_bug.cgi?id=386408 Albert Astals Cid changed: What|Removed |Added CC||aa...@kde.org

[okular] [Bug 315552] Allow save annotations directly to original pdf file

https://bugs.kde.org/show_bug.cgi?id=315552 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

[okular] [Bug 385943] Feature Request: Option to save annotations with regular save

https://bugs.kde.org/show_bug.cgi?id=385943 Simon Andric changed: What|Removed |Added CC||simonandr...@gmail.com

D8379: PDF: Support the new poppler renderToImage with update callback

rkflx added a comment. In https://phabricator.kde.org/D8379#163666, @mwolff wrote: > FWIW: I ran it here, and it worked fine after the crash fix. Only tested it on the dublin map though. Thanks, good to know :) REPOSITORY R223 Okular REVISION DETAIL

D8379: PDF: Support the new poppler renderToImage with update callback

mwolff added a comment. In https://phabricator.kde.org/D8379#163631, @rkflx wrote: > @aacid In general I notice the changes you are making, sorry I'm not always able test immediately. I'll try to have another look in the next couple of days. > > (That said, more people testing by

[okular] [Bug 386468] New: Okular does not understand right to left languages like Persian etc.

https://bugs.kde.org/show_bug.cgi?id=386468 Bug ID: 386468 Summary: Okular does not understand right to left languages like Persian etc. Product: okular Version: 0.20.3 Platform: Ubuntu Packages OS: Linux

KDE CI: Applications okular kf5-qt5 FreeBSDQt5.7 - Build # 97 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20kf5-qt5%20FreeBSDQt5.7/97/ Project: Applications okular kf5-qt5 FreeBSDQt5.7 Date of build: Thu, 02 Nov 2017 16:50:26 + Build duration: 16 min and counting JUnit Tests

D8379: PDF: Support the new poppler renderToImage with update callback

rkflx added a comment. @aacid In general I notice the changes you are making, sorry I'm not always able test immediately. I'll try to have another look in the next couple of days. (That said, more people testing by actually running the code with the newest Poppler would be great.)

KDE CI: Applications okular stable-kf5-qt5 FedoraQt5.8 - Build # 40 - Still Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Applications%20okular%20stable-kf5-qt5%20FedoraQt5.8/40/ Project: Applications okular stable-kf5-qt5 FedoraQt5.8 Date of build: Thu, 02 Nov 2017 16:49:36 + Build duration: 13 min and counting JUnit

D8379: PDF: Support the new poppler renderToImage with update callback

aacid added a comment. @rkflx i rebased this patch on top of master that includes https://cgit.kde.org/okular.git/commit/?id=662fa69a2dcc0c1403b1773262368943d5cacd52 This fixes for me the crashes on rotation jobs, the bug wasn't on this branch, it's just that now that codepath was

D8379: PDF: Support the new poppler renderToImage with update callback

aacid updated this revision to Diff 21790. aacid added a comment. rebased REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8379?vs=21756=21790 BRANCH updateCallback (branched from master) REVISION DETAIL https://phabricator.kde.org/D8379 AFFECTED FILES

[okular] [Bug 382725] Okular crashes when rotating view in multi-page pdf document

https://bugs.kde.org/show_bug.cgi?id=382725 Albert Astals Cid changed: What|Removed |Added Latest Commit||https://commits.kde.org/oku

D8379: PDF: Support the new poppler renderToImage with update callback

mwolff accepted this revision. mwolff added a comment. lgtm from my side INLINE COMMENTS > generator_pdf.cpp:920 > + > +// Since the timer lives in a thread without even loop we need to stop > it ourselves > +// when the remaining time has reached 0 typo: "without _an_ even_t_

D8379: PDF: Support the new poppler renderToImage with update callback

aacid updated this revision to Diff 21756. aacid added a comment. Add comment about why we need to stop the timer manually REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8379?vs=21754=21756 BRANCH updateCallback (branched from master) REVISION DETAIL

D8379: PDF: Support the new poppler renderToImage with update callback

aacid marked an inline comment as done. aacid added inline comments. INLINE COMMENTS > mwolff wrote in generator_pdf.cpp:919 > That's quite surprising to me. I thought a singleshot timer gets inactivated > automatically after the first shot... Is that really not the case? So both you and I are

D8379: PDF: Support the new poppler renderToImage with update callback

mwolff added inline comments. INLINE COMMENTS > aacid wrote in generator.h:581 > Are you asking for a reword? i see both my and your sentence basically say > the same? well, mine is shorted. Your's probably refers to going through the event loop or something? It boils down to the same thing.

D8379: PDF: Support the new poppler renderToImage with update callback

aacid marked an inline comment as done. aacid added inline comments. INLINE COMMENTS > mwolff wrote in generator.cpp:407 > is `setPixmap` old API? Why create a QPixmap on the heap? That should not be > done, pass values instead. Yes, it's existing (not old :P) API > mwolff wrote in

D8379: PDF: Support the new poppler renderToImage with update callback

aacid updated this revision to Diff 21753. aacid added a comment. Update code for new poppler patch that uses a QVariant for the payload REPOSITORY R223 Okular CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8379?vs=21609=21753 BRANCH updateCallback (branched from master)