D7714: Show dialog to ask when closing when more than tab open

aacid abandoned this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

aacid requested review of this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

aacid planned changes to this revision. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. I'm going to commit this since it seems Henrik has a plan for the bigger thing. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: alexeymin, ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

rkflx added a comment. That's great, now code can be written. To track progress (but not to discuss with other application developers as requested, at least for now) I opened https://phabricator.kde.org/T7022. Any help is welcome, please add your name if you start working on an item

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. In https://phabricator.kde.org/D7714#146282, @rkflx wrote: > In https://phabricator.kde.org/D7714#145952, @aacid wrote: > > > Ok, so i will abandon this and we won't ever get a fix. > > > > Because that's what's going to happen, but sure, let's do perfection

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. In https://phabricator.kde.org/D7714#146279, @ngraham wrote: > So for the record, I agree with folks that our "are you sure you want to close all these tabs" dialogs could stand for a bit of usability polishing. > > However, that's a larger task--one that I am

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. In https://phabricator.kde.org/D7714#145970, @ngraham wrote: > I'm willing to commandeer this patch and work with folks to do the wording change. Do you approve, Albert? As far as I understand Henrik is against this patch going in unless Dolphin and

D7714: Show dialog to ask when closing when more than tab open

rkflx added a comment. In https://phabricator.kde.org/D7714#145952, @aacid wrote: > Ok, so i will abandon this and we won't ever get a fix. > > Because that's what's going to happen, but sure, let's do perfection instead of good enough. I'll interpret that as a "no" to my

D7714: Show dialog to ask when closing when more than tab open

ngraham added a comment. So for the record, I agree with folks that our "are you sure you want to close all these tabs" dialogs could stand for a bit of usability polishing. However, that's a larger task--one that I am willing to spearhead, but nonetheless outside the scope of this

D7714: Show dialog to ask when closing when more than tab open

ngraham added a comment. I'm willing to commandeer this patch and with with folks to do the wording change. Do you approve, Albert? REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: ngraham, colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

ngraham added reviewers: Okular, KDE Applications. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid, #okular, #kde_applications Cc: colomar, rkflx, #okular, aacid

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. Ok, so i will abandon this and we won't ever get a fix. Because that's what's going to happen, but sure, let's do perfection instead of good enough. REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D7714 To: aacid Cc: colomar, rkflx,

D7714: Show dialog to ask when closing when more than tab open

rkflx added a comment. For reference, here is Konsole (which other KDE apps with tabs did I miss?): F3910099: konsole.png In https://phabricator.kde.org/D7714#145298, @colomar wrote: > [...] > No need to reinvent the wheel here.

D7714: Show dialog to ask when closing when more than tab open

colomar added a comment. Why don't we simply copy the Firefox dialog? Firefox has a big userbase and with the default settings, the vast majority of users will see this dialog at some point. Therefore if their wording was problematic, it's very likely someone would have flamed them for it.

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. In https://phabricator.kde.org/D7714#144296, @rkflx wrote: > > What part of "Are you sure you want to quit" Yes/No you find ambiguous? > > KDE's HIG says > > Label command buttons with an imperative verb. > > > and also > > Use descriptive

D7714: Show dialog to ask when closing when more than tab open

rkflx added a subscriber: colomar. rkflx added a comment. > What part of "Are you sure you want to quit" Yes/No you find ambiguous? KDE's HIG says Label command buttons with an imperative verb. and also Use descriptive button labels instead of standard Yes/No or

D7714: Show dialog to ask when closing when more than tab open

aacid added a comment. In https://phabricator.kde.org/D7714#144118, @rkflx wrote: > Thanks for picking up old reviewboard requests. It's what being the defacto maitainer means > I like the feature in general, it is standard in a lot of applications today. > > But to

D7714: Show dialog to ask when closing when more than tab open

rkflx added a comment. Thanks for picking up old reviewboard requests. I like the feature in general, it is standard in a lot of applications today. But to make it easier to use, users should not relearn the UI they are already familiar with. This is what Dolphin currently provides vs.

D7714: Show dialog to ask when closing when more than tab open

aacid created this revision. Restricted Application added a subscriber: Okular. Restricted Application added a project: Okular. REVISION SUMMARY The checkbox is checked and says "Warn me on closing more than one tab", for that reason we can't use the default KMessageBox::questionYesNo since