Re: [OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Richard Purdie
On Wed, 2023-06-07 at 14:29 +0200, Alexander Kanavin wrote: > On Wed, 7 Jun 2023 at 14:23, Alexis Lothoré > wrote: > > > Then core-image-ptest.bb should append "${libdir}/{MCNAME}/ptest" to > > > that. As that same image recipe installs only a single ptest via > > > IMAGE_INSTALL:append, and the

Re: [OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Alexander Kanavin
On Wed, 7 Jun 2023 at 14:23, Alexis Lothoré wrote: > > Then core-image-ptest.bb should append "${libdir}/{MCNAME}/ptest" to > > that. As that same image recipe installs only a single ptest via > > IMAGE_INSTALL:append, and the artifacts are retrieved only if that > > ptest would fail, this would

Re: [OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Alexis Lothoré via lists . openembedded . org
Hello Alexander, Richard, Thanks for the feedback. Indeed my testing setup is quite minimal, so it may not reflect how many files may be pulled in real cases. On 6/7/23 11:20, Alexander Kanavin wrote: > What might work better without code complications is testimage.bbclass > setting only the

Re: [OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Alexander Kanavin
What might work better without code complications is testimage.bbclass setting only the minimum set (no ptests): +TESTIMAGE_FAILED_QA_ARTIFACTS ??= "\ +${localstatedir}/log \ +${sysconfdir}/version \ +${sysconfdir}/os-release \ " Then core-image-ptest.bb should append

Re: [OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Richard Purdie
On Wed, 2023-06-07 at 10:30 +0200, Alexis Lothoré via lists.openembedded.org wrote: > Add a basic artifacts retrievers in testimage class which: > - triggers when at least one runtime test fails but tests execution > encountered no major issue > - reads a list of paths to retrieve from

[OE-Core][PATCH v2 2/2] testimage: implement test artifacts retriever for failing tests

2023-06-07 Thread Alexis Lothoré via lists . openembedded . org
Add a basic artifacts retrievers in testimage class which: - triggers when at least one runtime test fails but tests execution encountered no major issue - reads a list of paths to retrieve from TESTIMAGE_FAILED_QA_ARTIFACTS - checks for artifacts presence on target - retrieve those files over