Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-08 Thread Corey Minyard
On 07/07/2010 11:05 PM, Justin P. Mattock wrote: what ever came about with this? Justin P. Mattock Well, Sergey sent a patch, but I don't think it was quite in a form that can be taken. Do you want to resend per the standard rules? -corey

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-08 Thread Justin P. Mattock
On 07/08/2010 11:28 AM, Corey Minyard wrote: On 07/07/2010 11:05 PM, Justin P. Mattock wrote: what ever came about with this? Justin P. Mattock Well, Sergey sent a patch, but I don't think it was quite in a form that can be taken. Do you want to resend per the standard rules? -corey

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-07 Thread Justin P. Mattock
what ever came about with this? Justin P. Mattock -- This SF.net email is sponsored by Sprint What will you do first with EVO, the first 4G phone? Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-06 Thread Sergey V.
On Tuesday 06 of July 2010 21:15:44 Justin P. Mattock wrote: This is version two of fixing a warning message generated by GCC CC [M] drivers/char/ipmi/ipmi_si_intf.o drivers/char/ipmi/ipmi_si_intf.c: In function 'try_init_spmi': drivers/char/ipmi/ipmi_si_intf.c:2016:8: warning: variable

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-06 Thread Justin P. Mattock
Hello Justin. [...] @@ -2021,10 +2020,6 @@ static __devinit int try_init_spmi(struct SPMITable *spmi) } if (spmi-addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) -addr_space = IPMI_MEM_ADDR_SPACE; -else -addr_space = IPMI_IO_ADDR_SPACE; - info

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-06 Thread Sergey V.
On Tuesday 06 of July 2010 22:30:00 Justin P. Mattock wrote: Hello Justin. [...] @@ -2021,10 +2020,6 @@ static __devinit int try_init_spmi(struct SPMITable *spmi) } if (spmi-addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) - addr_space = IPMI_MEM_ADDR_SPACE; -

Re: [Openipmi-developer] [PATCH v2]ipmi:ipmi_si_intf.c Fix warning: variable 'addr_space' set but not used

2010-07-06 Thread Justin P. Mattock
On 07/06/2010 01:14 PM, Sergey V. wrote: On Tuesday 06 of July 2010 22:30:00 Justin P. Mattock wrote: Hello Justin. [...] @@ -2021,10 +2020,6 @@ static __devinit int try_init_spmi(struct SPMITable *spmi) } if (spmi-addr.space_id == ACPI_ADR_SPACE_SYSTEM_MEMORY) -