Integrated: 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent libjfxmedia_qtkit

2021-07-30 Thread Alexander Matveev
On Fri, 30 Jul 2021 00:42:30 GMT, Alexander Matveev wrote: > Removed code which loads nonexistent libjfxmedia_qtkit. This pull request has now been integrated. Changeset: ba61a173 Author:Alexander Matveev URL:

Re: [jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v6]

2021-07-30 Thread Pankaj Bansal
On Fri, 30 Jul 2021 06:23:59 GMT, Ajit Ghaisas wrote: >> This PR corrects/adds missing documentation for classes in javafx.css >> package. > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > 8250590 - fix review comments

Re: Undecorated-interactive stage style

2021-07-30 Thread Michael Strauß
It is true that a window with the UNDECORATED style will maximize to fill the entire screen. A window with the UNDECORATED_INTERACTIVE style is actually a regular window where the client area has been extended to include the non-client areas as well. As a consequence of this, the window behaves

Re: Undecorated-interactive stage style

2021-07-30 Thread Michael Strauß
2. From an implementation perspective, this doesn't need to be supported explicitly by a platform. For the move and resize behaviors, it uses existing com.sun.glass.ui.Window APIs like setSize and setPosition. I would imagine that these operations are no-ops for platforms that do not support

Re: Undecorated-interactive stage style

2021-07-30 Thread Dean Wookey
We would be very interested in this. We've tried to implement some of these native behaviours ourselves, but there are plenty of holes and we only support Windows. There are also some bugs which could potentially be addressed by this, for example https://bugs.openjdk.java.net/browse/JDK-810.

Re: Undecorated-interactive stage style

2021-07-30 Thread Kevin Rushforth
This looks interesting and useful. I'd like to hear from other developers as well. A few comments: 1. We might want to consider whether there is a better name (nothing comes to mind at the moment) 2. This will almost certainly need to be a ConditionalFeature (since it might not be

Re: RFR: 8242531: [macos] JavaFX OSXPlatform tries to load nonexistent libjfxmedia_qtkit

2021-07-30 Thread Kevin Rushforth
On Fri, 30 Jul 2021 00:42:30 GMT, Alexander Matveev wrote: > Removed code which loads nonexistent libjfxmedia_qtkit. Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx/pull/597

Enhancements for JavaFX 18

2021-07-30 Thread Kevin Rushforth
Now that JavaFX 17 is in RDP2, we can turn more attention to bug fixes and enhancement requests for JavaFX 18. It's the summer, so there may be delays as some people are out at various times (including me), but I would like to get some of the outstanding enhancement requests moving over the

Re: [jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v6]

2021-07-30 Thread Kevin Rushforth
On Fri, 30 Jul 2021 06:23:59 GMT, Ajit Ghaisas wrote: >> This PR corrects/adds missing documentation for classes in javafx.css >> package. > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > 8250590 - fix review comments

Re: [jfx17] RFR: 8271485: Javadoc "Method Summary" table is misaligned if overridden JDK method has {@inheritDoc} tag

2021-07-30 Thread Ajit Ghaisas
On Thu, 29 Jul 2021 16:18:24 GMT, Kevin Rushforth wrote: > As noted in the JBS bug report, the javadoc-generated HTML table for a class > is messed up if any method is overridden from a core JDK class and has the > `{@inheritDoc}` tag. For example, the following taken from the >

Re: [jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v6]

2021-07-30 Thread Ajit Ghaisas
> This PR corrects/adds missing documentation for classes in javafx.css package. Ajit Ghaisas has updated the pull request incrementally with one additional commit since the last revision: 8250590 - fix review comments - Changes: - all:

Re: [jfx17] RFR: 8250590: Classes and methods in the javafx.css package are missing documentation [v5]

2021-07-30 Thread Ajit Ghaisas
On Thu, 29 Jul 2021 17:41:50 GMT, Kevin Rushforth wrote: >> Ajit Ghaisas has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8250590 - fix review comments > > modules/javafx.graphics/src/main/java/javafx/css/Selector.java line 102: > >>