Re: RFR: 8289605: Robot capture tests fail intermittently on Mac M1 [v2]

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 21:40:40 GMT, Andy Goryachev wrote: >> - moving mouse pointer to stage lower right corner in order to avoid >> interference with the Robot screen capture. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8217853: Cleanup in the D3D native pipeline [v2]

2022-07-29 Thread Ambarish Rapte
On Mon, 2 May 2022 19:55:28 GMT, Nir Lisker wrote: >> Refactoring and renaming changes to some of the D3D pipeline files and a few >> changes on the Java side. These are various "leftovers" from previous issues >> that we didn't want to touch at the time in order to confine the scope of >>

Re: RFR: 8289605: Robot capture tests fail intermittently on Mac M1 [v2]

2022-07-29 Thread Andy Goryachev
> - moving mouse pointer to stage lower right corner in order to avoid > interference with the Robot screen capture. Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision: 8289605: 2022 - Changes: - all:

Re: RFR: 8289605: Robot capture tests fail intermittently on Mac M1 [v2]

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 21:37:24 GMT, Andy Goryachev wrote: >> - moving mouse pointer to stage lower right corner in order to avoid >> interference with the Robot screen capture. > > Andy Goryachev has updated the pull request incrementally with one additional > commit since the last revision: >

Re: RFR: 8289605: Robot capture tests fail intermittently on Mac M1

2022-07-29 Thread Marius Hanl
On Fri, 29 Jul 2022 21:11:53 GMT, Andy Goryachev wrote: > - moving mouse pointer to stage lower right corner in order to avoid > interference with the Robot screen capture. tests/system/src/test/java/test/robot/javafx/scene/RobotTest.java line 148: > 146: double y = stage.getY() +

RFR: 8289605: Robot capture tests fail intermittently on Mac M1

2022-07-29 Thread Andy Goryachev
- moving mouse pointer to stage lower right corner in order to avoid interference with the Robot screen capture. - Commit messages: - 8289605: region tests Changes: https://git.openjdk.org/jfx/pull/854/files Webrev: https://webrevs.openjdk.org/?repo=jfx=854=00 Issue:

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

2022-07-29 Thread Ambarish Rapte
On Thu, 28 Jul 2022 15:01:34 GMT, Kevin Rushforth wrote: > When using the Windows Narrator screen reader on a Hi-DPI screen, the visible > focus is drawn in the wrong location and with the wrong size. This happens > because the the JavaFX Windows accessibility code that returns the screen >

Integrated: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment

2022-07-29 Thread Andy Goryachev
On Tue, 26 Jul 2022 21:14:58 GMT, Andy Goryachev wrote: > - replaced with exact functional equivalent (in the presence of exceptions, > for example) This pull request has now been integrated. Changeset: 4b4deaef Author:Andy Goryachev Committer: Kevin Rushforth URL:

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v3]

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 17:21:07 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request with a new target base due to a > merge or a rebase. The incremental webrev excludes the

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Andy Goryachev
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v3]

2022-07-29 Thread Andy Goryachev
> - replaced with exact functional equivalent (in the presence of exceptions, > for example) Andy Goryachev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Kevin Rushforth
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 07:40:42 GMT, Marius Hanl wrote: >> i think *now* the code is clear without the comment! >> (and the comment does not explain *why* it is intentional or what is the >> intention) > > I would probably leave it as before. I found that code already when working > on the

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Phil Race
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Nir Lisker
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Andy Goryachev
On Tue, 26 Jul 2022 22:54:56 GMT, Andy Goryachev wrote: >> - replaced with exact functional equivalent (in the presence of exceptions, >> for example) > > Andy Goryachev has updated the pull request incrementally with two additional > commits since the last revision: > > - 8289397: review

Re: Why webkit compile fails on linux?

2022-07-29 Thread Thiago Milczarek Sayão
I was able to compile it, thanks for the tip. The problem seems related to number_of_cores X RAM. I think it was running out for memory and being OOM-killed. Just configuring the VM from 8 to 4 cores solved the problem. -- Thiago. Em qui., 28 de jul. de 2022 às 14:10, Kevin Rushforth <

[jfx17u] Integrated: 8291038: Change JavaFX release version to 17.0.5 in jfx17u

2022-07-29 Thread Johan Vos
On Fri, 29 Jul 2022 08:37:47 GMT, Johan Vos wrote: > bump JavaFX release version to 17.0.5 This pull request has now been integrated. Changeset: 0e787635 Author:Johan Vos URL: https://git.openjdk.org/jfx17u/commit/0e787635c2a9a93431734a7fc955a1379305da68 Stats: 2 lines in 2

Re: RFR: 8291087: Wrong position of focus of screen reader on Windows with screen scale > 1

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 05:46:35 GMT, Ajit Ghaisas wrote: >> When using the Windows Narrator screen reader on a Hi-DPI screen, the >> visible focus is drawn in the wrong location and with the wrong size. This >> happens because the the JavaFX Windows accessibility code that returns the >> screen

[jfx11u] Integrated: 8291039: Change JavaFX release version to 11.0.17 in jfx11u

2022-07-29 Thread Johan Vos
On Fri, 29 Jul 2022 08:36:42 GMT, Johan Vos wrote: > Increase JavaFX release version to 11.0.17 This pull request has now been integrated. Changeset: 04637dd3 Author:Johan Vos URL: https://git.openjdk.org/jfx11u/commit/04637dd37af1d6d93d271af10763da11d571485f Stats: 2 lines in

Re: Drag and drop of Outlook attachments

2022-07-29 Thread Dean Wookey
Hi Andrea, You can have a look at this post to see if it helps you. https://stackoverflow.com/a/7316/4489577 Dean On Tue, Jul 12, 2022 at 10:59 AM Andrea Vacondio wrote: > Hello, > can anyone point me or tell me the current support regarding JavaFX drag > and drop of Outlook attachments?

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-29 Thread Kevin Rushforth
On Thu, 7 Jul 2022 22:46:53 GMT, Laurent Bourgès wrote: >> Changelog for this MarlinFX 0.9.4.5 release: >> >> The Marlin-renderer 0.9.4.5 release provides bug fixes on Marlin's path >> clipper: >> - improved Stroker to handle huge coordinates, up to 1E15 >> - improved PathClipFilter (filler)

Re: [jfx11u] RFR: 8291039: Change JavaFX release version to 11.0.17 in jfx11u

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 08:36:42 GMT, Johan Vos wrote: > Increase JavaFX release version to 11.0.17 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.org/jfx11u/pull/103

Re: [jfx17u] RFR: 8291038: Change JavaFX release version to 17.0.5 in jfx17u

2022-07-29 Thread Kevin Rushforth
On Fri, 29 Jul 2022 08:37:47 GMT, Johan Vos wrote: > bump JavaFX release version to 17.0.5 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.org/jfx17u/pull/71

Re: RFR: 8287604: Update MarlinFX to 0.9.4.5 [v3]

2022-07-29 Thread Laurent Bourgès
On Tue, 12 Jul 2022 23:05:06 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed pixel color tests on hi-dpi > > At this point, due to time constraints, we will need to do this early in

[jfx11u] RFR: 8291039: Change JavaFX release version to 11.0.17 in jfx11u

2022-07-29 Thread Johan Vos
Increase JavaFX release version to 11.0.17 - Commit messages: - Increase JavaFX release version to 11.0.17 Changes: https://git.openjdk.org/jfx11u/pull/103/files Webrev: https://webrevs.openjdk.org/?repo=jfx11u=103=00 Issue: https://bugs.openjdk.org/browse/JDK-8291039 Stats: 2

[jfx17u] RFR: 8291038: Change JavaFX release version to 17.0.5 in jfx17u

2022-07-29 Thread Johan Vos
bump JavaFX release version to 17.0.5 - Commit messages: - bump JavaFX release version to 17.0.5 Changes: https://git.openjdk.org/jfx17u/pull/71/files Webrev: https://webrevs.openjdk.org/?repo=jfx17u=71=00 Issue: https://bugs.openjdk.org/browse/JDK-8291038 Stats: 2 lines in 2

Re: RFR: 8289397: Fix warnings: Possible accidental assignment in place of a comparison. A condition expression should not be reduced to an assignment [v2]

2022-07-29 Thread Marius Hanl
On Tue, 26 Jul 2022 22:59:26 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line >> 875: >> >>> 873: public static boolean assertionEnabled() { >>> 874: boolean assertsEnabled = false; >>> 875: assert (assertsEnabled =