On Sat, 10 Dec 2022 08:23:07 GMT, John Hendrikx wrote:
>> - Added generics (to package private or internal classes only)
>> - Minor clean-ups of code I touched (naming)
>> - Fixed incorrect use of generics
>> - Fixed raw type warnings
>>
>> Note: some raw types have leaked into public API.
On Thu, 1 Sep 2022 11:23:44 GMT, Nir Lisker wrote:
>> Refactoring and renaming changes to some of the D3D pipeline files and a few
>> changes on the Java side. These are various "leftovers" from previous issues
>> that we didn't want to touch at the time in order to confine the scope of
>>
On Mon, 28 Nov 2022 12:42:15 GMT, Karthik P K wrote:
> Cause: On hiding the DatePicker dropdown, value selected was not getting
> updated to the text editor. Hence old value from the text editor was getting
> committed to DatePicker on focus loss. This issue was seen only when
> DatePicker is
On Fri, 2 Dec 2022 09:56:42 GMT, John Hendrikx wrote:
>> This PR adds a new (lazy*) property on `Node` which provides a boolean which
>> indicates whether or not the `Node` is currently part of a `Scene`, which in
>> turn is part of a currently showing `Window`.
>>
>> It also adds a new
On Sat, 10 Dec 2022 13:39:42 GMT, Nir Lisker wrote:
> On another note, I'm looking at ListExpression's add and other modifying
> methods. It's calling EMPTY_LIST.add(element) where ObservableList EMPTY_LIST
> = FXCollections.emptyObservableList();. Wouldn't that throw an exception
> since
On Fri, 9 Dec 2022 14:14:18 GMT, Kevin Rushforth wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments
>
> Marked as reviewed by kcr (Lead).
@kevinrushforth / @andy-goryachev-oracle please
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote:
>> Cause: When slider is dragged for first time after tooltip appears,
>> setOnMousePressed event was not invoked, hence dragStart was null in the
>> subsequently invoked event handler (setOnMouseDragged).
>>
>> Fix: Initialized dragStart in
On Thu, 8 Dec 2022 10:34:34 GMT, Karthik P K wrote:
>> Cause: When slider is dragged for first time after tooltip appears,
>> setOnMousePressed event was not invoked, hence dragStart was null in the
>> subsequently invoked event handler (setOnMouseDragged).
>>
>> Fix: Initialized dragStart in
On Fri, 9 Dec 2022 16:31:57 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Add check whether consumeAutoHidingEventsProperty is bound
>
>
On Fri, 9 Dec 2022 21:42:36 GMT, Andy Goryachev wrote:
>> It should at least be consistent with the rest of them.
>>
>> The formatting (with or without the ``) is something we could ask others
>> to weigh in on, too. I don't care too much, one way or the other.
>
> consistent - the other
On Sat, 10 Dec 2022 00:47:36 GMT, Thiago Milczarek Sayao
wrote:
> It does make sense to start a window minimized, but does it make sense to
> call show() and still be minimized (I think to myself)?
Yes. Stage.show() means to make the Stage visible, honoring all of its
attributes (iconified,
On Sat, 10 Dec 2022 08:18:34 GMT, John Hendrikx wrote:
>>> So... it's also a list.
>>
>> I think it's a big mess, you can already see that in the hierarchy,
>> extending both `ObservableObjectValue>` (which is
>> `ObservableValue`) but also being a `ObservableList`. One or the
>> other is
> When menu buttons are added and removed from the scene, an accelerator change
> listener is added to each menu item in the menu. There is nothing stopping
> the same change listener being added multiple times.
>
> MenuButtonSkinBase calls the
>
On Mon, 7 Nov 2022 12:03:38 GMT, Dean Wookey wrote:
>> When menu buttons are added and removed from the scene, an accelerator
>> change listener is added to each menu item in the menu. There is nothing
>> stopping the same change listener being added multiple times.
>>
>> MenuButtonSkinBase
> - Added generics (to package private or internal classes only)
> - Minor clean-ups of code I touched (naming)
> - Fixed incorrect use of generics
> - Fixed raw type warnings
>
> Note: some raw types have leaked into public API. These could be fixed
> without incompatibilities. For specifics
On Thu, 8 Dec 2022 19:38:02 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert renames in Disposer
>
> modules/javafx.base/src/main/java/com/sun/javafx/property/adapter/PropertyDescriptor.java
On Sat, 10 Dec 2022 08:03:27 GMT, John Hendrikx wrote:
>> I was just going to write that now that I look at it, this is a list
>> comparison according to `List::equals`. No need to redo the whole logic..
>>
>> About the validity of the comparison, `ReadOnlyListProperty` also implements
>>
On Fri, 9 Dec 2022 20:19:57 GMT, Nir Lisker wrote:
> So... it's also a list.
I think it's a big mess, you can already see that in the hierarchy, extending
both `ObservableObjectValue>` (which is `ObservableValue`)
but also being a `ObservableList`. One or the other is going to break;
either
18 matches
Mail list logo
