Re: Allow OpenJFX to be built on unknown architectures

I opened the following bug report for this issue: JDK-8307316 : Let JavaFX be built on unknown architectures John On 3/30/23 10:34 AM, Glavo wrote: Did I successfully send this email to the mailing list? On Wed, Mar 29, 2023 at 10:18 PM Glavo

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

On Tue, 2 May 2023 08:57:13 GMT, Ambarish Rapte wrote: > As you pointed out, it failed because `webArchiveJar` task was getting > disabled. Changing the task name to `testWebArchiveJar` solves the problem. That seems like a good solution, and makes it clear that this is a test task.

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v4]

On Tue, 2 May 2023 08:57:30 GMT, Ambarish Rapte wrote: >> Add `TEST_ONLY` flag to gradle with default value as false. >> Add new task named `shims`, This task depends on all shim tasks from all >> projects. Hence it will build all shim classes. >> >> If TEST_ONLY is set to true, the all non

Re: Bug using binary stylesheets: Loading relative @font-face paths are converted to absolute ones

On 3/30/23 2:01 AM, Armin Schrenk wrote: binary stylesheets is a more hidden feature of javafx, so before filing a bug ticket i'm writing to this mailing list. Just a note that I've opened the following bug report for the problem: JDK-8307082 Build path is recorded in JavaFX Controls module

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v4]

> Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing the rounding, this only works for small numbers (in the

Supporting "+" and "-" accelerators on the numeric keypad

One of the most common keyboard accelerators involving a symbol is Shortcut+'+' (plus sign). It’s often assigned to a menu item like Zoom In or Bigger. To target + in a way that works regardless of keyboard layout this has to be specified using a KeyCharacterCombination. Using a KeyCharacter

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v3]

> Region has floor and ceiling functions that ensure that calling them twice in > a row will yield the same result: > > ceil(x) = ceil(ceil(x)) > > However, due to use of a constant `EPSILON` which is added/subtracted before > doing the rounding, this only works for small numbers (in the

Re: RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v2]

On Tue, 2 May 2023 11:08:18 GMT, Lukasz Kostyra wrote: >> Verified these changes on all platforms and saw no abnormalities in test >> execution. >> >> This change is based on a preliminary patch done by @aghaisas , with some >> minor changes and the addition of one Leak-related web test. >>

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

On Thu, 27 Apr 2023 19:15:56 GMT, John Hendrikx wrote: >> Region has floor and ceiling functions that ensure that calling them twice >> in a row will yield the same result: >> >> ceil(x) = ceil(ceil(x)) >> >> However, due to use of a constant `EPSILON` which is added/subtracted before

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

On Tue, 2 May 2023 15:38:06 GMT, Andy Goryachev wrote: > > Okay, I will investigate, I have an idea what this can be, just very > > surprised that the rounding fixes would cause any issues in this code. > > Thank you. I wonder if other places might also exhibit a similar failure > mode.

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

On Tue, 2 May 2023 15:18:02 GMT, John Hendrikx wrote: > Okay, I will investigate, I have an idea what this can be, just very > surprised that the rounding fixes would cause any issues in this code. Thank you. I wonder if other places might also exhibit a similar failure mode. `scaledCeil`

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

On Tue, 2 May 2023 15:15:00 GMT, Andy Goryachev wrote: > > I'm not able to reproduce it. > > I am trying to run the code after a clean build, and can't - the MonkeyTester > freezes going in an infinite loop in HBox.growOrShrinkAreaWidths() on line > 517 when launching to an HBox page. > >

Re: RFR: JDK-8306990: The guarantees given by Region's floor and ceiling functions should work for larger values [v2]

On Thu, 27 Apr 2023 19:15:56 GMT, John Hendrikx wrote: >> Region has floor and ceiling functions that ensure that calling them twice >> in a row will yield the same result: >> >> ceil(x) = ceil(ceil(x)) >> >> However, due to use of a constant `EPSILON` which is added/subtracted before

Integrated: 8302816: Refactor sorting-related classes

On Sat, 18 Feb 2023 17:59:12 GMT, Nir Lisker wrote: > Most of the changes revolve around unifying the sorting methods for a > collection with `Comparable` elements with sorting methods that take an > external `Comparator` by passing `Comparator.naturalOrder()` from the former > to the latter.

Re: RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility [v2]

> Verified these changes on all platforms and saw no abnormalities in test > execution. > > This change is based on a preliminary patch done by @aghaisas , with some > minor changes and the addition of one Leak-related web test. > EventListenerLeak test was not touched, as it is a separate

Re: RFR: 8283551: ControlAcceleratorSupport menu items listener causes memory leak [v2]

On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote: >> Each time a menu would change scenes, a new set of ListChangeListeners would >> be added to the items in the menu. The bigger problem however is that these >> list change listeners have a strong reference to the scene which is >>

Re: RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility

On Mon, 1 May 2023 15:34:35 GMT, Kevin Rushforth wrote: > > EventListenerLeak test was not touched, as it is a separate manual test app > > instead of a JUnit test. > > In addition to the manual test, the `javafx.web` module also has an automated >

Re: RFR: 8302816: Refactor sorting-related classes [v3]

On Fri, 28 Apr 2023 11:41:53 GMT, Nir Lisker wrote: >> Most of the changes revolve around unifying the sorting methods for a >> collection with `Comparable` elements with sorting methods that take an >> external `Comparator` by passing `Comparator.naturalOrder()` from the former >> to the

Re: RFR: 8296919: Make system tests that detect memory leaks more robust by using JMemoryBuddy utility

On Mon, 1 May 2023 16:05:01 GMT, Andy Goryachev wrote: >> Verified these changes on all platforms and saw no abnormalities in test >> execution. >> >> This change is based on a preliminary patch done by @aghaisas , with some >> minor changes and the addition of one Leak-related web test. >>

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

On Fri, 28 Apr 2023 18:13:57 GMT, Kevin Rushforth wrote: > I get one failure when running the tests after first building the shims: As you pointed out, it failed because `webArchiveJar` task was getting disabled. Changing the task name to `testWebArchiveJar` solves the problem. That task is

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v3]

On Fri, 28 Apr 2023 11:44:37 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> update submit.yml > > build.gradle line 55: > >> 53: * >> 54: * Adding a new project or task: >> 55: * - Fix

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v4]

On Thu, 27 Apr 2023 11:58:02 GMT, Kevin Rushforth wrote: >> Ambarish Rapte has updated the pull request incrementally with one >> additional commit since the last revision: >> >> address review comments > > gradle.properties.template line 82: > >> 80: # Recommended to use TEST_ONLY instead

Re: RFR: 8297071: Provide gradle "TEST_ONLY" flag to completely suppress building the sdk and shims [v4]

> Add `TEST_ONLY` flag to gradle with default value as false. > Add new task named `shims`, This task depends on all shim tasks from all > projects. Hence it will build all shim classes. > > If TEST_ONLY is set to true, the all non test tasks get disabled. When > running a test task, this flag