On Thu, 25 Jan 2024 13:32:21 GMT, Hima Bindu Meda wrote:
> Cherry-picked changes related to webkit-2.42.4.Verified build on all
> platforms. Sanity testing looks fine.
This pull request has now been integrated.
Changeset: 52840a17
Author:Hima Bindu Meda
URL:
On Mon, 29 Jan 2024 04:24:54 GMT, Hima Bindu Meda wrote:
>> Cherry-picked changes related to webkit-2.42.4.Verified build on all
>> platforms. Sanity testing looks fine.
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Fri, 12 Jan 2024 14:11:14 GMT, Lukasz Kostyra wrote:
> Originally this issue showed the problem of Node being incorrectly rendered
> (clipped) when snapshotting, compared to a snapshot of the whole Scene. Later
> on there was another problem added - lights not being taken into account if
>
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed copyright years of modified files +
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote:
>> As noted in the JBS bug, this is a follow-on to
>> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered
>> while testing the fix for
>> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in
On Mon, 29 Jan 2024 09:32:06 GMT, Lukasz Kostyra wrote:
>> Originally this issue showed the problem of Node being incorrectly rendered
>> (clipped) when snapshotting, compared to a snapshot of the whole Scene.
>> Later on there was another problem added - lights not being taken into
>>
On Fri, 19 Jan 2024 16:07:31 GMT, Michael Strauß wrote:
> The `Animation` class states in the documentation of various methods that the
> method call would be asynchronous, using language similar to:
>
>
> {@code stop()} is an asynchronous call, the {@code Animation} may not stop
>
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install
On Tue, 30 Jan 2024 01:24:52 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote:
> `WinApplication` contains mappings of platform-specific preference keys to
> platform-independent keys.
> These keys are incorrect (for example, `Windows.UIColor.ForegroundColor`
> instead of `Windows.UIColor.Foreground`).
>
> This was
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update tests
-
Changes:
- all:
On Tue, 30 Jan 2024 00:57:53 GMT, Martin Fox wrote:
> Currently it commits a zero-length string (which appears to be a no-op) and
> leaves the composition buffer untouched.
Correcting myself: it does clear the composition buffer. But the zero-length
commit doesn't seem to be doing what it
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote:
> `WinApplication` contains mappings of platform-specific preference keys to
> platform-independent keys.
> These keys are incorrect (for example, `Windows.UIColor.ForegroundColor`
> instead of `Windows.UIColor.Foreground`).
>
> This was
On Mon, 29 Jan 2024 19:04:10 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> When IM enabled state changes we dismiss the IM window.
>
> ... and scenarios described in JDK-8088172 and JDK-8089803
`WinApplication` contains mappings of platform-specific preference keys to
platform-independent keys.
These keys are incorrect (for example, `Windows.UIColor.ForegroundColor`
instead of `Windows.UIColor.Foreground`).
This was not discovered during testing because the manual test application
On Mon, 29 Jan 2024 21:11:45 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java
>> line 80:
>>
>>> 78:
>>> 79: private Thread thread;
>>> 80: private Throwable throwable;
>>
>> Since these can be set from any thread, maybe use
On Mon, 29 Jan 2024 16:35:05 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move test that needs QuantumToolkit to system tests
>
>
On Tue, 30 Jan 2024 00:12:52 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Mon, 29 Jan 2024 22:13:25 GMT, Kevin Rushforth wrote:
>> I don't think the executor service catches the exception because if it did
>> then the `AnimationTimer` test would also always pass. I do get the AIOOB
>> exceptions from the background thread caught in the handler (which fails the
On Mon, 29 Jan 2024 09:32:06 GMT, Lukasz Kostyra wrote:
>> Originally this issue showed the problem of Node being incorrectly rendered
>> (clipped) when snapshotting, compared to a snapshot of the whole Scene.
>> Later on there was another problem added - lights not being taken into
>>
On Mon, 29 Jan 2024 21:35:24 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java
>> line 87:
>>
>>> 85: for (int i = 0; i < 10; i++) {
>>> 86: executor.submit(runnable);
>>> 87: }
>>
>> I did a quick prototype
On Mon, 29 Jan 2024 20:49:48 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTest.java
>> line 2:
>>
>>> 1: /*
>>> 2: * Copyright (c) 2024, Oracle and/or its affiliates. All rights reserved.
>>
>> Copyright header should keep 2023, even if it is
Are you sure it wasn’t change in some version of Windows 10 or between 10 and
11? I vaguely recall testing light/dark mode switch on Windows 11.
-andy
From: openjfx-dev on behalf of Michael Strauß
Date: Monday, January 29, 2024 at 14:09
To:
Cc: openjfx-dev@openjdk.org
Subject: Re:
I see that the names of the platform mappings defined in
WinApplication::getPlatformKeyMappings() are simply wrong
("Windows.UIColor.ForegroundColor" instead of
"Windows.UIColor.Foreground"), so the platform mappings are not applied to
the properties.
That's quite surprising, and it's a change
Hello Michael,
I took a look at the implementation and tried to find the issue. From
what I can see, the mappings returned are correct:
but it seems like they are somehow not applied the PreferencesProperties:
Let me know whether I can help with anything to debug this issue.
On 1/29/2024
On Mon, 29 Jan 2024 19:00:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java
> line 87:
>
>>
Hi Christopher!
> - Should this feature work in that ea version?
Yes.
> - Is Windows 10 supported by the color scheme detection?
Color scheme detection should be supported on Windows 10 beginning
with build 10240.
> - The documentation says that LIGHT is returned in case theme the
>
> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
Laurent Bourgès has updated the pull request incrementally with one additional
commit since the last revision:
fixed copyright years of modified files + fixed comments in DMarlinPrismUtils
-
Changes:
- all:
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Use AtomicReferences
-
Changes:
- all:
On Mon, 29 Jan 2024 19:05:46 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronizationTest.java
> line 80:
>
>>
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with two additional
commits since the last revision:
- Fix removed methods
- Correct methods in docs
-
On Mon, 29 Jan 2024 19:22:17 GMT, Jose Pereda wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
> 989:
>
>> 987: *
Hello,
I just tried out the new 22-ea+27 build to see whether we can utilize
some of the new features, particularly the platform preferences API, to
replace the library https://github.com/Dansoftowner/jSystemThemeDetector
that we are currently using for theme detection.
I'm running this on
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote:
> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
> have enough context to know whether it should return a result from the main
>
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Sat, 27 Jan 2024 19:15:01 GMT, Martin Fox wrote:
>> In the Mac glass code the presence of "marked" text (which is tracked in the
>> nsAttrBuffer) signals that an IME is active. In this state the current code
>> assumes that when NSTextInputContext handles a `keyDown:` it will either
>>
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed test package
Our headful CI test run
On Mon, 29 Jan 2024 16:22:56 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move test that needs QuantumToolkit to system tests
>
> MonkeyTester won't start:
>
>
> Exception in thread
On Mon, 29 Jan 2024 07:29:06 GMT, Karthik P K wrote:
>>> Noticed a problem - on Windows 11 and on macOS 14.2.1 hit into shows
>>> different values for Text and TextFlow. This issue can be seen with pretty
>>> much every text, even "aaa\nbbb\n". In this screenshot, the line
>>> corresponds
On Mon, 29 Jan 2024 16:42:15 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update tests
-
Changes:
- all:
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 29 Jan 2024 16:10:01 GMT, Andy Goryachev wrote:
> > ancient test case that was disabled (see
> > https://bugs.openjdk.org/browse/JDK-8087615).
>
> should the old ticket be added to this PR?
If this fixes all tests that are `@Ignore`d with this old bug ID, then yes. I
still see a
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Rename more Animation methods
-
Changes:
- all:
On Sun, 28 Jan 2024 23:30:56 GMT, John Hendrikx wrote:
> ancient test case that was disabled (see
> https://bugs.openjdk.org/browse/JDK-8087615).
should the old ticket be added to this PR?
-
PR Comment: https://git.openjdk.org/jfx/pull/1236#issuecomment-1915034433
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update Timeline method
-
Changes:
- all:
On Mon, 29 Jan 2024 14:26:01 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 29 Jan 2024 15:39:32 GMT, Nir Lisker wrote:
>> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java
>> line 65:
>>
>>> 63: }
>>> 64:
>>> 65: waiter.await(GRACE_PERIOD, TimeUnit.SECONDS);
>>
>> I don't think this will do what you want. This
On Mon, 29 Jan 2024 14:38:20 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Mon, 29 Jan 2024 14:16:00 GMT, Nir Lisker wrote:
>> I was also going to suggest `xxImpl` with a short javadoc comment. That is a
>> pattern we use elsewhere. I don't dislike the current name, but I can see
>> Jose's point.
>
> Changed to `xxImpl` with a doc comment.
Thanks. You missed the
On Mon, 29 Jan 2024 15:40:28 GMT, Andy Goryachev wrote:
> > The justify calculation only looks at regular white spaces (0x20), but I
> > think it should really be looking at all types...
>
> maybe extract that into a separate issue (and link this one?)
>
> Are there any other places where we
On Sat, 27 Jan 2024 08:33:47 GMT, John Hendrikx wrote:
> The justify calculation only looks at regular white spaces (0x20), but I
> think it should really be looking at all types...
maybe extract that into a separate issue (and link this one?)
Are there any other places where we should be
On Mon, 29 Jan 2024 13:07:21 GMT, Kevin Rushforth wrote:
> I don't think this will do what you want. This will return almost
> immediately, before any of the animation has run (as soon as the runnable
> that sets the uncaught exception handler finished).
I observed that this setup works
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Add null parent checks
-
Changes:
- all:
On Mon, 29 Jan 2024 12:44:07 GMT, Kevin Rushforth wrote:
>> Probably you won't like `xxImpl` either?
>> I'm not sure we should start adding `runMustBeOnFxThread` to every method
>> name out there that should run on the FX thread. In this case, maybe we
>> could simply add a small javadoc with
> Added a utility method to run code on the FX thread if it's not already, and
> changed the animation methods to use it.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Change method names
-
Changes:
- all:
On Fri, 26 Jan 2024 06:49:42 GMT, Laurent Bourgès wrote:
> I fixed new test so system test run properly. How do you compare test runs in
> CI ?
GHA jobs only run headless tests. In order to do run system test we need
physical test systems. We have the ability to run them internally (in our
On Mon, 29 Jan 2024 04:24:54 GMT, Hima Bindu Meda wrote:
>> Cherry-picked changes related to webkit-2.42.4.Verified build on all
>> platforms. Sanity testing looks fine.
>
> Hima Bindu Meda has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Fri, 26 Jan 2024 19:36:23 GMT, Joeri Sykora wrote:
>> Hima Bindu Meda has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor corrections as per review comments
>
> Everything built fine.
@tiainen Can you rereview? (only whitespace
Tests in the javafx.graphics module always use StubToolkit. If you want
to use the real toolkit (QuantumToolkit), you need to put the tests in
the systemTests project, under "tests/system".
-- Kevin
On 1/28/2024 3:47 PM, John Hendrikx wrote:
I found an old disabled test that is testing
On Mon, 29 Jan 2024 09:33:35 GMT, Jose Pereda wrote:
>> Nir Lisker has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update tests
>
> tests/system/src/test/java/test/com/sun/javafx/animation/SynchronisityTest.java
> line 20:
>
>> 18:
On Mon, 29 Jan 2024 09:20:27 GMT, Jose Pereda wrote:
>>> However, I'm not sure about the method naming `OnFxThread`, as it might
>>> imply that what it does is already done on the FX thread, therefore not
>>> needing to be wrapped up by `runOnFxThread`.
>>
>> I understand what you mean, but
On Sat, 27 Jan 2024 21:31:32 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line
>> 1008:
>>
>>> 1006: * @param runnable a {@code Runnable} encapsulating the code
>>> 1007: */
>>> 1008: public static void runOnFxThread(Runnable
On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 25 Jan 2024 17:16:51 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed test package
Tested the changes and
On Mon, 29 Jan 2024 03:28:51 GMT, Nir Lisker wrote:
>> Added a utility method to run code on the FX thread if it's not already, and
>> changed the animation methods to use it.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Sat, 27 Jan 2024 21:56:59 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/animation/Animation.java line
>> 903:
>>
>>> 901: }
>>> 902:
>>> 903: private void playFromOnFxThread(String cuePoint) {
>>
>> I take that adding these private `xxOnFxThread` methods
On Fri, 26 Jan 2024 13:55:59 GMT, Lukasz Kostyra wrote:
>> Originally this issue showed the problem of Node being incorrectly rendered
>> (clipped) when snapshotting, compared to a snapshot of the whole Scene.
>> Later on there was another problem added - lights not being taken into
>>
> Originally this issue showed the problem of Node being incorrectly rendered
> (clipped) when snapshotting, compared to a snapshot of the whole Scene. Later
> on there was another problem added - lights not being taken into account if
> they are added to a SubScene.
>
> As it later turned
77 matches
Mail list logo
