Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v10]

2024-01-30 Thread John Hendrikx
> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each >

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v9]

2024-01-30 Thread John Hendrikx
> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each >

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v8]

2024-01-30 Thread John Hendrikx
> There are a number of tickets open related to text rendering: > > https://bugs.openjdk.org/browse/JDK-8314215 > > https://bugs.openjdk.org/browse/JDK-8145496 > > https://bugs.openjdk.org/browse/JDK-8129014 > > They have in common that wrapped text is taking the trailing spaces on each >

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:43:33 GMT, Martin Fox wrote: > I submitted PR thank you! - PR Comment: https://git.openjdk.org/jfx/pull/1351#issuecomment-1917861792

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Martin Fox
On Tue, 30 Jan 2024 17:33:06 GMT, Andy Goryachev wrote: >>> > [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912). I put >>> > together a fix for that bug but decided not to roll it into this PR. >>> >>> Are these two bugs independent? Should JDK-8320912 be resolved first? >> >> They

RFR: 8320912: IME should commit on focus change

2024-01-30 Thread Martin Fox
This is a Mac only bug. If the user was in the middle of IM text composition and clicked on a different node the partially composed text was left in the old node and the IM window wasn't dismissed. This PR implements the existing finishInputMethodComposition call so it can commit the text and

[jfx22] Integrated: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Michael Strauß
On Tue, 30 Jan 2024 19:21:50 GMT, Michael Strauß wrote: > This pull request contains a backport of commit > [af7e0571](https://github.com/openjdk/jfx/commit/af7e05716711d942df20eb1f807b384810a4a839) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being

Re: [jfx22] RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 19:21:50 GMT, Michael Strauß wrote: > This pull request contains a backport of commit > [af7e0571](https://github.com/openjdk/jfx/commit/af7e05716711d942df20eb1f807b384810a4a839) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit being

[jfx22] RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Michael Strauß
This pull request contains a backport of commit [af7e0571](https://github.com/openjdk/jfx/commit/af7e05716711d942df20eb1f807b384810a4a839) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Michael Strauß on 30 Jan 2024 and was reviewed

Integrated: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Michael Strauß
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: Binding properties to constant values

2024-01-30 Thread Michael Strauß
Hi John, the rule that values set from code are less specific than values set in author and inline styles is probably lifted from the CSS specification, which says [0]: "The UA may choose to honor presentational attributes in an HTML source document. If so, these attributes are translated to the

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 00:53:51 GMT, Michael Strauß wrote: > `WinApplication` contains mappings of platform-specific preference keys to > platform-independent keys. > These keys are incorrect (for example, `Windows.UIColor.ForegroundColor` > instead of `Windows.UIColor.Foreground`). > > This was

Re: [jfx22u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 16:57:37 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u (for 22.0.1). @johanvos This clean backport needs Maintainer approval in JBS (but not a Review in the PR). You can either use the "/approve" command or do it directly in JBS. - PR Comment:

Re: Build artifacts for Linux aarch64

2024-01-30 Thread Nir Lisker
Hi Armin, If I go to https://gluonhq.com/products/javafx/ and filter to linux aarch64, I see both SDK and JMODS for JavaFX 22-ea+16 (latest version, which is early access). If you're talking about commercial support, I don't know. Different companies choose what they support. - Nir On Tue, Jan

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 17:21:37 GMT, Martin Fox wrote: > The order in which they get resolved doesn't matter. would it be possible to get [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912) integrated first then? It seems the scenario it addresses is narrower, and it will be easier to

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Martin Fox
On Tue, 30 Jan 2024 15:56:04 GMT, Andy Goryachev wrote: > > [JDK-8320912](https://bugs.openjdk.org/browse/JDK-8320912). I put together > > a fix for that bug but decided not to roll it into this PR. > > Are these two bugs independent? Should JDK-8320912 be resolved first? They are

Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-01-30 Thread Kevin Rushforth
On Fri, 5 Jan 2024 23:59:31 GMT, Kevin Rushforth wrote: > As noted in the JBS bug, this is a follow-on to > [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered > while testing the fix for > [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in the

[jfx22u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-01-30 Thread Kevin Rushforth
Clean backport to jfx22u (for 22.0.1). - Commit messages: - Backport 40809a3f84d5f9f91b265f455a95d045e5b4f692 Changes: https://git.openjdk.org/jfx22u/pull/8/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u=8=00 Issue: https://bugs.openjdk.org/browse/JDK-8322703 Stats: 62

Re: Binding properties to constant values

2024-01-30 Thread Scott Palmer
IMO the current CSS priorities are wrong. A value set from code should be adjacent to an in-line style in terms of precedence. They are both ways of saying saying “this particular instance should have this value” Scott > On Jan 30, 2024, at 8:31 AM, John Hendrikx wrote: > > Hi Michael, >

Re: Headless glass platform

2024-01-30 Thread Kevin Rushforth
Yeah, this is a better place for discussion than JBS. JavaFX has long lacked a real headless test platform, so it will be cool to see where this goes.  - Is there a JEP/tutorial for the new mode? It's probably premature, given the early prototype nature... -- Kevin On 1/30/2024 8:14 AM,

Re: RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS [v3]

2024-01-30 Thread Ambarish Rapte
On Wed, 17 Jan 2024 12:57:22 GMT, Kevin Rushforth wrote: >> As noted in the JBS bug, this is a follow-on to >> [JDK-8196011](https://bugs.openjdk.org/browse/JDK-8196011) that I discovered >> while testing the fix for >> [JDK-8221261](https://bugs.openjdk.org/browse/JDK-8221261) (a deadlock in

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Andy Goryachev
On Sat, 27 Jan 2024 19:19:48 GMT, Martin Fox wrote: >> In the Mac glass code the presence of "marked" text (which is tracked in the >> nsAttrBuffer) signals that an IME is active. In this state the current code >> assumes that when NSTextInputContext handles a `keyDown:` it will either >>

Re: RFR: 8301900: TextArea: Committing text with ENTER in an IME window inserts newline [v2]

2024-01-30 Thread Martin Fox
On Mon, 29 Jan 2024 19:04:10 GMT, Andy Goryachev wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> When IM enabled state changes we dismiss the IM window. > > ... and scenarios described in JDK-8088172 and JDK-8089803

Re: RFR: 8324879: Platform-specific preferences keys are incorrect for Windows toolkit

2024-01-30 Thread Andy Goryachev
On Tue, 30 Jan 2024 01:10:56 GMT, Kevin Rushforth wrote: > do you want to be the second reviewer? will do - PR Comment: https://git.openjdk.org/jfx/pull/1353#issuecomment-1917335686

Re: Headless glass platform

2024-01-30 Thread Andy Goryachev
Excellent development, Johan, thank you! I’ve asked a few questions in the ticket https://bugs.openjdk.org/browse/JDK-8324941 I suppose I should also do it here: - How do you get information on a (virtual) screen? - How would one control how many virtual screens are there? - Would there be any

Re: Headless glass platform

2024-01-30 Thread Sean M Phillips
This is very cool Johan. I have some questions if you have time to answer: Do you believe your headless platform POC would allow the use of the snapshot method for exporting visuals of a scene to a png? If so do you have any early indications of performance therein? (number of snapshots per

Build artifacts for Linux aarch64

2024-01-30 Thread Armin Schrenk
Hey, in the past there were releases for the platform linux aarch64. But I can't find those anymore, neither in maven central, nor on the Gluon javafx page, which provides prebuild jmods/SDKs. Is this platform not supported anymore? Best regards, Armin Schrenk -- Armin Schrenk Skymatic

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Tue, 30 Jan 2024 09:27:32 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > Tests in

Re: Binding properties to constant values

2024-01-30 Thread John Hendrikx
Hi Michael, I think we first need to decide what the correct behavior is for CSS properties, as the "bind" solution IMHO is a bug. The StyleOrigin enum encodes the relative priorities of styles and user set values, but it is incomplete and not fully enforced.  There is (currently) actually

Re: Platform preferences theme detection

2024-01-30 Thread Nir Lisker
> > I'm under the impression that the last available 22+ea maven release, > which is now almost 3 months old, does not contain the platform preferences > API > You are correct, the new API was added a month after the latest ea build. Versions 11-21 all had at least 1 ea release per month on

[jfx22] Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Tue, 30 Jan 2024 12:08:41 GMT, Nir Lisker wrote: > Hi all, > > This pull request contains a backport of commit > [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 09:27:32 GMT, Karthik P K wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > Tests in

Re: [jfx22] RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Kevin Rushforth
On Tue, 30 Jan 2024 12:08:41 GMT, Nir Lisker wrote: > Hi all, > > This pull request contains a backport of commit > [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f) > from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. > > The commit

Re: Platform preferences theme detection

2024-01-30 Thread Christopher Schnick
Hello Nir, I'm not entirely familiar with every ea build, but I'm under the impression that the last available 22+ea maven release, which is now almost 3 months old, does not contain the platform preferences API and also does not contain the kinda important css performance regression fixes.

Re: Platform preferences theme detection

2024-01-30 Thread Nir Lisker
Hi Christopher, Looking at Maven Central, https://mvnrepository.com/artifact/org.openjfx/javafx, JavaFX releases ea builds there, which I sometimes use myself from Maven/Gradle. Version 21 had 6 ea versions, and 22 has 3. The release cycle is 6 months per final version (aligned with OpenJDK). -

Re: Platform preferences theme detection

2024-01-30 Thread Christopher Schnick
Alright I will try out the new ea release once the fix is integrated. Other than that, everything works fine for me so far with observing colors using the platform-specific strings. As a side note, I think the community would have caught this issue earlier if there were more frequent maven

[jfx22] RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
Hi all, This pull request contains a backport of commit [c5ab220b](https://github.com/openjdk/jfx/commit/c5ab220bbc885f2aa99d8c1d5ed8f1753e39251f) from the [openjdk/jfx](https://git.openjdk.org/jfx) repository. The commit being backported was authored by Nir Lisker on 30 Jan 2024 and was

[jfx22u] Integrated: 8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-30 Thread Hima Bindu Meda
On Tue, 30 Jan 2024 11:56:35 GMT, Hima Bindu Meda wrote: > Clean Backport This pull request has now been integrated. Changeset: a247278f Author:Hima Bindu Meda URL: https://git.openjdk.org/jfx22u/commit/a247278f9818265e1d012981ea7a6fcc2748185a Stats: 1297 lines in 161 files

[jfx22u] RFR: 8324337: Cherry-pick WebKit 617.1 stabilization fixes

2024-01-30 Thread Hima Bindu Meda
Clean Backport - Commit messages: - Backport 52840a17dee6a92fb9b1f3ff1b314b0ae228b95f Changes: https://git.openjdk.org/jfx22u/pull/7/files Webrev: https://webrevs.openjdk.org/?repo=jfx22u=7=00 Issue: https://bugs.openjdk.org/browse/JDK-8324337 Stats: 1297 lines in 161 files

Headless glass platform

2024-01-30 Thread Johan Vos
Hi, I created a branch in the jfx-sandbox repository for experimenting with a headless glass platform: https://github.com/openjdk/jfx-sandbox/tree/johanvos-headless This addresses https://bugs.openjdk.org/browse/JDK-8324941 where I suggest a POC for a Headless platform. There are a number of

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files +

Integrated: 8324658: Allow animation play/start/stop/pause methods to be called on any thread

2024-01-30 Thread Nir Lisker
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker wrote: > Added a utility method to run code on the FX thread if it's not already, and > changed the animation methods to use it. This pull request has now been integrated. Changeset: c5ab220b Author:Nir Lisker URL:

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Laurent Bourgès
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files +

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-30 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files +

Re: RFR: 8324658: Allow animation play/start/stop/pause methods to be called on any thread [v17]

2024-01-30 Thread Jose Pereda
On Tue, 30 Jan 2024 01:24:52 GMT, Nir Lisker wrote: >> Added a utility method to run code on the FX thread if it's not already, and >> changed the animation methods to use it. > > Nir Lisker has updated the pull request incrementally with one additional > commit since the last revision: > >

Binding properties to constant values

2024-01-30 Thread Michael Strauß
Hi everyone, I'm interested in hearing your thoughts on the following proposal, which could increase the expressiveness of the JavaFX Property API: Problem --- The JavaFX CSS system applies the following order of precedence to determine the value of a styleable property (in ascending