RFR: 8325093: Update CONTRIBUTING.md for build jdk version

2024-01-31 Thread Ao Qi
[JDK-8297068](https://bugs.openjdk.org/browse/JDK-8297068) updated boot JDK to 19.0.1 from 18.0.2, and [JDK-8321434](https://bugs.openjdk.org/browse/JDK-8321434) updated boot JDK to 21.0.1. `CONTRIBUTING.md` should be updated correspondingly. - Commit messages: - 8325093: Update

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 21:49:32 GMT, Andy Goryachev wrote: >>>notice how the underline under あ is still there in the first text field. >> >> That behavior surprised me the first time I saw it but I eventually figured >> out that it's a feature, not a bug. If you switch back to the original

Re: Binding properties to constant values

2024-01-31 Thread John Hendrikx
Hi Nir, On 31/01/2024 22:36, Nir Lisker wrote: I would wait with the ramifications of setting competing values from different origins until the question of precedence is answered. Perhaps emitting warnings is better, though I can see some scenarios in which they will be annoying. The way

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Wed, 31 Jan 2024 20:55:16 GMT, Martin Fox wrote: > e.g. the IM window should appear showing the same candidates it was showing > earlier. Thank you for clarification! The behavior is different, let me explain: using the MonkeyTester, open TextField page and the Native-to-ascii tool (Tools

Re: Binding properties to constant values

2024-01-31 Thread Nir Lisker
> > Specialized methods will be added to `BooleanProperty`, > `DoubleProperty`, `FloatProperty`, `IntegerProperty`, and > `LongProperty`, each with one of the preexisting constant wrappers > that are already in the framework. > Some wrappers can be deduplicated (we only ever need two wrapper >

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v7]

2024-01-31 Thread Andy Goryachev
On Wed, 31 Jan 2024 10:24:20 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v7]

2024-01-31 Thread Andy Goryachev
On Wed, 31 Jan 2024 10:24:20 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 20:07:05 GMT, Andy Goryachev wrote: > Another problem I see, and it might be a totally separate issue, is that > sometimes when I launch the Monkey Tester and switch to Japanese input, > TextField is still receives US input, despite the IME window appearing. That behavior

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Martin Fox
On Wed, 31 Jan 2024 18:44:55 GMT, Andy Goryachev wrote: >notice how the underline under あ is still there in the first text field. That behavior surprised me the first time I saw it but I eventually figured out that it's a feature, not a bug. If you switch back to the original window by

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Wed, 31 Jan 2024 18:40:29 GMT, Kevin Rushforth wrote: >> Laurent Bourgès has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fixed copyright years of modified files + fixed comments in >> DMarlinPrismUtils > > I don't have any concerns.

Re: [External] : Re: Headless glass platform

2024-01-31 Thread Andy Goryachev
Thank you for clarifications, Johan! - Would there be any other way of simulating user input apart from Robot? Not sure I understand the question. In theory, input with mouse etc would be possible but then that would be sort of a duplication/rewrite of the Robot. I'm missing the usecase for

Re: RFR: 8320912: IME should commit on focus change

2024-01-31 Thread Andy Goryachev
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote: > This is a Mac only bug. If the user was in the middle of IM text composition > and clicked on a different node the partially composed text was left in the > old node and the IM window wasn't dismissed. This PR implements the existing >

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Kevin Rushforth
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files +

Withdrawn: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close)

2024-01-31 Thread duke
On Thu, 2 Nov 2023 19:13:58 GMT, Thiago Milczarek Sayao wrote: > JavaFX on Linux is allowing disabled windows to be minimized. > > Currently close does nothing as it should, maximize disappears (on MS Windows > it's greyed out - it's a platform behavior difference) and minimize is being >

[jfx22u] Integrated: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-01-31 Thread Kevin Rushforth
On Tue, 30 Jan 2024 16:57:37 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u (for 22.0.1). This pull request has now been integrated. Changeset: 37695a2c Author:Kevin Rushforth URL: https://git.openjdk.org/jfx22u/commit/37695a2ce89d90ca0e1a3bb1d8d7547669b7f2e7 Stats: 62

Re: [jfx22u] RFR: 8322703: Intermittent crash in WebView in a JFXPanel from IME calls on macOS

2024-01-31 Thread Kevin Rushforth
On Tue, 30 Jan 2024 16:57:37 GMT, Kevin Rushforth wrote: > Clean backport to jfx22u (for 22.0.1). @johanvos The `/approve` command had a syntax error. It should be: `/approve yes` (in a new comment, since Skara won't reprocess edited comments). - PR Comment:

Re: Build artifacts for Linux aarch64

2024-01-31 Thread Armin Schrenk
Since those are early access, i would prefer to use JFX 21 releases since they are used for an open-source project. I'm not talking about commercial support (although with JFX 22 Gluon seems to split the releases into supported and unsupported ones). Additionally, as i already said, there are

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Laurent Bourgès
On Tue, 30 Jan 2024 12:52:09 GMT, Kevin Rushforth wrote: >> Tests in BidirectionalBindingTest with following exception. (Note: This was >> during the first JavaFX pre-submit test for this PR) >> >> BidirectionalBindingTest > [0] > testDoubleBrokenBind[0] STANDARD_ERROR >> Exception in

Re: RFR: 8312603: ArrayIndexOutOfBoundsException in Marlin when scaleX is 0 [v3]

2024-01-31 Thread Karthik P K
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote: >> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java > > Laurent Bourgès has updated the pull request incrementally with one > additional commit since the last revision: > > fixed copyright years of modified files +

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v6]

2024-01-31 Thread Karthik P K
On Mon, 29 Jan 2024 07:31:53 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v7]

2024-01-31 Thread Karthik P K
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation > conditions were not considered, hence hit test values such as character index > and insertion index values were incorrect. > > Added checks for RTL orientation of nodes and fixed the issue in > `getHitInfo()` to

Re: Headless glass platform

2024-01-31 Thread Johan Vos
On Tue, Jan 30, 2024 at 5:14 PM Andy Goryachev wrote: > Excellent development, Johan, thank you! > > > > I’ve asked a few questions in the ticket > https://bugs.openjdk.org/browse/JDK-8324941 > > > > I suppose I should also do it here: > > > > - How do you get information on a (virtual) screen?

Re: Headless glass platform

2024-01-31 Thread Johan Vos
Hi Sean, On Tue, Jan 30, 2024 at 5:09 PM Sean M Phillips wrote: > This is very cool Johan. I have some questions if you have time to answer: > > Do you believe your headless platform POC would allow the use of the > snapshot method for exporting visuals of a scene to a png? > Yes, that is one