The PR simply moves column and view-updates outside the loop. Since the column
or view never changes within the for-loop it is not necessary to call these
again and again.
-
Commit messages:
- 8325154: resizeColumnToFitContent is slower than it needs to be
Changes:
Am 01.02.24 um 16:53 schrieb John Hendrikx:
Is it still a CSS performance degradation then? I mean, it's the same
speed, and the number of calls should be irrelevant?
A performance degradation must be present, since after the expected
deterioration of JFX 19 it has become twice as slow
And thank you for raising the issue and answering the questions we had
concerning the use case.
This will be in the next promoted build, JavaFX 22+28 (as well as JavaFX
23+3).
-- Kevin
On 2/1/2024 12:42 AM, Jurgen Doll wrote:
A big THANK YOU to everybody that was part of this process.
On Tue, 30 Jan 2024 20:32:36 GMT, Martin Fox wrote:
> This is a Mac only bug. If the user was in the middle of IM text composition
> and clicked on a different node the partially composed text was left in the
> old node and the IM window wasn't dismissed. This PR implements the existing
>
Hi John,
If the issues with StyleOrigin are not as problematic as I presented, it
comes out to the behavioral flexibility we have. Can we change the
precedence order at this point? Do users rely on it or are surprised by it
(I see the latter, but those who think it works correctly are not going
On Thu, 1 Feb 2024 08:06:18 GMT, Karthik P K wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
>> line 513:
>>
>>> 511: if ((x > run.getWidth() &&
>>> (!isMultiRunText || run.getStart() == curRunStart)) || textWidthPrevLine >
To: JavaFX Developers
As a reminder, JavaFX 22 is now in Rampdown Phase Two (RDP2). [1]
P1-P2 bug fixes, and test or doc fixes of any priority, can be fixed
during RDP2. Explicit approval is needed for all bug fixes and
enhancements (except for doc and test fixes) to go in to the jfx22
On 01/02/2024 13:00, Robert Lichtenberger wrote:
Hi,
We are seeing degraded performance in our production application
concerning the "fit to content" function of TableViews.
I've developed a little benchmark program that can be found at
On Thu, 1 Feb 2024 12:09:36 GMT, Ambarish Rapte wrote:
> @Maran23 This is ready for integration. If you were waiting for me. Thanks,
> It looks good, I don't have any comments.
Thank you for checking as well!
-
PR Comment:
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install
On Thu, 11 Jan 2024 20:13:09 GMT, Marius Hanl wrote:
> For some reason the `skinProperty` did not allow to set a new skin when it is
> the same class as the previous one.
> This leads to multiple issues:
> 1. When creating a new skin (same class as previous), the skin will likely
> install
Hi,
We are seeing degraded performance in our production application
concerning the "fit to content" function of TableViews.
I've developed a little benchmark program that can be found at
https://gist.github.com/effad/9eebee0c1e86a8e605cb55ced9485dd4
Here's the last lines of data from runs
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed copyright years of modified files +
On Mon, 29 Jan 2024 09:44:04 GMT, Karthik P K wrote:
>> Laurent Bourgès has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed test package
>
> modules/javafx.graphics/src/main/java/com/sun/marlin/DPathConsumer2D.java
> line 2:
>
>> 1:
On Mon, 29 Jan 2024 21:29:31 GMT, Laurent Bourgès wrote:
>> Fixed scale=0 in DMarlinPrismUtils + added new test Scale0Test.java
>
> Laurent Bourgès has updated the pull request incrementally with one
> additional commit since the last revision:
>
> fixed copyright years of modified files +
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to
A big THANK YOU to everybody that was part of this process.
It's very much appreciated !
Regards
Jurgen
On Tue, 30 Jan 2024 11:27:44 +0200, Nir Lisker wrote:
On Fri, 26 Jan 2024 23:59:50 GMT, Nir Lisker wrote:
Added a utility method to run code on the FX thread if it's not
already,
On Wed, 31 Jan 2024 21:09:53 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix issue with multiline text
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
>
On Wed, 31 Jan 2024 10:24:20 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation
19 matches
Mail list logo
