Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > Andy

Re: RFR: 8089373: Translation from character to key code is not sufficient [v2]

> On Windows a common shortcut like Ctrl+'+' could only be invoked from the > main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not > have enough context to know whether it should return a result from the main > keyboard or the keypad. > > This PR alters getKeyCodeForChar

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v11]

On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Layout and property bindings question, what is allowed?

Hi, I'm pretty sure I read somewhere in JavaFX docs, code or website that binding certain properties which are changed during layout is a really bad idea, but I can't find where I've seen this.  Anyone know what I mean? It was something like: binding the values of a property like

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: RFR: JDK-8290310: ChangeListener events are incorrect or misleading when a nested change occurs [v11]

On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote: >> This provides and uses a new implementation of `ExpressionHelper`, called >> `ListenerManager` with improved semantics. >> >> # Behavior >> >> |Listener...|ExpressionHelper|ListenerManager| >> |---|---|---| >> |Invocation Order|In order

Re: RFR: 8089373: Translation from character to key code is not sufficient

On Fri, 17 Nov 2023 20:05:09 GMT, Martin Fox wrote: > On Windows a common shortcut like Ctrl+'+' could only be invoked from the > main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not > have enough context to know whether it should return a result from the main >

RFR: JDK-8325402: TreeTableRow updateItem() does not check item with isItemChanged(..) unlike all other cell implementations

`TreeTableRow` does not check the item with `isItemChanged(..)`, unlike all other implementations of the cell. This also means that the `TreeTableRow` always updates the item, although it should not, resulting in a performance loss as a `TreeTableRow` will always call `updateItem(..)`. It

Aw: Re: Preview features for JavaFX

Sounds good, I also use the latest Early Access versions to quickly identify any regressions/problems or use/implement new features in our application. So thanks for taking care of that!   -- Marius     Gesendet: Mittwoch, 07. Februar 2024 um 11:33 Uhr Von: "Johan Vos" An: "Kevin Rushforth"

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font

On Wed, 7 Feb 2024 00:08:41 GMT, Kevin Rushforth wrote: > would it be possible to create an automated test for this? created a robot test. - PR Comment: https://git.openjdk.org/jfx/pull/1217#issuecomment-1934700117

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v9]

On Tue, 6 Feb 2024 10:31:18 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v10]

On Wed, 7 Feb 2024 10:43:12 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation of

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v10]

On Thu, 8 Feb 2024 06:12:05 GMT, Karthik P K wrote: >>> Since the emoji itself is not rendered properly I don't think it is an >>> issue relevant to this PR. >> >> Quite possibly, these are grapheme clusters which are currently not >> supported: >> `☝☝☝臘‍♂️` >> >> I see the emoji and tab

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

On Thu, 8 Feb 2024 10:16:51 GMT, Karthik P K wrote: > the position of text in the TextArea shifts. yes, that's [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) the padding size is expressed in ems which is incorrect - it should be fixed like everywhere else. - PR

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v11]

On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: JDK-8314215 Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v11]

On Wed, 7 Feb 2024 15:06:18 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: 8307117: TextArea: wrapText property ignored when changing font [v3]

On Wed, 7 Feb 2024 21:41:10 GMT, Andy Goryachev wrote: >> Requesting content layout when font changes. >> >> This change makes the visual impact of >> [JDK-8314683](https://bugs.openjdk.org/browse/JDK-8314683) more visible, so >> perhaps both bugs should be fixed at the same time. > > Andy

[jfx17u] RFR: 8221261: Deadlock on macOS in JFXPanel app when handling IME calls

Clean backport of 8221261: Deadlock on macOS in JFXPanel app when handling IME calls - Commit messages: - 8221261: Deadlock on macOS in JFXPanel app when handling IME calls Changes: https://git.openjdk.org/jfx17u/pull/178/files Webrev: