Hello,
I'm using macOS Sonoma 14.3 aarch64 and I'm trying to recognize whether
a file was successfully dropped into finder from the JavaFX application.
However, the event always reports that it was not accepted. I was under
the impression that event.isAccepted() should return true if it was
On Fri, 9 Feb 2024 22:50:42 GMT, Kevin Rushforth wrote:
> Clean backport to jfx22u.
Marked as reviewed by prr (Reviewer).
-
PR Review: https://git.openjdk.org/jfx22u/pull/10#pullrequestreview-1873401759
On Sat, 10 Feb 2024 00:40:41 GMT, Kevin Rushforth wrote:
> And on Linux I get similar failures to my Windows system due to no Monaco
> font.
Was the Tahoma font available there (you can see from the `TextLayoutTest >
fail()` test) ?
If so, I could rewrite most of the tests to use the Tahoma
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:32:18 GMT, John Hendrikx wrote:
> That's interesting, your local Windows 11 system does not have the Monaco
> font (it is falling back to System Regular it seems). I guess I installed it
> on mine at some point.
Probably so. I just verified that I don't have Monaco on
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:16:33 GMT, John Hendrikx wrote:
> Also I think the `TextLayoutTest` isn't really headful, it never displays
> anything (no stages, uses no `Node`s), but it does need a real `PrismFont` --
> it may be difficult to get that to work though
Yeah, without a proper headless
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Sat, 10 Feb 2024 00:10:33 GMT, Kevin Rushforth wrote:
> That's intentional. We can only run headless tests in the GHA build. We do
> the same thing in our (Oracle's) CI build system.
I was already pleasantly surprised that the three environments all had the
correct Monaco and Tahoma
On Sat, 10 Feb 2024 00:02:38 GMT, John Hendrikx wrote:
> Okay, so I'm getting the impression that the system tests are not run during
> the build (ie. `TextLayoutTest`). Is that an oversight or intended, or is my
> test somehow not qualifying?
>
> clarification: I meant during the Github CI
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:48:15 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 23:37:16 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 9 Feb 2024 23:37:16 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 22:44:07 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
Clean backport to jfx22u.
-
Commit messages:
- Backport a39732a3c66e7168f3a9be84743eb52d4fd0043c
Changes: https://git.openjdk.org/jfx22u/pull/10/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u=10=00
Issue: https://bugs.openjdk.org/browse/JDK-8311492
Stats: 276 lines in
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote:
> Ported changes related to webkit-2.42.5. Verified build on all platforms.
> Sanity testing looks fine.
Looks good. Testing is green.
-
Marked as reviewed by kcr (Lead).
PR Review:
On Fri, 9 Feb 2024 12:56:15 GMT, Kevin Rushforth wrote:
> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
> and alpha blending. The alpha channel is used is ways that interfere with its
> use for transparency. The existing logic checks that the current blend
>
On Fri, 9 Feb 2024 19:19:58 GMT, Andy Goryachev wrote:
>> It's not really a headless vs headful distinction (the system tests are all
>> headful). It's just that some tests have a global (static) Stage that should
>> be hidden at shutdown time. Others, like the test in this PR, create, hide,
On Fri, 9 Feb 2024 21:31:14 GMT, John Hendrikx wrote:
> > > I'm surprised this didn't get reported a long time ago.
> >
> >
> > I'm also surprised.
>
> I do a lot of transparent text, cross fades, animation and other stuff, but
> first thing I always do is turn lcd rendering off...
Which is
On Fri, 9 Feb 2024 21:46:46 GMT, John Hendrikx wrote:
>> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line
>> 414:
>>
>>> 412: 12.0f, 4.001953f
>>> 413: ));
>>> 414:
>>
>> should we add tests for leading/trailing tabs and milti-line strings, and
On Fri, 9 Feb 2024 21:51:15 GMT, John Hendrikx wrote:
> I think it is easy enough for a user to sanitize the strings they deliver a
> bit, while it would be impossible for the user to do so at the soft wrap
> locations.
I agree.
-
PR Comment:
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 17:48:09 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 21:36:03 GMT, John Hendrikx wrote:
>> tests/system/src/test/java/test/com/sun/javafx/text/TextLayoutTest.java line
>> 58:
>>
>>> 56: private final PrismTextLayout layout = new PrismTextLayout();
>>> 57: private final PGFont font = (PGFont)
>>>
On Fri, 9 Feb 2024 17:38:16 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 17:36:04 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Add some clarifying documentation
>> - Do not collapse trailing spaces of last line (where no soft wrap occurs)
>
On Fri, 9 Feb 2024 19:17:59 GMT, Kevin Rushforth wrote:
> > I'm surprised this didn't get reported a long time ago.
>
> I'm also surprised.
I do a lot of transparent text, cross fades, animation and other stuff, but
first thing I always do is turn lcd rendering off...
-
PR
On Fri, 9 Feb 2024 16:24:21 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote:
> Ported changes related to webkit-2.42.5. Verified build on all platforms.
> Sanity testing looks fine.
Builds and tests ran succesfully.
-
Marked as reviewed by sykora (Author).
PR Review:
On Fri, 9 Feb 2024 19:17:00 GMT, Kevin Rushforth wrote:
>> I guess the reason for explicit hiding() of the stages passed to it was done
>> for the sake of headless tests?
>
> It's not really a headless vs headful distinction (the system tests are all
> headful). It's just that some tests have
On Fri, 9 Feb 2024 19:07:53 GMT, Andy Goryachev wrote:
>> One could argue that the method is fine as it is. It will first hide the
>> stages that are passed in (possibly zero of them), and then shutdown the
>> platform. I guess I don't see the problem.
>>
>> Note that by the time this method
On Fri, 9 Feb 2024 17:36:33 GMT, Phil Race wrote:
> I'm surprised this didn't get reported a long time ago.
I'm also surprised.
-
PR Comment: https://git.openjdk.org/jfx/pull/1361#issuecomment-1936472576
On Fri, 9 Feb 2024 19:03:00 GMT, Kevin Rushforth wrote:
>> We can leave this code as is and fix it during the test sprint... I'll file
>> a bug.
>>
>> edit: Created
>> [JDK-8325566](https://bugs.openjdk.org/browse/JDK-8325566)
>> [TestBug] Util.shutdown() to hide ALL the scenes
>>
>> I am so
On Fri, 9 Feb 2024 17:19:06 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
>> line 172:
>>
>>> 170: @AfterAll
>>> 171: public static void doTeardownOnce() {
>>> 172: Util.shutdown();
>>
>> I am sorry, Kevin, you just
On Fri, 9 Feb 2024 07:59:47 GMT, Karthik P K wrote:
>> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
>> conditions were not considered, hence hit test values such as character
>> index and insertion index values were incorrect.
>>
>> Added checks for RTL orientation of
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 12:54:17 GMT, John Hendrikx wrote:
>> There are a number of tickets open related to text rendering:
>>
>> https://bugs.openjdk.org/browse/JDK-8314215
>>
>> https://bugs.openjdk.org/browse/JDK-8145496
>>
>> https://bugs.openjdk.org/browse/JDK-8129014
>>
>> They have in
On Fri, 9 Feb 2024 16:24:21 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
On Fri, 9 Feb 2024 03:37:17 GMT, Martin Fox wrote:
>> On Windows a common shortcut like Ctrl+'+' could only be invoked from the
>> main keyboard and not the numeric keypad. Toolkit.getKeyCodeForChar did not
>> have enough context to know whether it should return a result from the main
>>
On Fri, 9 Feb 2024 16:24:21 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
On Fri, 9 Feb 2024 17:17:28 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> more review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
> line 172:
>
On Fri, 9 Feb 2024 16:24:21 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
On Fri, 9 Feb 2024 17:05:53 GMT, Hima Bindu Meda wrote:
> Cherry-picked changes related to webkit-2.42.5. Verified build on all
> platforms. Sanity testing looks fine.
Reviewers: @kevinrushforth and @johanvos or @tiainen
-
PR Comment:
Cherry-picked changes related to webkit-2.42.5. Verified build on all
platforms. Sanity testing looks fine.
-
Commit messages:
- white space correction
- commit 3d5373575695b293b8559155431d0079a6153aff from webkitglib/2.42 to
resolve build error on 32 bit
- cherry-pick 2.42.5
On Fri, 9 Feb 2024 16:02:19 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
> line 69:
On Thu, 8 Feb 2024 19:26:42 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
On Thu, 8 Feb 2024 19:20:32 GMT, Andy Goryachev wrote:
>> Martin Fox has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains seven additional
>>
> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
> and alpha blending. The alpha channel is used is ways that interfere with its
> use for transparency. The existing logic checks that the current blend
> equation is SRC_OVER and that the surface is opaque, and that
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
On Fri, 9 Feb 2024 15:58:12 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
>> line 81:
>>
>>> 79: // color, or in the middle of the text fill area, where we expect
>>> to find
>>> 80: // the unadjusted text color.
>>> 81:
On Fri, 9 Feb 2024 15:53:20 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> tests/system/src/test/java/test/robot/javafx/scene/TransparentLCDTest.java
> line 67:
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
Hi Nir,
Thanks, yes, those are what I was thinking about. It seems to apply to
more properties though, anything that is changed in a layout methods
seems like a bad idea to bind to something else that may affect layout.
ScrollPane#viewportBoundsProperty seems to be such a property that you
On Fri, 9 Feb 2024 14:29:18 GMT, Kevin Rushforth wrote:
>> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
>> and alpha blending. The alpha channel is used is ways that interfere with
>> its use for transparency. The existing logic checks that the current blend
>>
You're thinking about the docs of the note in the bounds properties I think:
https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInLocalProperty()
https://openjfx.io/javadoc/21/javafx.graphics/javafx/scene/Node.html#boundsInParentProperty()
On Fri, Feb 9, 2024, 03:28 John
On Fri, 9 Feb 2024 13:09:23 GMT, John Hendrikx wrote:
>> Kevin Rushforth has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Address review feedback
>
> modules/javafx.graphics/src/main/java/com/sun/prism/sw/SWGraphics.java line
> 664:
>
> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
> and alpha blending. The alpha channel is used is ways that interfere with its
> use for transparency. The existing logic checks that the current blend
> equation is SRC_OVER and that the surface is opaque, and that
On Fri, 9 Feb 2024 12:56:15 GMT, Kevin Rushforth wrote:
> JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader
> and alpha blending. The alpha channel is used is ways that interfere with its
> use for transparency. The existing logic checks that the current blend
>
JavaFX LCD text rendering (aka sub-pixel antialiasing) uses a pixel shader and
alpha blending. The alpha channel is used is ways that interfere with its use
for transparency. The existing logic checks that the current blend equation is
SRC_OVER and that the surface is opaque, and that we are
> There are a number of tickets open related to text rendering:
>
> https://bugs.openjdk.org/browse/JDK-8314215
>
> https://bugs.openjdk.org/browse/JDK-8145496
>
> https://bugs.openjdk.org/browse/JDK-8129014
>
> They have in common that wrapped text is taking the trailing spaces on each
>
On Thu, 8 Feb 2024 16:06:39 GMT, Andy Goryachev wrote:
>> John Hendrikx has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>>
On Fri, 9 Feb 2024 01:33:20 GMT, John Hendrikx wrote:
> My theory is now that how the wrap width of the `Text` node is updated is not
> entirely legal (I posted on the mailinglist to see if anyone can remember how
> this is supposed to work when you update a value (that may cause layout
>
On Thu, 8 Feb 2024 18:13:58 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix emoji issue
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java
> line 531:
>
>>
> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation
> conditions were not considered, hence hit test values such as character index
> and insertion index values were incorrect.
>
> Added checks for RTL orientation of nodes and fixed the issue in
> `getHitInfo()` to
71 matches
Mail list logo
