Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-26 Thread Karthik P K
On Mon, 26 Feb 2024 16:22:56 GMT, Andy Goryachev wrote: >> You are right. It fails when there are repeated text nodes. I will look into >> this > > yes, this bothered me from the start. I did have a test case in the MT with > two text nodes with the same text, and it seemed to work correctly.

Re: RFR: JDK-8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window

2024-02-26 Thread Kevin Rushforth
On Mon, 26 Feb 2024 20:51:56 GMT, Marius Hanl wrote: > This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is > broken when `sizeToScene()` was called before or after. > > The approach here is to ignore the `sizeToScene()` request when the `Stage` > is maximized or set

RFR: JDK-8326619: Stage.sizeToScene() on maximized/fullscreen Stage breaks the Window

2024-02-26 Thread Marius Hanl
This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog` is broken when `sizeToScene()` was called before or after. The approach here is to ignore the `sizeToScene()` request when the `Stage` is maximized or set to fullscreen. Otherwise the Window Manager of the OS will be

Re: RFR: 8314147: Updated the PhongMaterial documentation [v6]

2024-02-26 Thread Nir Lisker
> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass > `Material`). Except for the introduction, I divided the documentation into 3 > sections: qualitative explanation, mathematical model (I wouldn't think it > necessary, but the current doc explains it), and examples. >

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-26 Thread Andy Goryachev
On Mon, 26 Feb 2024 10:40:03 GMT, Karthik P K wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java >> line 606: >> >>> 604: boolean addLtrIdx = run.getTextSpan().getText().length() >>> != run.length; >>> 605: if (r.getStart() !=

Integrated: 8320965: Scrolling on a touch enabled display fails on Wayland

2024-02-26 Thread Jose Pereda
On Tue, 12 Dec 2023 11:19:23 GMT, Jose Pereda wrote: > This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and > `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and > wrapped functions for GTK 3.20+ (so systems without it still run with GTK > 3.8+), and

Re: RFR: 8314147: Updated the PhongMaterial documentation [v5]

2024-02-26 Thread Lukasz Kostyra
On Sat, 24 Feb 2024 14:40:25 GMT, Nir Lisker wrote: >> Overhaul to the `PhongMaterial` documentation (and a bit to its superclass >> `Material`). Except for the introduction, I divided the documentation into 3 >> sections: qualitative explanation, mathematical model (I wouldn't think it >>

Re: RFR: 8319779: SystemMenu: memory leak due to listener never being removed [v9]

2024-02-26 Thread Kevin Rushforth
On Sat, 20 Jan 2024 20:34:50 GMT, Johan Vos wrote: >> A listener was added but never removed. >> This patch removes the listener when the menu it links to is cleared. Fix >> for https://bugs.openjdk.org/browse/JDK-8319779 > > Johan Vos has updated the pull request incrementally with one

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-26 Thread John Hendrikx
On Wed, 21 Feb 2024 10:01:37 GMT, Karthik P K wrote: >> In the `getHitInfo()` method of PrismTextLayout, RTL node orientation >> conditions were not considered, hence hit test values such as character >> index and insertion index values were incorrect. >> >> Added checks for RTL orientation

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-26 Thread Thiago Milczarek Sayao
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-26 Thread Karthik P K
On Sun, 25 Feb 2024 13:16:06 GMT, John Hendrikx wrote: >> Karthik P K has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits

Re: RFR: 8319844 : Text/TextFlow.hitTest() is incorrect in RTL orientation [v13]

2024-02-26 Thread Karthik P K
On Sat, 24 Feb 2024 23:00:43 GMT, John Hendrikx wrote: >> Karthik P K has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 13 additional >> commits

Re: Proposal: RichTextArea Control (Incubator)

2024-02-26 Thread Robert Lichtenberger
Having read the interesting posts following this announcement, let me add a few points from my perspective: I understand and agree we Johan Vos that there are a lot of open issues in JBS that should be addressed. At the same time I would very much appreciate if a RichTextArea were