Re: RFR: JDK-8327727: Changing the row factory of a TableView does not recreate the rows

2024-03-13 Thread Andy Goryachev
On Sat, 9 Mar 2024 19:52:25 GMT, Marius Hanl wrote: > The fix is very straightfoward. We request a recreation of all cells in the > `VirtualFlow` by calling `flow.recreateCells()` when the `tableRowFactory` > was changed. > > Funny enough, this was done in the `TreeTableViewSkin` again, hence

Re: RFR: 8328136: Create release notes for JavaFX 22

2024-03-13 Thread Kevin Rushforth
On Wed, 13 Mar 2024 23:15:05 GMT, Kevin Rushforth wrote: > Release notes for the JavaFX 22 release. This will first go into `master` and > then be backported to the `jfx22` branch so it will be available in that > branch when JavaFX 22 is published, and from there also synced into the >

RFR: 8328136: Create release notes for JavaFX 22

2024-03-13 Thread Kevin Rushforth
Release notes for the JavaFX 22 release. This will first go into `master` and then be backported to the `jfx22` branch so it will be available in that branch when JavaFX 22 is published, and from there also synced into the `jfx22u` repo. The following filter was used to produce the list of

Re: RFR: 8299423: JavaFX Mac system menubar leaks

2024-03-13 Thread Kevin Rushforth
On Wed, 13 Mar 2024 13:32:32 GMT, Florian Kirmaier wrote: > Because it was fixed in some other PR. Which other PR fixed this? The JBS bug should be linked to that bug, and possibly reference it in the title. Speaking of which, the current title is not accurate and should be changed to

Re: RFR: 8299423: JavaFX Mac system menubar leaks

2024-03-13 Thread Andy Goryachev
On Wed, 13 Mar 2024 13:32:32 GMT, Florian Kirmaier wrote: > Based on my previous PR: https://github.com/openjdk/jfx/pull/987 > This one only contains the test. > Because it was fixed in some other PR. > But i would like to see the Test being merged, to ensure it never breaks > again. Changes

Re: RFR: 8327179: Update the 3D lighting application

2024-03-13 Thread Nir Lisker
On Tue, 5 Mar 2024 16:44:00 GMT, Ambarish Rapte wrote: > Executing the LightingSample manually fails with an exception I think the package names of the main and resources weren't aligned. > The copyright year new files should be 2024 only. Some new files have more > than one copyright year.

Re: RFR: 8327179: Update the 3D lighting application [v4]

2024-03-13 Thread Nir Lisker
> Update for the 3D lighting test tool as described in the JBS issue. Nir Lisker has updated the pull request incrementally with five additional commits since the last revision: - Added spacing - Renamed constant - Updated benchmark reset message - Simplified models creation - Revert

Re: RFR: 8327179: Update the 3D lighting application [v3]

2024-03-13 Thread Nir Lisker
On Tue, 5 Mar 2024 16:49:28 GMT, Ambarish Rapte wrote: >> Nir Lisker has updated the pull request incrementally with one additional >> commit since the last revision: >> >> copyright headers > > tests/performance/3DLighting/src/main/java/lighting3D/Benchmark.java line 49: > >> 47:

Re: RFR: 8327179: Update the 3D lighting application [v3]

2024-03-13 Thread Nir Lisker
> Update for the 3D lighting test tool as described in the JBS issue. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: copyright headers - Changes: - all: https://git.openjdk.org/jfx/pull/1387/files - new:

Re: RFR: 8327179: Update the 3D lighting application [v2]

2024-03-13 Thread Nir Lisker
> Update for the 3D lighting test tool as described in the JBS issue. Nir Lisker has updated the pull request incrementally with one additional commit since the last revision: Undo files move - Changes: - all: https://git.openjdk.org/jfx/pull/1387/files - new:

Re: RFR: 8327471: RTLTextFlowCharacterIndexTest fails on Linux

2024-03-13 Thread Andy Goryachev
On Wed, 13 Mar 2024 05:17:40 GMT, Karthik P K wrote: > Because of the difference in the size of characters in default fonts in > different OS, 2 tests were failing in `RTLTextFlowCharacterIndexTest`. > > Increased the scene width to accommodate all the characters as required for > the test to

RFR: 8299423: JavaFX Mac system menubar leaks

2024-03-13 Thread Florian Kirmaier
Based on my previous PR: https://github.com/openjdk/jfx/pull/987 This one only contains the test. Because it was fixed in some other PR. But i would like to see the Test being merged, to ensure it never breaks again. - Commit messages: - Added test for JDK-8299423 Changes:

Re: RFR: 8322619 Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

2024-03-13 Thread Lukasz Kostyra
On Wed, 13 Mar 2024 09:13:20 GMT, Florian Kirmaier wrote: > Maybe we could make snapshot based tests? That should work on all platforms, > right? We have a whole suite of tests which use similar methods to perform checks, called robot tests. Since you want to check if a node was properly

Re: RFR: 8322619 Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

2024-03-13 Thread Florian Kirmaier
On Tue, 23 Jan 2024 11:51:52 GMT, Florian Kirmaier wrote: >> In some situations, a part of the SG is no longer rendered. >> I created a test program that showcases this problem. >> >> Explanation: >> >> This can happen, when a part of the SG, is covered by another Node. >> In this part, one

RFR: 8255679: RegionBackgroundImageUITest.unalignedImage_Cover fails because of wrong color

2024-03-13 Thread Jayathirth D V
Updated test to get screen capture in different platforms to see how we are picking colors. Found that this test fails because it assumes that red,green & blue bands in the test image are of equal size and picks color based on that assumption. If we take 20 * 20 aligned image, each scanline is

Re: RFR: 8323511 Scrollbar Click jumps inconsistent amount of pixels [v2]

2024-03-13 Thread Florian Kirmaier
On Tue, 5 Mar 2024 09:54:43 GMT, Johan Vos wrote: >> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8323511 >> reverted accidental indentation chang > > @FlorianKirmaier I still think this would be a good

[jfx21u] Integrated: 8322795: CSS performance regression up to 10x

2024-03-13 Thread Johan Vos
On Tue, 12 Mar 2024 09:27:37 GMT, Johan Vos wrote: > 8322795: CSS performance regression up to 10x This pull request has now been integrated. Changeset: c2600685 Author:Johan Vos URL: https://git.openjdk.org/jfx21u/commit/c2600685dbba9f33e01b9b0fcf2346df9b5e0011 Stats: 6 lines