On Tue, 19 Mar 2024 22:34:17 GMT, Nir Lisker wrote:
>> The only issue with this style is - it's hard to set breakpoints.
>> In this case it's not that important.
>> Thank you!
>
> It's a matter of style mostly, so I don't really mind it. The debug issue can
> be remedied by adding breakpoints
On Tue, 19 Mar 2024 22:28:54 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 383:
>>
>>> 381: runAndWait(() -> {
>>> 382: for (Window w : new ArrayList<>(Window.getWindows())) {
>>> 383: w.hide();
>>
>> I think you can use
On Tue, 19 Mar 2024 22:23:46 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> for each
>
> tests/system/src/test/java/test/util/Util.java line 383:
>
>> 381: runAndWait(() -> {
>> 382:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
for each
-
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
tests/system/src/test/java/test/util/Util.java line 383:
> 381:
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR Review:
On Tue, 19 Mar 2024 13:16:48 GMT, Lukasz Kostyra wrote:
>> There were two different problems with this test's stability and HiDPI and
>> both were fixed with this change.
>>
>> The whole reason for this tests lack of stability comes with how Windows
>> calculates window position when using
On Fri, 15 Mar 2024 11:37:53 GMT, Karthik P K wrote:
>> Lukasz Kostyra has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix cast formatting
>
> Tested the changes in Mac, Windows and Linux. The changes fixes the issues in
> Mac and
On Tue, 19 Mar 2024 13:16:48 GMT, Lukasz Kostyra wrote:
>> There were two different problems with this test's stability and HiDPI and
>> both were fixed with this change.
>>
>> The whole reason for this tests lack of stability comes with how Windows
>> calculates window position when using
On Tue, 19 Mar 2024 16:05:50 GMT, Lukasz Kostyra wrote:
> Replaced existing `slowImageURL` address to a new image (+ some extra bits
> related to it). Image has been taken from open-source repository of Duke
> images and licensed under BSD license:
>
On Tue, 19 Mar 2024 16:32:55 GMT, Hima Bindu Meda wrote:
> Clean Backport
This pull request has now been integrated.
Changeset: 32378354
Author:Hima Bindu Meda
URL:
https://git.openjdk.org/jfx22u/commit/323783541140bea2119e2e59d0bb2d8d1fb37c8a
Stats: 10765 lines in 123 files
Clean Backport
-
Commit messages:
- Backport ad3d44e27f8ffb90aad81497f0bba2b00f7a49aa
Changes: https://git.openjdk.org/jfx22u/pull/20/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u=20=00
Issue: https://bugs.openjdk.org/browse/JDK-8324326
Stats: 10765 lines in 123
On Mon, 18 Mar 2024 23:31:03 GMT, Andy Goryachev wrote:
> Add hs_err_pid* to .gitignore
>
> Q: Any other files?
Marked as reviewed by aghaisas (Reviewer).
Oops... I saw the JBS Description now. It is already ignored.
-
PR Review:
On Mon, 18 Mar 2024 23:31:03 GMT, Andy Goryachev wrote:
> Q: Any other files?
May be `.DS_Store` file
-
PR Comment: https://git.openjdk.org/jfx/pull/1408#issuecomment-2007598297
Replaced existing `slowImageURL` address to a new image (+ some extra bits
related to it). Image has been taken from open-source repository of Duke images
and licensed under BSD license: https://wiki.openjdk.org/display/duke/Gallery
-
Commit messages:
- Change slow image link to
Changing `Util.shutdown()` to hide **all** showing Windows and then call
`Platform.exit()`.
This simplifies the tests and ensures a clean shutdown.
-
Commit messages:
- copy
- 8325566: [TestBug] Util.shutdown() to hide ALL the scenes
Changes:
Add hs_err_pid* to .gitignore
Q: Any other files?
-
Commit messages:
- 8328399: Add hs_err_pid* to .gitignore
Changes: https://git.openjdk.org/jfx/pull/1408/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1408=00
Issue: https://bugs.openjdk.org/browse/JDK-8328399
Stats:
On Tue, 19 Mar 2024 12:02:14 GMT, Marius Hanl wrote:
> But is it possible to scroll to an index that is negative?
Yes, both the negative value (``-1``) and the positive value, which is greater
than the items count (to be precise ``last item index + 1``), are possible and
indicate the
> There were two different problems with this test's stability and HiDPI and
> both were fixed with this change.
>
> The whole reason for this tests lack of stability comes with how Windows
> calculates window position when using HiDPI. When window's X/Y coordinates
> are not provided by the
On Fri, 15 Mar 2024 11:37:53 GMT, Karthik P K wrote:
>> There were two different problems with this test's stability and HiDPI and
>> both were fixed with this change.
>>
>> The whole reason for this tests lack of stability comes with how Windows
>> calculates window position when using
On Sun, 17 Mar 2024 17:59:07 GMT, Johan Vos wrote:
>> As I was also involved in fixing this error, I can answer.
>>
>> The `getAvailableCell()` method creates a new cell if none exists for the
>> specified index (-1).
>> The `getCell()` returns the `accumCell` in this case, which is
21 matches
Mail list logo
