On Wed, 20 Mar 2024 19:53:40 GMT, Marius Hanl wrote:
>> This PR fixes the issue that the initial column autosizing is wrong under
>> some circumstances.
>> The following things will break the initial autosizing:
>> - Bold Column text (that is where I initially found this problem)
>> - Another
On Thu, 21 Mar 2024 22:06:42 GMT, Marius Hanl wrote:
> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
> of the stub font implementation. As I don't want to clutter the PR with that,
> I decided to cherrypick the improvements I did to a new ticket and PR.
>
> The
I like this idea in general. It would be a good thing to consider for a
future test sprint. I have a few high-level questions on the specifics:
1. I've not used JUnit5 TestWatcher at all, but it seems like it might
do what we want. Does anyone else have practical experience with it? For
cases
Dear colleagues:
What do you think of the following idea:
The Problem
===
Automated headful tests might fail intermittently or on specific platform(s).
After the fact, it's nearly impossible to understand why this happened.
Solution
Implement a JUnit5 TestWatcher which
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
I can, but it will
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
@Maran23 @nlisker
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy
On Fri, 22 Mar 2024 13:00:02 GMT, Karthik P K wrote:
> * In all the pages, under Region option, if we select MAX_VALUE for Min
> Height or Min Width, the application hangs or whole window becomes white. I
> observed this issue if we select MIN_VALUE or POSITIVE_INFINITY as well.
works as
Removed unused imports in javafx.swing (1 change) module.
See the discussion in [JDK-8289379](https://bugs.openjdk.org/browse/JDK-8289379)
-
Commit messages:
- 8328820: Remove unused imports in javafx.swing
Changes: https://git.openjdk.org/jfx/pull/1428/files
Webrev:
This PR extends the range of hi-res images that are loaded via naming
convention, now including scale factors higher than "@2x".
Supporting these is already being
[recommended](https://developer.apple.com/design/human-interface-guidelines/images#Best-practices)
for some platforms.
I tested
Fixing missing @Overrides in demo apps.
This is still a trivial change since all the spots are identified by the IDE.
-
Commit messages:
- part 3
- part 2
- part 1
Changes: https://git.openjdk.org/jfx/pull/1426/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1426=00
Fixing missing @ OVERRIDES in tests.
This is still a trivial change since all the spots are identified by the IDE.
-
Commit messages:
- 8328754: Fix missing @Overrides in test
Changes: https://git.openjdk.org/jfx/pull/1427/files
Webrev:
Updating the JSL files to remove the "missing @ override" warning.
-
Commit messages:
- 8328818: Fix Decora JSL to remove missing @Override warnings
Changes: https://git.openjdk.org/jfx/pull/1425/files
Webrev: https://webrevs.openjdk.org/?repo=jfx=1425=00
Issue:
On Thu, 21 Mar 2024 21:57:46 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports **javafx.web** module, and update
> the copyright year to 2024. Using wildcard for more than 10 static imports.
>
>
> --
>
> This is a trivial change, 1 reviewer is probably enough.
removed
> Using Eclipse IDE to remove unused imports **javafx.web** module, and update
> the copyright year to 2024. Using wildcard for more than 10 static imports.
>
>
> --
>
> This is a trivial change, 1 reviewer is probably enough.
Andy Goryachev has updated the pull request incrementally with one
Using Eclipse IDE to remove unused imports in **javafx.swing** and
**javafx.web** modules, and update the copyright year to 2024. Using wildcard
for more than 10 static imports.
--
This is a trivial change, 1 reviewer is probably enough.
-
Commit messages:
- 8328749: Remove
On Fri, 22 Mar 2024 15:52:02 GMT, Andy Goryachev wrote:
> I suppose I'd need to extract swing into a separate PR, right @kevinrushforth
> ?
Yes. I was just getting ready to write this:
It looks like I spoke too soon when I said it was OK to combine the change to
`javafx.swing` into this PR.
On Thu, 21 Mar 2024 21:57:46 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **javafx.swing** and
> **javafx.web** modules, and update the copyright year to 2024. Using wildcard
> for more than 10 static imports.
>
>
> --
>
> This is a trivial change, 1 reviewer
On Thu, 21 Mar 2024 21:57:46 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **javafx.swing** and
> **javafx.web** modules, and update the copyright year to 2024. Using wildcard
> for more than 10 static imports.
>
>
> --
>
> This is a trivial change, 1 reviewer
On Thu, 21 Mar 2024 23:48:40 GMT, Andy Goryachev wrote:
> Fix missing @Overrides in **javafx.web**.
>
> This is still a trivial change since all the spots are identified by the IDE.
There are special considerations when touching files under
Fix missing @Overrides in **javafx.web**.
This is still a trivial change since all the spots are identified by the IDE.
-
Commit messages:
- part 2
- 8328752: Fix missing @Overrides in javafx.web
Changes: https://git.openjdk.org/jfx/pull/1424/files
Webrev:
On Wed, 20 Mar 2024 23:56:50 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window
22 matches
Mail list logo
