On Mon, 25 Mar 2024 22:49:22 GMT, Marius Hanl wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/chart/AreaChartTest.java
>> line 538:
>>
>>> 536: .map(lineTo -> new Point2D(
>>> 537:
>>>
On Fri, 22 Mar 2024 22:32:25 GMT, Andy Goryachev wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
On Fri, 22 Mar 2024 22:59:34 GMT, Andy Goryachev wrote:
>> Marius Hanl has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - JDK-8186188: copyright
>> - JDK-8186188: fix tests
>
>
On Fri, 22 Mar 2024 22:37:09 GMT, Andy Goryachev wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
On Fri, 22 Mar 2024 22:29:32 GMT, Andy Goryachev wrote:
>> In https://github.com/openjdk/jfx/pull/1405, I identified some shortcomings
>> of the stub font implementation. As I don't want to clutter the PR with
>> that, I decided to cherrypick the improvements I did to a new ticket and PR.
>>
On Thu, 21 Mar 2024 18:47:24 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in javafx.controls and update the
> copyright year to 2024. Using wildcard for more than 10 static imports.
>
> This is a trivial change, 1 reviewer is probably enough.
Sure.
I may also need
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy
On Tue, 5 Mar 2024 16:47:45 GMT, Kevin Rushforth wrote:
> Now that the last of the javadoc warnings are fixed or suppressed, it is time
> to enable `-Werror` so that new javadoc warnings don't creep into our code
> base. The GHA run was successful.
>
> You can see the `-Werror` doing its job
On Fri, 22 Mar 2024 15:53:14 GMT, Andy Goryachev wrote:
> Updating the JSL files to remove the "missing @ override" warning.
This pull request has now been integrated.
Changeset: 611555ee
Author:Andy Goryachev
URL:
On Thu, 21 Mar 2024 22:43:38 GMT, Andy Goryachev wrote:
> Fix missing `@Override`s in
> - javafx.base
> - javafx.controls
> - javafx.graphics
>
> This is still a trivial change since all the spots are identified by the IDE.
>
> 1 reviewer is probably enough.
This pull request has now been
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Fri, 15 Mar 2024 09:43:26 GMT, Marius Hanl wrote:
>> Okay.
>>
>> Tests: Well, there are some properties we can test here:
>> - wrapText = true -> height should be used -> check truncated
>> - width changed -> check truncated
>> - text changed -> check truncated
>
> You can check here how I
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy
On Mon, 25 Mar 2024 13:32:11 GMT, Michael Strauß wrote:
> `ListenerManager` is an obvious improvement, as it fixes incorrect behavior
> and allows listeners to veto changes. However, the behavior of
> `ListenerManager` is also an implementation detail and not documented
> anywhere. This leads
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
On Mon, 25 Mar 2024 20:11:21 GMT, Kevin Rushforth wrote:
> Can you review this?
in the queue; yes.
-
PR Comment: https://git.openjdk.org/jfx/pull/1411#issuecomment-2018832489
On Wed, 20 Mar 2024 10:55:56 GMT, Jose Pereda wrote:
> This PR fixes the issue that after committing an edit on a
> ListView/TreeView/TableView/TreeTableView control, the control might lose the
> focus unexpectedly.
>
> For that, it refactors the
>
On Thu, 21 Mar 2024 22:43:38 GMT, Andy Goryachev wrote:
> Fix missing `@Override`s in
> - javafx.base
> - javafx.controls
> - javafx.graphics
>
> This is still a trivial change since all the spots are identified by the IDE.
>
> 1 reviewer is probably enough.
Marked as reviewed by kcr (Lead).
On Fri, 22 Mar 2024 15:53:14 GMT, Andy Goryachev wrote:
> Updating the JSL files to remove the "missing @ override" warning.
Marked as reviewed by kcr (Lead).
-
PR Review: https://git.openjdk.org/jfx/pull/1425#pullrequestreview-1958676563
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Fri, 22 Mar 2024 16:17:29 GMT, drmarmac wrote:
> This PR extends the range of hi-res images that are loaded via naming
> convention, now including scale factors higher than `@2x`.
> Supporting these is already being
>
On Sun, 24 Mar 2024 15:10:22 GMT, drmarmac wrote:
> This PR removes potentially incorrect usages of Stream.peek().
> The changed code should be covered by the tests that are already present.
Reviewers: @andy-goryachev-oracle @karthikpandelu
-
PR Comment:
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Sun, 24 Mar 2024 15:11:16 GMT, drmarmac wrote:
> This PR should fix the issue and cover all relevant cases with new tests.
>
> Note: This involves a small behavior change, as can be seen in
> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With
> this change the
On Mon, 25 Mar 2024 12:25:33 GMT, Jayathirth D V wrote:
> This test has failed once and we are not seeing its failure after that
> instance in our test systems.
>
> This test verifies whether bounds of GridPane gets updated properly on adding
> an invisible node.
> Initial test has 8 nodes in
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu ✔
> - added embedded swing/fx in tools ✔
> - added copy
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
On Mon, 25 Mar 2024 07:13:18 GMT, Karthik P K wrote:
> I can see the MT app process getting created but no window is showing up.
Oh I see - it stored the user choice. Delete the folder `~/.MonkeyTester` (or
`\UsersMonkeyTester` and all should be well.
-
PR Comment:
On Mon, 25 Mar 2024 12:25:33 GMT, Jayathirth D V wrote:
> This test has failed once and we are not seeing its failure after that
> instance in our test systems.
>
> This test verifies whether bounds of GridPane gets updated properly on adding
> an invisible node.
> Initial test has 8 nodes in
On Fri, 9 Jun 2023 12:00:06 GMT, John Hendrikx wrote:
>> This provides and uses a new implementation of `ExpressionHelper`, called
>> `ListenerManager` with improved semantics.
>>
>> # Behavior
>>
>> |Listener...|ExpressionHelper|ListenerManager|
>> |---|---|---|
>> |Invocation Order|In order
On Wed, 13 Mar 2024 22:32:59 GMT, Nir Lisker wrote:
>> Update for the 3D lighting test tool as described in the JBS issue.
>
> Nir Lisker has updated the pull request incrementally with five additional
> commits since the last revision:
>
> - Added spacing
> - Renamed constant
> - Updated
This test has failed once and we are not seeing its failure after that instance
in our test systems.
This test verifies whether bounds of GridPane gets updated properly on adding
an invisible node.
Initial test has 8 nodes in GridPane and then we update it with another node
with larger bounds
On Fri, 22 Mar 2024 18:23:41 GMT, Andy Goryachev wrote:
> > * In all the pages, under Region option, if we select MAX_VALUE for Min
> > Height or Min Width, the application hangs or whole window becomes white. I
> > observed this issue if we select MIN_VALUE or POSITIVE_INFINITY as well.
>
>
36 matches
Mail list logo
