On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Thu, 28 Mar 2024 22:21:32 GMT, drmarmac wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/ControlUtils.java
>> line 166:
>>
>>> 164: sm.startAtomic();
>>> 165:
>>> 166: final List removed = new
>>> ArrayList<>(c.getRemovedSize());
>>
>> I wonder
On Thu, 28 Mar 2024 17:53:14 GMT, Andy Goryachev wrote:
>> drmarmac has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Preallocate in SelectedIndicesList.set()
>> - Remove unused import
>
>
On Thu, 28 Mar 2024 21:44:49 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Mon, 18 Mar 2024 21:02:54 GMT, Andy Goryachev wrote:
> Further changes to the MonkeyTester application:
>
> - remember split pane divider ✔
> - use 'private' instead of 'protected' in many cases ✔
> - added more scripts to the 'writing systems' text sample ✔
> - added RTL window control menu
On Mon, 15 Jan 2024 08:31:59 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 25 Mar 2024 22:36:48 GMT, Andy Goryachev wrote:
>> Further changes to the MonkeyTester application:
>>
>> - remember split pane divider ✔
>> - use 'private' instead of 'protected' in many cases ✔
>> - added more scripts to the 'writing systems' text sample ✔
>> - added RTL window
On Thu, 28 Mar 2024 18:53:00 GMT, eduardsdv wrote:
>> This change fixes the calculation of which nodes go to the toolbar and which
>> go to the overflow menu.
>> It is now determined before the nodes are removed from the scene graph.
>> This is important because the values returned by
>>
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
> This change fixes the calculation of which nodes go to the toolbar and which
> go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by
> ``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Thu, 28 Mar 2024 15:48:50 GMT, Andy Goryachev wrote:
> a minor question: would it be much easier to understand if the code was
> written in conventional procedural style? a straightforward `for` loop?
Even if it were (and I'm not sure it would be), it would be a more intrusive
change than
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Fri, 22 Mar 2024 15:55:35 GMT, Andy Goryachev wrote:
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
This pull request has now been integrated.
Changeset: 7a4d2976
Author:Andy Goryachev
URL:
On Thu, 28 Mar 2024 16:27:44 GMT, Ajit Ghaisas wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
On Thu, 28 Mar 2024 14:54:47 GMT, Andy Goryachev wrote:
>> Fixing missing @ OVERRIDES in tests.
>>
>> This is still a trivial change since all the spots are identified by the IDE.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Thu, 28 Mar 2024 14:54:47 GMT, Andy Goryachev wrote:
>> Fixing missing @ OVERRIDES in tests.
>>
>> This is still a trivial change since all the spots are identified by the IDE.
>
> Andy Goryachev has updated the pull request with a new target base due to a
> merge or a rebase. The
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Thu, 28 Mar 2024 11:31:14 GMT, eduardsdv wrote:
> This change fixes the calculation of which nodes go to the toolbar and which
> go to the overflow menu.
> It is now determined before the nodes are removed from the scene graph.
> This is important because the values returned by
>
On Thu, 28 Mar 2024 12:12:07 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the
On Fri, 22 Mar 2024 15:54:42 GMT, Andy Goryachev wrote:
> Fixing missing @Overrides in demo apps.
>
> This is still a trivial change since all the spots are identified by the IDE.
This pull request has now been integrated.
Changeset: 9ca8e51e
Author:Andy Goryachev
URL:
On Wed, 6 Mar 2024 15:51:16 GMT, Lukasz Kostyra wrote:
> Fixed as described in the issue + added tests to check for this scenario with
> all Transform sub classes. Since the test scenario slightly exceeding the
> regular parametrized testing of `TransformOperationsTest` I decided to
>
On Fri, 16 Feb 2024 22:35:49 GMT, Martin Fox wrote:
> At the end of a drag operation the Mac Glass code sends out a DRAG_DONE event
> using the operation mask tracked in the GlassDragSource to determine the
> final transfer mode. That mask is only updated when a window in the JavaFX
> app is
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
On Thu, 28 Mar 2024 11:23:02 GMT, Lukasz Kostyra wrote:
>> Fixed as described in the issue + added tests to check for this scenario
>> with all Transform sub classes. Since the test scenario slightly exceeding
>> the regular parametrized testing of `TransformOperationsTest` I decided to
>>
On Fri, 22 Mar 2024 15:55:35 GMT, Andy Goryachev wrote:
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
Changes looks good.
Found few file where `@Override` can be added for `start` method.
1. `BigGlyphIDTest.java`
2.
On Fri, 22 Mar 2024 15:55:35 GMT, Andy Goryachev wrote:
> Fixing missing @ OVERRIDES in tests.
>
> This is still a trivial change since all the spots are identified by the IDE.
Looks good.
-
Marked as reviewed by aghaisas (Reviewer).
PR Review:
This change fixes the calculation of which nodes go to the toolbar and which go
to the overflow menu.
It is now determined before the nodes are removed from the scene graph.
This is important because the values returned by
``Node.prefWidth(..)``/``Node.prefHeight(..)`` may depend on whether the
On Fri, 22 Mar 2024 15:54:42 GMT, Andy Goryachev wrote:
> Fixing missing @Overrides in demo apps.
>
> This is still a trivial change since all the spots are identified by the IDE.
Looks good.
-
Marked as reviewed by aghaisas (Reviewer).
PR Review:
> Fixed as described in the issue + added tests to check for this scenario with
> all Transform sub classes. Since the test scenario slightly exceeding the
> regular parametrized testing of `TransformOperationsTest` I decided to
> implement the tests in a separate class.
>
> I didn't manage to
On Wed, 20 Mar 2024 10:55:56 GMT, Jose Pereda wrote:
> This PR fixes the issue that after committing an edit on a
> ListView/TreeView/TableView/TreeTableView control, the control might lose the
> focus unexpectedly.
>
> For that, it refactors the
>
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Thu, 28 Mar 2024 06:07:24 GMT, Karthik P K wrote:
>> You don't need to return a list, you create it ahead of time like was done
>> in line 167
>>
>> List indices = new ArrayList<>();
>>
>> and the add the elements in `forEach`.
>
>> Why do the double-iteration pattern here and not do the
On Thu, 28 Mar 2024 08:49:44 GMT, drmarmac wrote:
>> This PR removes potentially incorrect usages of Stream.peek().
>> The changed code should be covered by the tests that are already present.
>
> drmarmac has updated the pull request incrementally with two additional
> commits since the last
> This PR removes potentially incorrect usages of Stream.peek().
> The changed code should be covered by the tests that are already present.
drmarmac has updated the pull request incrementally with two additional commits
since the last revision:
- Preallocate in SelectedIndicesList.set()
-
On Wed, 27 Mar 2024 23:21:34 GMT, Nir Lisker wrote:
>> `forEach` is void, so we can not return a list afterwards.
>
> You don't need to return a list, you create it ahead of time like was done in
> line 167
>
> List indices = new ArrayList<>();
>
> and the add the elements in `forEach`.
>
On Wed, 27 Mar 2024 23:24:51 GMT, Marius Hanl wrote:
>>> In the java.util.stream package
>>> [docs](https://docs.oracle.com/en/java/javase/16/docs/api/java.base/java/util/stream/package-summary.html#SideEffects)
>>> it is mentioned that `forEach()` method operates only via side-effects. So
40 matches
Mail list logo
