Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v2]

2024-04-26 Thread Alexander Matveev
On Fri, 26 Apr 2024 22:58:30 GMT, Alexander Matveev wrote: >> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. >> - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR >> for more details): >> - MP2T streams with one H.264/AVC video track and elementary AAC

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v3]

2024-04-26 Thread Alexander Matveev
> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementary AAC audio > stream via #EXT-X-MEDIA tag. > - fMP4 streams with one

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]

2024-04-26 Thread Andy Goryachev
On Fri, 26 Apr 2024 22:58:37 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max`

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Oliver Kopp
On Fri, 26 Apr 2024 09:57:34 GMT, Ambarish Rapte wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make use of Utils.clamp function > > Here is a capture from my machine. > I have two copies of source code: One with

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v24]

2024-04-26 Thread Oliver Kopp
> Fixes https://bugs.openjdk.org/browse/JDK-8330462. > > If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, then > an addition of `start` to it leads to a negative value. This is "fixed" by > using `Math.max` comparing the `maxLength` and `maxLength + start`. Oliver Kopp

Re: RFR: 8282999: Add support for EXT-X-MEDIA tag in HTTP Live Streaming [v2]

2024-04-26 Thread Alexander Matveev
> - Added support for #EXT-X-MEDIA tag to HTTP Live Streaming. > - Following audio renditions via #EXT-X-MEDIA tag will be supported (see CSR > for more details): > - MP2T streams with one H.264/AVC video track and elementary AAC audio > stream via #EXT-X-MEDIA tag. > - fMP4 streams with one

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Oliver Kopp
On Fri, 26 Apr 2024 09:57:34 GMT, Ambarish Rapte wrote: >> Oliver Kopp has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Make use of Utils.clamp function > > Here is a capture from my machine. > I have two copies of source code: One with

Re: RFR: 8242553: IntegerSpinner and DoubleSpinner do not wrap around values correctly in some cases [v2]

2024-04-26 Thread Andy Goryachev
On Wed, 10 Apr 2024 11:47:28 GMT, drmarmac wrote: >> This PR should fix the issue and cover all relevant cases with new tests. >> >> Note: This involves a small behavior change, as can be seen in >> dblSpinner_testWrapAround_decrement_twoSteps() in SpinnerTest.java:749. With >> this change

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v18]

2024-04-26 Thread Kevin Rushforth
On Tue, 23 Apr 2024 19:30:49 GMT, John Hendrikx wrote: >> There are a number of tickets open related to text rendering: >> >> https://bugs.openjdk.org/browse/JDK-8314215 >> >> https://bugs.openjdk.org/browse/JDK-8145496 >> >> https://bugs.openjdk.org/browse/JDK-8129014 >> >> They have in

Re: RFR: 8322619: Parts of SG no longer update during rendering - overlapping - culling - dirty [v3]

2024-04-26 Thread eduardsdv
On Tue, 23 Jan 2024 11:51:52 GMT, Florian Kirmaier wrote: >> In some situations, a part of the SG is no longer rendered. >> I created a test program that showcases this problem. >> >> Explanation: >> >> This can happen, when a part of the SG, is covered by another Node. >> In this part, one

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v18]

2024-04-26 Thread Kevin Rushforth
On Wed, 24 Apr 2024 15:23:39 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright years > > One meta comment (not directly related to this review). > >> > since it's been

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Oliver Kopp
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max`

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Kevin Rushforth
On Fri, 26 Apr 2024 09:57:34 GMT, Ambarish Rapte wrote: > Here is a capture from my machine. > I have two copies of source code: One with fix and other without fix. > Please do unmute the video playback, you can listen to Narrator voice output. @arapte Thank you for doing this and attaching it.

Re: RFR: 8314215: Trailing Spaces before Line Breaks Affect the Center Alignment of Text [v18]

2024-04-26 Thread John Hendrikx
On Wed, 24 Apr 2024 15:23:39 GMT, Kevin Rushforth wrote: >> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update copyright years > > One meta comment (not directly related to this review). > >> > since it's been

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex [v3]

2024-04-26 Thread Michael Strauß
On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra wrote: >> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are >> no longer needed. >> >> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I >> changed the type to explicitly use

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Ambarish Rapte
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max`

Integrated: 8273657 : TextField: all text content must be selected initially

2024-04-26 Thread Karthik P K
On Thu, 25 Apr 2024 14:26:06 GMT, Karthik P K wrote: > The text was not getting selected on adding the `TextField` to the scene > initially, subsequently removing and adding the `TextField` to the scene > selects the entire text present in the `TextField`. > > Made changes in the

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex [v3]

2024-04-26 Thread Nir Lisker
On Fri, 26 Apr 2024 07:53:59 GMT, Lukasz Kostyra wrote: >> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are >> no longer needed. >> >> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I >> changed the type to explicitly use

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex [v3]

2024-04-26 Thread Lukasz Kostyra
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are > no longer needed. > > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I > changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it > doesn't matter much

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex [v2]

2024-04-26 Thread Lukasz Kostyra
> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are > no longer needed. > > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I > changed the type to explicitly use `IDirect3DDevice9Ex`. Technically it > doesn't matter much

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex

2024-04-26 Thread Lukasz Kostyra
On Thu, 25 Apr 2024 15:20:54 GMT, Nir Lisker wrote: >> JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are >> no longer needed. >> >> In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I >> changed the type to explicitly use

Re: RFR: 8320563: Remove D3D9 code paths in favor of D3D9Ex

2024-04-26 Thread Lukasz Kostyra
On Tue, 23 Apr 2024 10:33:58 GMT, Lukasz Kostyra wrote: > JFX minimum requirements guarantee 9Ex availability, so old non-Ex paths are > no longer needed. > > In multiple parts (ex. Mesh, Graphics, etc.) where the Device is acquired I > changed the type to explicitly use `IDirect3DDevice9Ex`.

Re: RFR: 8330462: StringIndexOutOfBoundException when typing anything into TextField [v23]

2024-04-26 Thread Oliver Kopp
On Thu, 25 Apr 2024 21:41:14 GMT, Oliver Kopp wrote: >> Fixes https://bugs.openjdk.org/browse/JDK-8330462. >> >> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`, >> then an addition of `start` to it leads to a negative value. This is "fixed" >> by using `Math.max`