sibly error not exceeding (1.0 / scale).
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The pull request now contains 33 commits:
- Merge remote-tracking branch 'origin/master' into 8299753.resize
- Merge branch 'master' into 8299753.resize
- Merge
On Fri, 12 Apr 2024 22:47:21 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in fa
On Thu, 6 Jun 2024 20:24:07 GMT, John Hendrikx wrote:
>> I see, PrismFontFactory:164 getNativeFactoryName().
>> It would be nice to place platform-specific code in a package bearing the
>> platform name, or at least mention this in a class-level comment, but I
>> guess it's too late.
>>
>> It
On Thu, 6 Jun 2024 16:46:39 GMT, Karthik P K wrote:
>> The issue is specific to Mac. The glyph positions returned from native side
>> for complex text is not handled in the text render logic. This issue is
>> observed only when trailing spaces are present along with LTR text mixed
>> with RTL
On Thu, 6 Jun 2024 15:21:15 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTGlyphLayout.java
>> line 161:
>>
>>> 159: * When traling spces are present in the text containing
>>> LTR and RTL
>>> 160: * text together,
On Thu, 6 Jun 2024 14:15:09 GMT, Karthik P K wrote:
>> The issue is specific to Mac. The glyph positions returned from native side
>> for complex text is not handled in the text render logic. This issue is
>> observed only when trailing spaces are present along with LTR text mixed
>> with RTL
On Thu, 30 May 2024 15:36:37 GMT, Andy Goryachev wrote:
> The root cause is that the skin used two fields to store one entity
> (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible
> menu(s) are present.
>
> The fix involves using a single index variable.
&
On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote:
> Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px`
> in modena.css to make them independent of the font size *in that control*.
>
> After the change, the UI still looks good which can be teste
On Wed, 5 Jun 2024 14:47:55 GMT, Kevin Rushforth wrote:
> This PR presupposes that the scroll bar size and content padding _should_ be
> changed to be independent of the font size
I disagree. The size of the UI elements enveloping a content area should not
depend on the font size of the font
Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px` in
modena.css to make them independent of the font size *in that control*.
After the change, the UI still looks good which can be tested by scaling
default font size in a fairly wide range:
.root {
On Thu, 23 May 2024 12:56:22 GMT, Marius Hanl wrote:
>> This PR fixes the border glitch/gap as explained in both linked tickets.
>>
>> I noted that the `ScrollPane` control does not suffer from this problem,
>> although the code is mostly the same as in `VirtualFlow`. The `ScrollPane`
>>
On Sun, 26 May 2024 12:47:20 GMT, Marius Hanl wrote:
>> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
>> modify the layout of `VirtualFlow`.
>>
>> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
>> which made many calculations leading
On Fri, 31 May 2024 14:39:00 GMT, Karthik P K wrote:
> The issue is specific to Mac. The glyph positions returned from native side
> for complex text is not handled in the text render logic. This issue is
> observed only when trailing spaces are present along with LTR text mixed with
> RTL
On Fri, 31 May 2024 15:17:19 GMT, Andy Goryachev wrote:
>> The root cause is that the skin used two fields to store one entity
>> (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible
>> menu(s) are present.
>>
>> The fix involves using a sing
On Fri, 31 May 2024 12:35:53 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/ski
`openMenuButton` can also
> be replaced with a single boolean, but I decided not to change these in order
> to keep the amount of diffs to a minimum.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
review comments
The root cause is that the skin used two fields to store one entity
(`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible menu(s)
are present.
The fix involves using a single index variable.
Also wanted to note that in theory, `openMenu` and `openMenuButton` can also be
Unfortunately, this idea won't work in JavaFX, because it needs the change in
the Skin/Behavior.
-andy
From: Mads
Date: Tuesday, May 28, 2024 at 01:59
To: Andy Goryachev
Cc: openjfx-dev@openjdk.org
Subject: [External] : Re: JavaFX TableView text in the cells of the columns
seems to jump
Hi
On Wed, 29 May 2024 15:52:36 GMT, Lukasz Kostyra wrote:
>> Checked code and fixed the gramatical error in Transition files:
>> s/interval/intervals
>>
>> Fill and Stroke Transition had correct grammatical form already, so those
>> were untouched. I couldn't find any other instances of this
On Tue, 28 May 2024 21:41:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Tue, 28 May 2024 21:31:53 GMT, Marius Hanl wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added 100% coverage test for FixedCapacitySet
>
>
On Tue, 28 May 2024 04:48:32 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Tue, 28 May 2024 11:25:51 GMT, Michael Strauß wrote:
>> True, but I think it's a lot easier to follow than the logic before it. I
>> see it a bit more as a hint to future maintainers (which might be me) that
>> there are assumptions being made here that code relies on.
>
> I understand
On Tue, 28 May 2024 16:15:25 GMT, Michael Strauß wrote:
> This PR fixes the incorrect computation of the `CornerRadii.uniform` flag for
> the 16-argument constructor.
>
> I've also added tests for all other constructors.
the change looks good. thank you for adding a comprehensive test!
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Sun, 26 May 2024 13:02:23 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Sun, 26 May 2024 12:44:23 GMT, Marius Hanl wrote:
> Yeah this is a 'known bug' for me, and has nothing to do with this fix.
I do not see the issue without the fix though (at the same resolution).
-
PR Comment: https://git.openjdk.org/jfx/pull/1462#issuecomment-2135380812
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Thu, 23 May 2024 22:17:36 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
lors and the
fact that the tooltip show delay gets changed on the second and any subsequent
invocations.
Can you try it?
https://github.com/andy-goryachev-oracle/MonkeyTest
-
PR Comment: https://git.openjdk.org/jfx/pull/1394#issuecomment-2128136276
On Thu, 23 May 2024 14:54:36 GMT, Marius Hanl wrote:
>> This PR fixes a long standing issue where the `Tooltip` will always wait one
>> second until it appears the very first time, even if the
>> `-fx-show-delay` was set to another value.
>>
>> The culprit is, that the `cssForced` flag is not
On Fri, 17 May 2024 19:22:39 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
On Thu, 23 May 2024 17:48:15 GMT, Kevin Rushforth wrote:
> Those lines are modified by this PR
You are right! I had cached java files in build/modulal-sdk/modules_src which
Eclipse search picked up.
Apparently, there is a way to mark the folder as "derived" so it will be
ignored by the
On Fri, 17 May 2024 19:22:39 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
On Fri, 17 May 2024 19:22:39 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnings, which
>
On Thu, 23 May 2024 16:01:29 GMT, Michael Strauß wrote:
> Short of using a build system, how would I run a manual test with this new
> class?
I am running from within Eclipse. Here is the command line (remove newlines)
it launches the EmojiTest. I think the key is to add the location of
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnings, which
>
Vote: YES
-andy
From: openjfx-dev on behalf of Kevin Rushforth
Date: Wednesday, May 22, 2024 at 16:24
To: openjfx-dev , John Hendrikx
Subject: CFV: New OpenJFX Reviewer: John Hendrikx
I hereby nominate John Hendrikx [1] to OpenJFX Reviewer.
John is an OpenJFX community member, who has
On Wed, 6 Mar 2024 19:55:54 GMT, Andy Goryachev wrote:
> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
> bindings to
>
> - ListView
> - TreeView
> - TableView
> - TreeTableView
>
> to support keyboard-only horizontal and vertical
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
On Mon, 20 May 2024 21:40:30 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> vertical scrolling tests
>
> modules/javafx.controls/src/main/java/com/sun
key bindings documented in
> /doc-files/behavior
>
> Note:
> Jenkins headful test passed on all mac configurations, failed on all linux
> configurations (master branch failed also, so it is test issue), while
> windows configuration is not yet available.
Andy Goryachev has upd
On Fri, 19 Apr 2024 19:44:28 GMT, Andy Goryachev wrote:
> This change replaces Character.isLetterOrDigit(char) which fails with
> surrogate characters with Character.isLetterOrDigit(int).
This pull request has now been integrated.
Changeset: b5fe3622
Author: Andy Goryache
On Thu, 16 May 2024 18:30:17 GMT, Andy Goryachev wrote:
> Root cause: premature 'return' from initialization code leaves the hover
> square visible, even when it should be hidden, as the case is when the color
> value is not present in the palette.
>
> - added unit tests
Th
On Fri, 19 Apr 2024 18:10:32 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
utton("Test");
> }
> }
>
>
> Resulting application window:
>
> 
>
> Readme:
>
> https://github.com/andy-goryachev-oracle/jfx/blob/8319555.manual/tes
On Fri, 17 May 2024 08:07:58 GMT, Ambarish Rapte wrote:
> `hoverSquare`'s visible property is not initialized in the `ColorPalette`
> constructor.
thank you for reviewing, @arapte !
effectively, yes, and that's the issue I have fixed, by explicitly setting
visibility in `setFocusedSquare()`
On Fri, 17 May 2024 07:28:44 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Fri, 17 May 2024 08:45:43 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
> This change replaces Character.isLetterOrDigit(char) which fails with
> surrogate characters with Character.isLetterOrDigit(int).
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
b
On Fri, 17 May 2024 14:55:18 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and
Root cause: premature 'return' from initialization code leaves the hover square
visible, even when it should be hidden, as the case is when the color value is
not present in the palette.
- added unit tests
-
Commit messages:
- 8324327: ColorPicker shows a white rectangle on
On Wed, 15 May 2024 23:01:30 GMT, Andy Goryachev wrote:
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> -
On Thu, 16 May 2024 16:23:26 GMT, Ambarish Rapte wrote:
>> thank you for pointing this out, I am going to revert back to `` and
>> update `PopupControl`.
>
> Looks good,
> I recommend to update the summary, current summary is quite specific to
> Region / prefWidth/Height.
>
> A suggestion->
>
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
> Ubuntu
> The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers
> to `getPrefHeight(forWidth) / getPrefWidth(forHeight)`
>
> should be
>
> `prefHeight(forWidth) / prefWidth(forHeight)`
>
> - same issue is also fixed in `PopupControl`.
Andy Goryachev has
On Thu, 16 May 2024 10:01:05 GMT, Ambarish Rapte wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> popup control
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/Region
The javadoc for `Region.getPrefHeight() / getPrefWidth()` incorrectly refers to
`getPrefHeight(forWidth) / getPrefWidth(forHeight)`
should be
`prefHeight(forWidth) / prefWidth(forHeight)`
- also converted these references to `{@link}`s.
-
Commit messages:
- 8332251: javadoc:
em down into
> more manageable parts, and solve the most fundamental issues first. At
> the very least, the issue with event invocation ordering should be
> solved in the event system.
>
>
>
> On Mon, Mar 11, 2024 at 4:22 PM Andy Goryachev
> wrote:
>> Dear JavaFX dev
On Tue, 14 May 2024 22:29:18 GMT, Martin Fox wrote:
>> On Linux getKeyCodeForChar does not consult the current keyboard layout. For
>> example, it assumes the “+” character is on KeyCode.PLUS even on layouts
>> which don’t generate KeyCode.PLUS. The result is that most
>>
On Wed, 15 May 2024 20:03:01 GMT, Phil Race wrote:
>> Not sure what you mean, but it doesn't seem related to this PR.
>
> He means people reading reviews are usually on github and your github ID is
> kevinrusforth,
> so they might be confused by "kcr" which is your openjdk id.
>
> Since the
On Wed, 15 May 2024 19:23:25 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 19:16:31 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing, and integrating
>
>
> The commit being backported was authored by Oliver Kopp on 8 May 2024 and was
> reviewed by Andy Goryachev, Kevin Rushforth and Ambarish Rapte.
>
> The backport is almost clean: While cherry picking the mainline commit, a
> minor merge conflict was shown at the file
&g
On Thu, 9 May 2024 09:38:31 GMT, Karthik P K wrote:
>> The `ComboBox` value was not set to previously selected value in the item
>> list change listener when `setAll` method is used to change the items. Fixed
>> the issue by restoring the selection in this case.
>>
>> Added a unit test to
On Thu, 9 May 2024 09:38:31 GMT, Karthik P K wrote:
>> The `ComboBox` value was not set to previously selected value in the item
>> list change listener when `setAll` method is used to change the items. Fixed
>> the issue by restoring the selection in this case.
>>
>> Added a unit test to
On Tue, 14 May 2024 14:44:58 GMT, Johan Vos wrote:
> I'm not sure I understand the question
I thought there were specific comments somewhere in the code. Never mind then.
Thank you for responding!
-
PR Comment: https://git.openjdk.org/jfx/pull/1326#issuecomment-2110915337
On Mon, 13 May 2024 15:54:47 GMT, Kevin Rushforth wrote:
>> tests/system/src/test/.classpath line 17:
>>
>>> 15:
>>> 16:
>>> 17: >>
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote:
> The backport is almost clean.
> While cherry picking the mainline commit, a minor merge conflict was shown in
> a the file `tests/system/src/test/.classpath` : The mainline file has a few
> additional exports compared to 22u.
>
> Test
On Mon, 13 May 2024 09:36:39 GMT, Ambarish Rapte wrote:
> The backport is almost clean.
> While cherry picking the mainline commit, a minor merge conflict was shown in
> a the file `tests/system/src/test/.classpath` : The mainline file has a few
> additional exports compared to 22u.
>
> Test
On Fri, 12 Apr 2024 22:47:21 GMT, Andy Goryachev wrote:
>> Modified the resize algorithm to work well with fractional scale, thanks for
>> deeper understanding of the problem thanks to @hjohn and @mstr2 .
>>
>> Removed earlier manual tester in fa
On Thu, 9 May 2024 17:34:11 GMT, Johan Vos wrote:
> the idea about mapping scroll events to the top/bottom of a cell is hinted in
> the code though
could you please point to these places?
I think this change is inline with the modern UIs, at least macOS and Windows.
As Eduard correctly
Date: Thursday, May 9, 2024 at 07:56
To: openjfx-dev@openjdk.org
Subject: There is no workaround for JDK-8324327
Hello all.
This is about https://bugs.openjdk.org/browse/JDK-8324327 .
Andy Goryachev wrote in comment "Change to the default constructor and the
issue disappears".
I
On Fri, 19 Apr 2024 20:36:42 GMT, Andy Goryachev wrote:
>> This change replaces Character.isLetterOrDigit(char) which fails with
>> surrogate characters with Character.isLetterOrDigit(int).
>
> Andy Goryachev has updated the pull request with a new target base due to a
&
, the fix looks good.
>> That's a great gesture, thanks, but I was just reviewing the changes, you
>> don't have to add me as a contributor.
>> Thanks for your contribution, Approving.!
>
> @arapte @andy-goryachev-oracle @kevinrushforth Thank you for your ongoing
>
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property is being set by the code
On Tue, 7 May 2024 20:39:13 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Tue, 7 May 2024 19:13:02 GMT, Christoph wrote:
>>> EnabledOnOs
>>
>> thank you @Siedlerchr for this info.
>> I wonder what criteria are set for determining the OS value, and do they
>> match jfx ones?
>
> They just read the `os.name` with `System.getProperty("os.name") but that
> only
On Tue, 7 May 2024 18:47:04 GMT, Christoph wrote:
> EnabledOnOs
thank you @Siedlerchr for this info.
I wonder what criteria are set for determining the OS value, and do they match
jfx ones?
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1442#discussion_r1592928523
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Thu, 2 May 2024 23:35:12 GMT, Oliver Kopp wrote:
>> Fixes https://bugs.openjdk.org/browse/JDK-8330462.
>>
>> If the parameter `maxLength` is larger than `Integer.MAX_VALUE - start`,
>> then an addition of `start` to it leads to a negative value. This is "fixed"
>> by using `Math.max`
On Tue, 7 May 2024 09:44:08 GMT, eduardsdv wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Use viewport length as block increment
>
> In my opinion, this PR is now ready.
should the contributor
On Tue, 7 May 2024 09:39:23 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Tue, 7 May 2024 14:18:29 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Uti
On Tue, 7 May 2024 16:37:06 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/com/sun/glass/ui/win/WinTextRangeProviderTest.java
>> line 56:
>>
>>> 54: @AfterAll
>>> 55: static void shutdown() {
>>> 56: Util.shutdown(
On Tue, 7 May 2024 16:29:33 GMT, Kevin Rushforth wrote:
>> Oliver Kopp has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Streamline WinTextRangeProviderTest
>>
>> Source:
>>
On Tue, 7 May 2024 14:18:44 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Uti
7483) TreeView: Allow
> for tooltip when cell text is truncated
> * [JDK-8205211](https://bugs.openjdk.org/browse/JDK-8205211) Ability to show
> Tooltip only when text is shown with ellipsis (...)
Andy Goryachev has updated the pull request incrementally with one ad
On Tue, 7 May 2024 15:27:55 GMT, Kevin Rushforth wrote:
>> Updated. I checked this variant with IntelliJ: While I can follow the link,
>> it doesn't show the wrapAround field's javadoc, just the
>> wrapAroundProperty's javadoc which is empty.
>
> I guess that's because IntelliJ doesn't process
e size and
complexity of the proposal, I suggest to break the problem down into
more manageable parts, and solve the most fundamental issues first. At
the very least, the issue with event invocation ordering should be
solved in the event system.
On Mon, Mar 11, 2024 at 4:22 PM Andy Goryachev
On Tue, 7 May 2024 06:09:07 GMT, drmarmac wrote:
>> This PR updates the javadoc for the SpinnerFactory wrap-around behavior
>> introduced in #1431.
>
> drmarmac has updated the pull request incrementally with one additional
> commit since the last revision:
>
> javaDoc: Qualify property
On Tue, 7 May 2024 09:02:49 GMT, Michael Strauß wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> comments
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/contr
key bindings documented in
> /doc-files/behavior
>
> Note:
> Jenkins headful test passed on all mac configurations, failed on all linux
> configurations (master branch failed also, so it is test issue), while
> windows configuration is not yet available.
Andy Goryache
mac configurations, failed on all linux
> configurations (master branch failed also, so it is test issue), while
> windows configuration is not yet available.
Andy Goryachev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the
1 - 100 of 2312 matches
Mail list logo
