On Wed, 5 Jun 2024 21:59:13 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both
On Sun, 26 May 2024 11:26:50 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> documentation change
>
> I think the CSR needs updating.
@nlisker @drmarmac Can you re-review (there have only been
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao
wrote:
>> This fixes two bugs appointed on the JBS issue:
>>
>> 1) Sometimes window was moving to the top left corner - seems to be a bug
>> somewhere in `gdk_window_get_origin` when used before map (a X concept when
>> the window
On Fri, 7 Jun 2024 18:29:00 GMT, Martin Fox wrote:
> When drawing to the screen JavaFX is producing sRGB colors but on macOS
> that’s not necessarily what the user is seeing. Since the pixels are not
> tagged as sRGB the OS is copying them unmodified to the frame buffer to be
> displayed in
Voting for John Hendrikx [1] to OpenJFX Reviewer [2] is now closed.
Yes: 6
Veto: 0
Abstain: 0
According to the Bylaws definition of Three-Vote Consensus, this is
sufficient to approve the nomination.
-- Kevin
[1] https://openjdk.org/census#jhendrikx
[2]
On Thu, 6 Jun 2024 17:35:54 GMT, Joeri Sykora wrote:
> Replaces the deprecated `classifier` property with `archiveClassifier`. The
> property was removed with the release of Gradle 8.0:
> https://docs.gradle.org/8.0/userguide/upgrading_version_7.html#abstractarchivetask_api_cleanup
Marked as
On Thu, 6 Jun 2024 14:59:04 GMT, Andy Goryachev wrote:
>> Karthik P K has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fixing the issue in CTGlyphLayout class
>
>
On Mon, 27 May 2024 19:41:18 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Thu, 23 May 2024 13:48:48 GMT, Marius Hanl wrote:
>> The fix looks good. The spec changes (updated javadocs) look good. Can you
>> create the CSR for the spec change?
>>
>> I have a couple overall comments:
>>
>> * I wanted to verify different orders of operation, so I wrote a (manual)
>>
On Wed, 5 Jun 2024 21:47:21 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html
>> line 704:
>>
>>> 702:
>>> 703: >> scope="row">transitionproperty
>>> 704: [ none | all | customident#
>>> ]
>>
>> Why is there a
On Wed, 5 Jun 2024 07:29:58 GMT, Florian Kirmaier wrote:
>> Florian Kirmaier has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 10 commits:
>>
>> - Merge branch 'openjdk:master' into JDK-8277848-list-binding-leak
>> - JDK-8277848
On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both
On Sat, 25 May 2024 20:49:08 GMT, Nir Lisker wrote:
>> I've included the images that are also used in the CSS reference
>> documentation. Now there are two copies of these images in two different
>> `doc-files` folders, but I guess that's okay.
>
> I think it's fine. Another option is to link
On Fri, 31 May 2024 15:17:19 GMT, Andy Goryachev wrote:
>> The root cause is that the skin used two fields to store one entity
>> (`focusedMenu` and `focusedMenuIndex`), causing mismatch when invisible
>> menu(s) are present.
>>
>> The fix involves using a single index variable.
>>
>> Also
On Wed, 5 Jun 2024 15:31:05 GMT, Andy Goryachev wrote:
> It does not look right either, the UI elements should not get scaled in my
> opinion, only the text. I'd rather have a consistent size of UI elements in
> an application.
This will need further discussion.
-
PR Comment:
On Wed, 5 Jun 2024 14:52:37 GMT, Andy Goryachev wrote:
> > This PR presupposes that the scroll bar size and content padding _should_
> > be changed to be independent of the font size
>
> I disagree. The size of the UI elements enveloping a content area should not
> depend on the font size of
On Fri, 31 May 2024 21:50:08 GMT, Andy Goryachev wrote:
> Changing certain ScrollBar, ScrollPane, and TextArea sizes from `em` to `px`
> in modena.css to make them independent of the font size *in that control*.
>
> After the change, the UI still looks good which can be tested by scaling
>
On Fri, 31 May 2024 15:09:38 GMT, Michael Strauß wrote:
>> Implementation of [CSS
>> Transitions](https://www.w3.org/TR/css-transitions-1/).
>>
>> ### Future enhancements
>> CSS transition support for backgrounds and borders: #1471
>>
>> ### Limitations
>> This implementation supports both
On Tue, 4 Jun 2024 16:31:49 GMT, Michael Strauß wrote:
>> This PR completes the CSS Transitions story (see #870) by adding
>> interpolation support for backgrounds and borders, making them targetable by
>> transitions.
>>
>> `Background` and `Border` objects are deeply immutable, but not
>>
On Tue, 14 May 2024 13:37:32 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> Ok, I've updated the CSR accrodingly together with
On Fri, 24 May 2024 15:04:08 GMT, Nir Lisker wrote:
>> John Hendrikx has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Move getStyleClassNames to location it was introduced to reduce diff
>
> The code looks good. I didn't test it, but I'm
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
Code changes look good. Tests are green.
-
Marked as reviewed by kcr (Lead).
PR Review:
On Fri, 24 May 2024 18:18:22 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.7. Sanity testing looks fine. No issue seen
Reviewers: @kevinrushforth @tiainen
-
PR Comment: https://git.openjdk.org/jfx/pull/1464#issuecomment-2130131350
On Thu, 23 May 2024 14:01:40 GMT, Marius Hanl wrote:
>> This PR fixes the problem that maximizing/fullscreen a `Stage` or `Dialog`
>> is broken when `sizeToScene()` was called before or after.
>>
>> The approach here is to ignore the `sizeToScene()` request when the `Stage`
>> is maximized or
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnin
All,
If you have backports that you want to get into jfx22u for JavaFX
22.0.2, please do so by Monday, June 10th. Note that approval from one
of the project leads is needed as outlined in this message [1].
Thanks.
-- Kevin
[1]
On Wed, 22 May 2024 15:50:46 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Fri, 24 May 2024 06:48:50 GMT, Jayathirth D V wrote:
> In IJG library's jmemmgr.c file we can define MEM_STATS(by default this flag
> is not defined and we don't see any issue) to enable printing of memory
> statistics log. But if we enable it, we get crash while disposing IJG stored
>
On Fri, 24 May 2024 08:22:28 GMT, John Hendrikx wrote:
> > I wonder if we may want to add some tests for the `FixedCapacitySet`?
>
> Yeah, now that it is more likely that this will make it into FX, I will add a
> small set of unit tests for this class.
Since this PR is ready to integrate, I
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote:
>> Improves performance of selector matching in the CSS subsystem. This is done
>> by using custom set implementation which are highly optimized for the most
>> common cases where the number of selectors is small (most commonly 1 or 2).
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to
On Thu, 23 May 2024 21:51:55 GMT, Marius Hanl wrote:
> Alternative PR to https://github.com/openjdk/jfx/pull/1330 which does not
> modify the layout of `VirtualFlow`.
>
> This PR fixes the glitching by removing the code in `NGNode.renderRectClip`,
> which made many calculations leading to
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnin
On Thu, 23 May 2024 16:21:06 GMT, Andy Goryachev wrote:
> Are these all the places where javadoc fails, or more files are coming
> separately?
There are only 5 places where javadoc fails with the latest JDK 23. By
eliminating all cases where we have more than three slashes, this PR fixes
On Fri, 17 May 2024 19:22:39 GMT, Andy Goryachev wrote:
>> ## ManualTestWindow
>>
>> This facility provides the base class for manual tests which displays the
>> test instructions,
>> the UI under test, and the Pass/Fail buttons.
>>
>> Example:
>>
>>
>> public class ManualTestExample
[JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
support to javadoc, using `///` to indicate markdown documentation comments. As
a result, building JavaFX docs with JDK 23 produces new warnings, which causes
the build to fail (since we treat warnings as errors).
This
On Thu, 23 May 2024 15:22:38 GMT, Kevin Rushforth wrote:
> [JDK-8298405](https://bugs.openjdk.org/browse/JDK-8298405) added markdown
> support to javadoc, using `///` to indicate markdown documentation comments.
> As a result, building JavaFX docs with JDK 23 produces new warnin
Vote: YES
-- Kevin
On 5/22/2024 4:24 PM, Kevin Rushforth wrote:
I hereby nominate John Hendrikx [1] to OpenJFX Reviewer.
I hereby nominate John Hendrikx [1] to OpenJFX Reviewer.
John is an OpenJFX community member, who has contributed 39 commits [2]
to OpenJFX. John regularly participates in code reviews, especially in
the areas of JavaFX properties, scene graph and UI controls, offering
valuable feedback.
To: All jfx contributors, particularly those with a Reviewer or
Committer role in the OpenJFX project on OpenJDK [1]
As some of you are already aware, we have modified the JavaFX Code
Review policies, including additional requirements for Reviewers, PR
authors, and sponsoring Committers. The
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing,
On Wed, 22 May 2024 08:36:22 GMT, eduardsdv wrote:
>>> @johanvos added a question in the CSR about this last part:
>>>
>>> > I understand and agree with the goal behind this.
>>> > I'm a bit confused though about the following: "...but it does not
>>> > necessarily have to be the same value."
On Wed, 22 May 2024 08:10:16 GMT, Jose Pereda wrote:
>> This PR fixes a bug
>> ([JDK-8289115](https://bugs.openjdk.org/browse/JDK-8289115)) that was
>> introduced with #394, which changed the following line in the
>> `NotifyTouchInput` function (ViewContainer.cpp):
>>
>> - const bool
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes gu
On Tue, 21 May 2024 22:32:21 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes gu
On Sat, 18 May 2024 14:28:31 GMT, Nir Lisker wrote:
>> We have by now cleaned up our public API to avoid classes with an implicit
>> no-arg constructor, so the only way this situation could arise in the future
>> is if someone adds a new public class, which needs a CSR anyway.
>>
>> I guess
cies section
> * Create a "Before you integrate or sponsor a PR" subsection of the Code
> review policies section
> * Update the `CONTRIBUTING.md` page to highlight important requirements
Kevin Rushforth has updated the pull request incrementally with one additional
commit since
On Fri, 17 May 2024 07:28:44 GMT, Florian Kirmaier
wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top.
On Mon, 20 May 2024 23:37:22 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Fri, 8 Mar 2024 16:39:56 GMT, Marius Hanl wrote:
>> This seems like a reasonable fix and spec change. Have you tested the case
>> of calling sizeToScene before setting full-screen or maximzed? Since the
>> pending flag will still be set in that case, I want to make sure that case
>> is
On Mon, 20 May 2024 13:03:24 GMT, Thiago Milczarek Sayao
wrote:
> There's a pending change request that I think it's not needed anymore since I
> rolled back the changes on the InputMethod interface.
That's correct, given that this no longer has any public API. I'll try
dismissing that
On Fri, 17 May 2024 15:02:14 GMT, Nir Lisker wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 20 addi
On Fri, 17 May 2024 12:36:22 GMT, Florian Kirmaier
wrote:
> Sorry for creating the CSR, it was an accident.
No problem.
> Now that Eduard has both created an alternative solution, but also has
> reviewed that this solution is correct, and provided an unit-test - I think
> this (or the
On Fri, 17 May 2024 13:46:12 GMT, eduardsdv wrote:
> > I'm only wondering if the code in `paintImpl` should always clear the dirty
> > bits even if an exception occurs during painting, to harden it against
> > potential bugs and not end up trying to repaint again and again likely
> > getting
cies section
> * Create a "Before you integrate or sponsor a PR" subsection of the Code
> review policies section
> * Update the `CONTRIBUTING.md` page to highlight important requirements
Kevin Rushforth has updated the pull request incrementally with one additional
commit since t
On Fri, 17 May 2024 14:10:43 GMT, Kevin Rushforth wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes gu
On Wed, 15 May 2024 22:18:24 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 79:
>>
>>> 77: * All Reviewers who have requested the chance to review have done so
>>> (or indicated that they are OK with it going in without their review). In
>>>
On Thu, 16 May 2024 07:27:34 GMT, Johan Vos wrote:
>> That's a good idea.
>
> In the ideal world where we have tons of regression and compatibility tests,
> I would agree. Unfortunately, we are totally not there yet. Compared to other
> projects, the quality of tests in OpenJFX is good, but
On Wed, 15 May 2024 18:30:06 GMT, Andy Goryachev wrote:
>> Kevin Rushforth has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request cont
On Wed, 15 May 2024 19:38:55 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 64:
>>
>>> 62:
>>> 63: * Make sure you understand why there was an issue to begin with, and
>>> why/how the proposed PR solves the issue
>>> 64: * Focus fir
On Wed, 15 May 2024 22:00:42 GMT, Kevin Rushforth wrote:
>> I think it worth noting that in skara syntax that isn't two people with the
>> reviewer role.
>> And tell people what to use if that is what they intend - eg if I have it
>> right
>
> It's `/revie
On Wed, 15 May 2024 21:58:46 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 14:
>>
>>> 12: ### Reviewers
>>> 13:
>>> 14: The [List of Reviewers](https://openjdk.java.net/census#openjfx) is on
>>> the OpenJDK Census.
>>
&
On Wed, 15 May 2024 22:13:34 GMT, Kevin Rushforth wrote:
>>> or is it? :-)
>>
>> 
>>
>> Looks to me like it is...
>
> A passing GHA test run is neither necessary
On Wed, 15 May 2024 22:10:12 GMT, Kevin Rushforth wrote:
> > ...inadvertent introduction of new API (that will have to be deprecated if
> > missed)
>
> I think this is worth mentioning.
Fixed.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1455#discussion_r1605063298
On Wed, 15 May 2024 22:05:46 GMT, Kevin Rushforth wrote:
>> README-code-reviews.md line 60:
>>
>>> 58: * If you want an area expert to review a PR, indicate this in a comment
>>> of the form: `Reviewers: @PERSON1 @PERSON2`; the requested reviewers can
>>
On Wed, 15 May 2024 21:57:55 GMT, Kevin Rushforth wrote:
>> exactly my point. when the majority of time is spent in the context of
>> github (PR review etc) it might be confusing when one types `@jvos` and it's
>> not found, or when within a PR there are refere
cies section
> * Create a "Before you integrate or sponsor a PR" subsection of the Code
> review policies section
> * Update the `CONTRIBUTING.md` page to highlight important requirements
Kevin Rushforth has updated the pull request with a new target base due to a
merge or a rebase.
On Thu, 16 May 2024 08:48:14 GMT, John Hendrikx wrote:
>> I agree with the concern, but I still think it's much better to encourage
>> developers to do formatting in a separate issue (or not at all) with all the
>> required administration, than to sneak in a formatting change in a PR that
>>
On Thu, 16 May 2024 22:23:40 GMT, Kevin Rushforth wrote:
> Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
> future 22u backports)
This pull request has now been integrated.
Changeset: e7545c6c
Author: Kevin Rushforth
URL:
https://git.openjdk.org/
On Thu, 16 May 2024 22:23:40 GMT, Kevin Rushforth wrote:
> Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
> future 22u backports)
@johanvos Since this is a clean backport, it doesn't need to be reviewed, but
it does need maintainer approval. It's not an urge
Clean backport of Linux GHA fix to jfx22u (so we can get clean GHA runs for
future 22u backports)
-
Commit messages:
- Backport d7ab55184f757a614f9fc8f191c3c5794a16cc88
Changes: https://git.openjdk.org/jfx22u/pull/29/files
Webrev: https://webrevs.openjdk.org/?repo=jfx22u=29=00
On Tue, 14 May 2024 13:37:32 GMT, Florian Kirmaier
wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8323511: Adjust javadoc of the getViewportLength()
>
> Ok, I've updated the CSR accrodingly together with
On Mon, 6 May 2024 23:14:11 GMT, Andy Goryachev wrote:
>> Adding alt-ctrl-LEFT/RIGHT/UP/DOWN (option-command-LEFT/RIGHT/UP/DOWN) key
>> bindings to
>>
>> - ListView
>> - TreeView
>> - TableView
>> - TreeTableView
>>
>> to support keyboard-only horizontal and vertical scrolling. The main
On Thu, 9 May 2024 14:49:26 GMT, Florian Kirmaier wrote:
>> As seen in the unit test of the PR, when we click on the area above/below
>> the scrollbar the position jumps - but the jump is now not always consistent.
>> In the current version on the last cell - the UI always jumps to the top. In
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
On Thu, 16 May 2024 15:42:05 GMT, Kevin Rushforth wrote:
> It looks like the list of packages available in the Ubuntu 22.04 GitHub
> Actions test runner no longer includes `gcc-13` as of yesterday. I didn't
> find any documentation to indicate that this was intentional, but now that
It looks like the list of packages available in the Ubuntu 22.04 GitHub Actions
test runner no longer includes `gcc-13` as of yesterday. I didn't find any
documentation to indicate that this was intentional, but now that Ubuntu 24.04
is available we can fix the problem by updating to that
On Wed, 15 May 2024 20:18:05 GMT, Phil Race wrote:
>> This is out of scope for this PR, but it might be something to consider
>> addressing in a follow-on enhancement.
>
> It should be made clear (somewhere, at some point) that it would be rare for
> a CSR to be completed and approved before
On Wed, 15 May 2024 20:08:05 GMT, John Hendrikx wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
On Wed, 15 May 2024 19:50:32 GMT, Andy Goryachev wrote:
>> README-code-reviews.md line 60:
>>
>>> 58: * If you want an area expert to review a PR, indicate this in a comment
>>> of the form: `Reviewers: @PERSON1 @PERSON2`; the requested reviewers can
>>> indicate whether or not they plan to
On Wed, 15 May 2024 20:23:37 GMT, Nir Lisker wrote:
>> Isn't this automatic? Seems weird you could integrate without these passing.
>
>> or is it? :-)
>
> 
>
> Looks to me like it is...
A passing GHA
On Wed, 15 May 2024 20:12:09 GMT, Phil Race wrote:
>> README-code-reviews.md line 48:
>>
>>> 46: All code reviews must be done via a pull request submitted against this
>>> GitHub repo, [openjdk/jfx](https://github.com/openjdk/jfx). A JBS bug ID
>>> must exist before the pull request will be
On Wed, 15 May 2024 19:04:19 GMT, Nir Lisker wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 20:33:37 GMT, Andy Goryachev wrote:
>> He means people reading reviews are usually on github and your github ID is
>> kevinrusforth,
>> so they might be confused by "kcr" which is your openjdk id.
>>
>> Since the context is identifying OpenJDK Project leads, I think the
On Wed, 15 May 2024 20:07:06 GMT, Phil Race wrote:
>> Update the code review guidelines for JavaFX.
>>
>> The JavaFX
>> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
>> guidelines includes guidance for creating, reviewing, and integrating
>>
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing,
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing,
thing to consider addressing in a follow-on enhancement, although I'm not
sure I want to make it any more specific.
> README-code-reviews.md line 101:
>
>> 99: A feature should be discussed up-front on the openjfx-dev mailing list
>> to get early feedback on the concept (is
s.openjdk.org/projects/JDK/issues/
> ?
Whether or not that might be a better link, it's unrelated to this PR. The
scope of this PR is limited to guidelines surrounding reviewing, integrating,
and sponsoring PRs.
> README-code-reviews.md line 10:
>
>> 8:
>> 9: __Project Co-Lea
On Wed, 15 May 2024 17:45:56 GMT, Kevin Rushforth wrote:
> Update the code review guidelines for JavaFX.
>
> The JavaFX
> [CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
> guidelines includes guidance for creating, reviewing,
Update the code review guidelines for JavaFX.
The JavaFX
[CONTRIBUTING](https://github.com/kevinrushforth/jfx/blob/8332313-contributing/CONTRIBUTING.md)
guidelines includes guidance for creating, reviewing, and integrating changes
to JavaFX, along with a pointer to a [Code Review
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.6. Verified build and sanity testing on all
> platforms. No issue seen
Looks good. All testing is green.
-
Marked as reviewed by kcr (Lead).
PR Review:
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote:
> Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing
> looks fine.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR Review: https://git.openjdk.org/jfx/pull/1454#pullrequestreview-2056068196
On Tue, 14 May 2024 14:23:18 GMT, Johan Vos wrote:
> In Joeri I trust :)
Me, too. :)
-
PR Comment: https://git.openjdk.org/jfx/pull/1454#issuecomment-2110417688
On Tue, 14 May 2024 11:45:06 GMT, Hima Bindu Meda wrote:
> Update SQLite to v3.45.3.Verified build on all platforms. Sanity testing
> looks fine.
Reviewers: @tiainen @kevinrushforth
@johanvos do you also want to review or is Joeri's review OK?
-
PR Comment:
On Tue, 14 May 2024 05:21:37 GMT, Hima Bindu Meda wrote:
> Updated libxml to v2.12.6. Verified build and sanity testing on all
> platforms. No issue seen
Reviewers: @tiainen @kevinrushforth
-
PR Comment: https://git.openjdk.org/jfx/pull/1453#issuecomment-2110233307
On Mon, 13 May 2024 17:26:02 GMT, Ambarish Rapte wrote:
>> Ah, I see. In that case, reordering to match mainline seems good.
>
> May be I am missing something here,
> I verified the order, it is same as mainline jfx. (jfx has 3 more, that
> follow the new addition)
In that case, my earlier
On Mon, 13 May 2024 16:39:43 GMT, Andy Goryachev wrote:
>> Probably not as part of this backport. Also, the fact that they are
>> different suggests that there might be another fix that is in mainline but
>> not in jfx22u (and we wouldn't choose to backport another fix just to avoid
>> a
1 - 100 of 2647 matches
Mail list logo
