Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-09 Thread Thiago Milczarek Sayao
On Sun, 9 Jun 2024 12:56:32 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v14]

2024-06-09 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v22]

2024-06-09 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 96 commits: - Merge branch 'refs/heads/master' into new_ime - Merge b

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-06-07 Thread Thiago Milczarek Sayao
On Fri, 17 May 2024 19:10:17 GMT, Glavo wrote: >> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 94 commits: >> >> - Merge branch 'master' into new_ime >> - Add signals

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-06-07 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
On Mon, 27 May 2024 09:30:18 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v13]

2024-05-27 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v21]

2024-05-27 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 95 commits: - Merge branch 'refs/heads/master' into new_ime - Merge bran

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-05-27 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:53:36 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-26 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8322964: Optimize performance of CSS selector matching [v9]

2024-05-24 Thread Thiago Milczarek Sayao
On Mon, 11 Mar 2024 16:54:25 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done >> by using custom set implementation which are highly optimized for the most >> common cases where the number of selectors is small (most commonly 1 or 2).

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:48:08 GMT, Jose Pereda wrote: >> The linux build seems to be failing because the lack of gcc-13 package. > > @tsayao the Ubuntu runner uses now 24.0.4. Your branch just needs to be > synced with head. @jperedadnr Thanks. @karthikpandelu I tested the sample with the

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v3]

2024-05-23 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in b

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
On Thu, 23 May 2024 10:29:33 GMT, Thiago Milczarek Sayao wrote: >> This fixes two bugs appointed on the JBS issue: >> >> 1) Sometimes window was moving to the top left corner - seems to be a bug >> somewhere in `gdk_window_get_origin` when used before map (a X con

Re: RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage [v2]

2024-05-23 Thread Thiago Milczarek Sayao
ply > constraints when not floating (meaning floating on the screen - not > maximized, fullscreen or iconified). Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Should still report location - Changes:

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
On Wed, 22 May 2024 22:02:33 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v12]

2024-05-22 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-22 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

RFR: 8332222: Linux Debian: Maximized stage shrinks when opening another stage

2024-05-22 Thread Thiago Milczarek Sayao
This fixes two bugs appointed on the JBS issue: 1) Sometimes window was moving to the top left corner - seems to be a bug somewhere in `gdk_window_get_origin` when used before map (a X concept when the window appears). The change is to ignore the configure events (happens when location or size

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-20 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-17 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Integrated: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-05-15 Thread Thiago Milczarek Sayao
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. This pull request has now

Withdrawn: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 2 Apr 2023 20:38:25 GMT, Thiago Milczarek Sayao wrote: > This replaces obsolete XIM and uses gtk api for IME. > Gtk uses [ibus](https://github.com/ibus/ibus) > > Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative > positioning on `Inp

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-13 Thread Thiago Milczarek Sayao
On Sun, 12 May 2024 11:03:36 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Withdrawn: 8329820: [Linux] Prefer EGL over GLX

2024-05-13 Thread Thiago Milczarek Sayao
On Sat, 24 Feb 2024 17:54:47 GMT, Thiago Milczarek Sayao wrote: > Wayland implementation will require EGL. > > EGL works with Xorg as well. The idea is to be EGL first and if it fails, > fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. > > > See: &

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v11]

2024-05-12 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v10]

2024-05-01 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v9]

2024-05-01 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v8]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 20:03:18 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v8]

2024-04-30 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with four additiona

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
On Tue, 30 Apr 2024 12:22:34 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v7]

2024-04-30 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v6]

2024-04-29 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v5]

2024-04-29 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-28 Thread Thiago Milczarek Sayao
On Thu, 25 Apr 2024 12:19:19 GMT, Lukasz Kostyra wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Forgot debug message > > modules/javafx.graphics/src/main/native-prism-

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v4]

2024-04-28 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-23 Thread Thiago Milczarek Sayao
On Fri, 19 Apr 2024 14:42:23 GMT, Thiago Milczarek Sayao wrote: >> Wayland implementation will require EGL. >> >> EGL works with Xorg as well. The idea is to be EGL first and if it fails, >> fallback to GLX. A force flag `prism.es2.forceGLX=true` is available. >&

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v3]

2024-04-19 Thread Thiago Milczarek Sayao
rom GLX to > EGL](https://mozillagfx.wordpress.com/2021/10/30/switching-the-linux-graphics-stack-from-glx-to-egl/) > [Prefer EGL to GLX for the GL support on > X11](https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one addition

Re: RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-07 Thread Thiago Milczarek Sayao
On Sat, 6 Apr 2024 17:34:06 GMT, Thiago Milczarek Sayao wrote: > Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. > > It seems i3 replies with decorated sizes, even if window is not decorated. > > Won't hurt other WMs. High chance it's t

RFR: 8329821: [Linux] When using i3 WM, menus are incorrectly sized

2024-04-06 Thread Thiago Milczarek Sayao
Simple fix to only request `_NET_FRAME_EXTENTS` if window has decoration. It seems i3 replies with decorated sizes, even if window is not decorated. Won't hurt other WMs. - Commit messages: - - Fix for i3 menus size Changes: https://git.openjdk.org/jfx/pull/1437/files Webrev:

Re: RFR: 8329820: [Linux] Prefer EGL over GLX [v2]

2024-04-06 Thread Thiago Milczarek Sayao
NOME/gtk/-/merge_requests/3540) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: - Remove fprintf call - Changes: - all: https://git.openjdk.org/jfx/pull/1381/files - new: https://git.openjdk.org/jfx/pull/1381/fil

RFR: 8329820: [Linux] Prefer EGL over GLX

2024-04-06 Thread Thiago Milczarek Sayao
GLX is X only while EGL is need for Wayland and also works with X.org. I know there are limitations on Xorg and I still need to investigate it. GLX replacement for Xorg is not mandatory - this can be further discussed. This is a work in progress and it's on the first step (making it work).

Re: RFR: 8329820: [Linux] Prefer EGL over GLX

2024-04-06 Thread Thiago Milczarek Sayao
On Tue, 2 Apr 2024 11:50:39 GMT, Lukasz Kostyra wrote: >> GLX is X only while EGL is need for Wayland and also works with X.org. >> >> I know there are limitations on Xorg and I still need to investigate it. >> >> GLX replacement for Xorg is not mandatory - this can be further discussed. >>

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-03-24 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v4]

2024-02-26 Thread Thiago Milczarek Sayao
On Tue, 20 Feb 2024 12:16:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-24 Thread Thiago Milczarek Sayao
On Tue, 20 Feb 2024 12:13:31 GMT, Jose Pereda wrote: >> Jose Pereda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add compile-time checks to GdkSeat > > I've just reverted the previous changes, and just applied the touch mask to >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-02-22 Thread Thiago Milczarek Sayao
On Sun, 18 Feb 2024 23:10:12 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-19 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-02-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v20]

2024-02-18 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 94 commits: - Merge branch 'master' into new_ime - Add signals to avoid

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v19]

2024-02-18 Thread Thiago Milczarek Sayao
On Wed, 17 Jan 2024 17:10:24 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2024-01-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v17]

2024-01-17 Thread Thiago Milczarek Sayao
On Tue, 2 Jan 2024 16:58:10 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Add check for jview > > modules/javafx.graphics/src/main/native-glass/gtk/gl

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v19]

2024-01-17 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Add signals to avoid warnings - Changes: - all: https://git.openjdk.org/jfx

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v18]

2024-01-17 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 92 commits: - Merge branch 'master' into new_ime # Conflicts: #

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v17]

2023-12-25 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Add check for jview - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-25 Thread Thiago Milczarek Sayao
On Sat, 16 Dec 2023 23:49:00 GMT, Thiago Milczarek Sayao wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 486: >> >>> 484: CHECK_JNI_EXCEPTION(mainEnv) >>> 485: >>> 486: if (press && key > 0) { // T

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-24 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2023-12-24 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor

2023-12-24 Thread Thiago Milczarek Sayao
On Wed, 6 Sep 2023 16:41:24 GMT, Martin Fox wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> positioning on `InputMethodRequest`. >> >>

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-24 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED

Re: RFR: 8301219: JavaFX crash when closing with the escape key [v3]

2023-12-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 19:15:03 GMT, Martin Fox wrote: >> While processing a key down event the Glass GTK code sends out PRESSED and >> TYPED KeyEvents back to back. If the stage is closed during the PRESSED >> event the code will end up referencing freed memory while sending out the >> TYPED

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v3]

2023-12-23 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 11:19:18 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 21:51:13 GMT, Kevin Rushforth wrote: >> It seems like this is the best we can do for now. What is means is that we >> won't be able to build on a system with 3.8 - 3.19 and distribute a library >> that will use the new functionality when running on 3.20 or later. That's >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 10:29:00 GMT, Thiago Milczarek Sayao wrote: >> Okay, that is unfortunate (GTK docs inaccurate), but makes sense. >> >> I'll add the compile-time checks to `wrapped.c`. But then, using `dlsym` >> seems redundant, as we can simply call the

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 10:20:35 GMT, Jose Pereda wrote: >> I think the docs are wrong, I probably exists since 3.20, so maybe check for >> `GTK_CHECK_VERSION(3, 20, 0);`. >> >> >> This is the compilation error on Ubuntu 16.04: >>

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 09:46:23 GMT, Jose Pereda wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197: >> >>> 195: return TRUE; >>> 196: } >>> 197: return FALSE; >> >> I did try to test on Ubuntu 16.04 and compilation failed (no surprise >> because

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-18 Thread Thiago Milczarek Sayao
On Mon, 18 Dec 2023 09:46:23 GMT, Jose Pereda wrote: >> modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c line 197: >> >>> 195: return TRUE; >>> 196: } >>> 197: return FALSE; >> >> I did try to test on Ubuntu 16.04 and compilation failed (no surprise >> because

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v16]

2023-12-17 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: - Fix comment path - Changes: - all: https://git.openjdk.org/jfx/pull/1

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-17 Thread Thiago Milczarek Sayao
On Wed, 13 Dec 2023 19:09:44 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Account the case of !filtered > > modules/javafx.graphics/src/main/native-glass

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-17 Thread Thiago Milczarek Sayao
On Wed, 13 Dec 2023 19:11:27 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Account the case of !filtered > > modules/javafx.graphics/src/main/native-glass

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v15]

2023-12-16 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: - Fix double keyrelease - Changes: - all: https://git.openjdk.org/jfx

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-16 Thread Thiago Milczarek Sayao
On Wed, 13 Dec 2023 19:22:49 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Account the case of !filtered > > modules/javafx.graphics/src/main/native-glass

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-16 Thread Thiago Milczarek Sayao
On Wed, 13 Dec 2023 19:01:25 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Account the case of !filtered > > modules/javafx.graphics/src/main/

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v14]

2023-12-16 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 88 commits: - - Use a work-around to relative positioning (until wayland is n

Re: RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

2023-12-16 Thread Thiago Milczarek Sayao
On Thu, 14 Dec 2023 20:19:12 GMT, Jose Pereda wrote: >> This PR replaces the deprecated `gdk_pointer_grab` with `gdk_seat_grab`, and >> `gdk_pointer_ungrab ` with `gdk_seat_ungrab`, using runtime checks and >> wrapped functions for GTK 3.20+ (so systems without it still run with GTK >> 3.8+),

Re: RFR: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close) [v3]

2023-12-06 Thread Thiago Milczarek Sayao
en window is disabled and restores it back > when it's re-enabled. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Fix comments - Changes: - all: https://git.openjdk.org/jfx/pull/1278/files - new: htt

Re: RFR: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close) [v2]

2023-12-03 Thread Thiago Milczarek Sayao
On Fri, 3 Nov 2023 10:34:42 GMT, Thiago Milczarek Sayao wrote: >> JavaFX on Linux is allowing disabled windows to be minimized. >> >> Currently close does nothing as it should, maximize disappears (on MS >> Windows it's greyed out - it's a platform behavior

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-12-03 Thread Thiago Milczarek Sayao
On Tue, 28 Nov 2023 23:54:09 GMT, Andy Goryachev wrote: >> Copying and pasting Chinese characters on a JavaFX app on 23.10 is also >> broken, so It seems a problem somewhere else other than IME-related. > >> Copying and pasting Chinese characters on a JavaFX app on 23.10 is also >> broken >

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-11-28 Thread Thiago Milczarek Sayao
On Tue, 28 Nov 2023 22:09:37 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v13]

2023-11-28 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Account the case of !filtered - Changes: - all: https://git.openjdk.org/jfx

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v12]

2023-11-28 Thread Thiago Milczarek Sayao
On Tue, 28 Nov 2023 21:30:38 GMT, Thiago Milczarek Sayao wrote: >> This replaces obsolete XIM and uses gtk api for IME. >> Gtk uses [ibus](https://github.com/ibus/ibus) >> >> Gtk3+ uses relative positioning (as Wayland does), so I've added a Relative >> posi

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v10]

2023-11-28 Thread Thiago Milczarek Sayao
On Tue, 28 Nov 2023 20:38:25 GMT, Martin Fox wrote: >> Thiago Milczarek Sayao has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make it a default method for compatibility > > modules/javafx.graphics/src/

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v12]

2023-11-28 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Fix change of focus when on preedit + add filter on key release -

Re: RFR: 8305418: [Linux] Replace obsolete XIM as Input Method Editor [v11]

2023-11-28 Thread Thiago Milczarek Sayao
webm](https://github.com/openjdk/jfx/assets/30704286/6c398e39-55a3-4420-86a2-beff07b549d3) Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 84 commits: - Merge branch 'master' into new_ime - Remove unused include -

Re: RFR: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close) [v2]

2023-11-16 Thread Thiago Milczarek Sayao
On Fri, 3 Nov 2023 10:34:42 GMT, Thiago Milczarek Sayao wrote: >> JavaFX on Linux is allowing disabled windows to be minimized. >> >> Currently close does nothing as it should, maximize disappears (on MS >> Windows it's greyed out - it's a platform behavior

Integrated: 8319341: [Linux] Remove operation to show or hide children because it is unnecessary

2023-11-15 Thread Thiago Milczarek Sayao
On Thu, 2 Nov 2023 19:49:52 GMT, Thiago Milczarek Sayao wrote: > Observed that the window manager takes care of showing and hiding children > because we set `gtk_window_set_transient_for`. > > Works since Ubuntu 16.04. > > This PR removes the code to show or hid

Integrated: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown

2023-11-04 Thread Thiago Milczarek Sayao
On Thu, 28 Sep 2023 00:31:59 GMT, Thiago Milczarek Sayao wrote: > The bug on the title happens because `gtk_widget_realize()` was called on the > constructor. It creates the internal underlying window `GdkWindow` and > `XWindow` messing the Gtk expected order. It's probably a Mutt

Re: RFR: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close) [v2]

2023-11-03 Thread Thiago Milczarek Sayao
en window is disabled and restores it back > when it's re-enabled. Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision: Leave the Close button so it does not look too weird. - Changes: - all: https://git.openjdk

RFR: 8319341: [Linux] Remove operation to show or hide children because it is unnecessary

2023-11-02 Thread Thiago Milczarek Sayao
Observed that the window manager takes care of showing and hiding children because we set `gtk_window_set_transient_for`. Works since Ubuntu 16.04. This PR removes the code to show or hide children because it "duplicates" the operation and might lead to unknown bugs. - Commit

RFR: 8319340: [Linux] Disabled windows should not allow window operations (minimize, resize, maximize, close)

2023-11-02 Thread Thiago Milczarek Sayao
JavaFX on Linux is allowing disabled windows to be minimized. Currently close does nothing as it should, maximize disappears (on MS Windows it's greyed out - it's a platform behavior difference) and minimize is being allowed. Thins PR removes WM functions when window is disabled and restores

Re: RFR: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v7]

2023-10-24 Thread Thiago Milczarek Sayao
On Sun, 15 Oct 2023 13:25:15 GMT, Thiago Milczarek Sayao wrote: >> The bug on the title happens because `gtk_widget_realize()` was called on >> the constructor. It creates the internal underlying window `GdkWindow` and >> `XWindow` messing the Gtk expected order. It's

Re: RFR: 8316423: [linux] Secondary Stage does not respect Scene's dimensions when shown [v8]

2023-10-24 Thread Thiago Milczarek Sayao
g on > Mutter [filed here](https://gitlab.gnome.org/GNOME/mutter/-/issues/3092). > > I could work-around it on this situation, but it would still happen on later > focus request. Thiago Milczarek Sayao has updated the pull request with a new target base due to a merge or a rebase. The incr

  1   2   3   4   5   >