On Thu, 7 Dec 2023 21:30:27 GMT, Michael Strauß wrote:
>> The value does indeed change:
>> macOS.NSColor.alternatingContentBackgroundColors = [0x1e1e1eff,0xff0c]
>> macOS.NSColor.alternatingContentBackgroundColors = [0x,0xf4f5f5ff]
>>
>>
>> private String f(Object x) {
>>
On Thu, 7 Dec 2023 17:28:25 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
>> 611:
>>
>>> 609:
>>> 610: /**
>>> 611: * The accent color.
>>
>> I think that this needs to explanation on what the accent color is.
>
>
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 21:48:46 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> fixed bug in test application
>
> The value does indeed change:
> macOS.NSColor.alternatingContentBackgroundColors
On Sun, 29 Jan 2023 01:33:48 GMT, Michael Strauß wrote:
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appeara
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 18:30:24 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/javafx/application/WindowsHighContrastScheme.java
>> line 43:
>>
>>> 41: * The high contrast feature may not be available on all platforms.
>>> 42: */
>>> 43: enum
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 18:17:58 GMT, Jose Pereda wrote:
>> Michael Strauß has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - removed unused import
>> - javadoc
>> - query resource bundles for high-contrast schemes only on Windows
>
>
On Thu, 7 Dec 2023 17:21:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 08:04:45 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
>
On Thu, 7 Dec 2023 08:45:43 GMT, Nir Lisker wrote:
> There are classes such as `PlatformPreferences`, `PreferenceProperties`, and
> `ColorSchemeProperty` that are effectively singletons. Does it makes sense to
> just write them in a singleton pattern to avoid misuse?
If we add user-modifiable
On Thu, 7 Dec 2023 15:24:11 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
>
On Thu, 7 Dec 2023 16:12:21 GMT, Jose Pereda wrote:
> Windows high contrast seems to work fine now.
>
> However, I'm building your PR (./gradlew sdk) and running the test on Mac,
> but I get:
>
> ```
> Exception in Application start method
> java.lang.reflect.InvocationTargetException
> ...
On Thu, 7 Dec 2023 15:43:48 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/application/ColorScheme.java
>> line 35:
>>
>>> 33: * @since 22
>>> 34: */
>>> 35: public enum ColorScheme {
>>
>> Can there be future additions to this enum, or is its purpose to be
On Thu, 7 Dec 2023 05:49:07 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 07:57:01 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> renamed Windows.SPI.HighContrastOn to Windows.SPI.HighContrast
>
>
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 7 Dec 2023 01:05:44 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 19:46:50 GMT, Jose Pereda wrote:
> Note I get the preference `Windows.SPI.HighContrastOn`, which is not listed
> in the javadoc of `javafx.application.Platform.Preferences`, but I don't get
> these two preferences which are listed:
>
> ```
> Windows.SPI.HighContrast
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Thu, 7 Dec 2023 00:44:39 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 21:44:26 GMT, Andy Goryachev wrote:
> minor: it's impossible to see the actual values for arrays:
>
> ` macOS.NSColor.alternatingContentBackgroundColors =
> [Ljavafx.scene.paint.Color;@55c22d31`
I added formatting for arrays.
-
PR Comment:
On Wed, 6 Dec 2023 19:46:50 GMT, Jose Pereda wrote:
> So I guess we'll need to review this `HighContrastScheme` enum, and see why
> `HighContrastScheme::fromThemeName` is not used.
At some point, the call to `HighContrastScheme::fromThemeName` was lost. I've
added it back in and discovered an
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 6 Dec 2023 21:31:36 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 21:31:36 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 21:36:00 GMT, Michael Strauß wrote:
> > * invert colors
> > * increase contrast
> > * display contrast (this seems to affect display's gamma, so probably not)
>
> These options are more like a post-processing effect of macOS, they don't
> affect the actual values of system
On Wed, 6 Dec 2023 19:59:19 GMT, Andy Goryachev wrote:
> macOS again, System Settings -> Accessibility -> Display
>
> should an update be sent when changing
>
> * invert colors
> * increase contrast
> * display contrast (this seems to affect display's gamma, so probably not)
>
These options
On Wed, 6 Dec 2023 20:38:46 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 6 Dec 2023 20:38:46 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 19:59:25 GMT, Kevin Rushforth wrote:
>> Yes. This is the copy-and-swap idiom, where the copy is made by using a
>> pass-by-value parameter.
>
> I see.
>
> I did happen to spot this compiler warning while compiling:
>
>
> .../VC/bin/x64/cl.exe /nologo /W3 /EHsc /c
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 6 Dec 2023 01:02:55 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/win/RoActivationSupport.cpp
>> line 213:
>>
>>> 211: RoException& RoException::operator=(RoException source)
>>> 212: {
>>> 213: std::swap(*this, source);
>>
>> Did you mean to do the
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Wed, 6 Dec 2023 19:23:38 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 6 Dec 2023 18:13:42 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - null checking
>> - rename GLASS_CHECK_EXCEPTIONALLY_RETURN
>
>
On Mon, 20 Nov 2023 19:24:03 GMT, Andy Goryachev wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Support polymorphic values
>
> I feel that the gist mentioned in the description
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 6 Dec 2023 00:52:32 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Tue, 5 Dec 2023 23:26:11 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> check return value of JNI functions
>
> modules/javafx.graphics/src/main/native-glass/win/RoActivationSupport.cpp
On Tue, 5 Dec 2023 23:32:41 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> check return value of JNI functions
>
> modules/javafx.graphics/src/main/native-glass/mac/GlassMacros.h line 178:
On Mon, 4 Dec 2023 22:05:53 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> check for pending exceptions in Windows PlatformSupport
>
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Sat, 2 Dec 2023 01:43:52 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Mon, 4 Dec 2023 23:55:33 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Mon, 4 Dec 2023 21:57:23 GMT, Kevin Rushforth wrote:
> I left comments about the NULL checks. I'll review the changes you made plus
> the files I haven't reviewed yet.
I've added the suggested null checks for all New* JNI functions, as well as for
`gtk_style_new`.
-
PR
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Sat, 2 Dec 2023 00:58:28 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line
>> 68:
>>
>>> 66: jobject PlatformSupport::collectPreferences() const {
>>> 67: jobject prefs = env->NewObject(jHashMapCls, jHashMapInit);
>>> 68: if
On Sat, 2 Dec 2023 01:43:52 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Thu, 30 Nov 2023 23:38:18 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line
>
On Thu, 30 Nov 2023 23:36:38 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/win/GlassApplication.cpp line
>
On Sat, 2 Dec 2023 00:24:36 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 30 Nov 2023 22:54:02 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> initialize field with NULL
>
> modules/javafx.graphics/src/main/native-glass/gtk/PlatformSupport.cpp line 68:
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Thu, 30 Nov 2023 01:38:13 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Thu, 30 Nov 2023 01:38:13 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Wed, 29 Nov 2023 22:03:49 GMT, Kevin Rushforth wrote:
> I did a quick test instrumenting the destructor with print statements, and
> I'm pretty sure I know why it's crashing. You don't initialize `preferences`
> in the constructor, so the null check in the destructor is reading
>
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Fri, 24 Nov 2023 21:57:04 GMT, John Hendrikx wrote:
>> I don't understand. This is an overridden method, do you propose to
>> introduce another `private static final` method, and
>> `getPlatformKeyMappings` then calls out to this other method?
>
> I meant that it is a constant, which I
On Fri, 24 Nov 2023 19:26:05 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Fri, 24 Nov 2023 18:07:01 GMT, Michael Strauß wrote:
>> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line
>> 793:
>>
>>> 791: * Returns a mapping of platform-specific keys to the types of
>>> their values.
>>> 792: * Polymorphic types are supported by
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Fri, 24 Nov 2023 11:41:30 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> flip S and T
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/Application.java line
> 770:
>
>> 768:
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Fri, 24 Nov 2023 05:36:07 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Mon, 20 Nov 2023 19:12:25 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Mon, 20 Nov 2023 19:12:25 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Sat, 18 Nov 2023 17:07:43 GMT, Nir Lisker wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove Preferences.getPaint
>
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/gtk/GtkApplication.java
> line
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Sat, 18 Nov 2023 16:31:58 GMT, Michael Strauß wrote:
> I've updated the CSR.
I reviewed the CSR. You might wait a couple days to see if anyone else has
further comments on the API docs before finalizing it, but it is otherwise
ready.
-
PR Comment:
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Sat, 18 Nov 2023 15:22:10 GMT, Kevin Rushforth wrote:
> The latest API changes looks good. If you update the CSR, I'll formally
> review it.
>
> In parallel, I'll finish my review and testing of the implementation.
I've updated the CSR.
-
PR Comment:
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Sat, 18 Nov 2023 05:50:35 GMT, Michael Strauß wrote:
>> Please read [this
>> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548)
>> for an introduction to the Platform Preferences API, and how it interacts
>> with the proposed style theme and s
On Fri, 17 Nov 2023 19:03:16 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename Appearance to ColorScheme
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Fri, 17 Nov 2023 19:43:58 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename Appearance to ColorScheme
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
On Fri, 17 Nov 2023 19:20:32 GMT, Kevin Rushforth wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Rename Appearance to ColorScheme
>
> modules/javafx.graphics/src/main/java/javafx/application/Platform.java line
> Please read [this
> document](https://gist.github.com/mstr2/9f46f92c98d3c86aa6a0b4224a9a6548) for
> an introduction to the Platform Preferences API, and how it interacts with
> the proposed style theme and stage appearance features.
Michael Strauß has updated the pull request i
1 - 100 of 273 matches
Mail list logo
