> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property is being set by the code which computes the actual text
> string to be displayed (and which inserts
On Mon, 6 May 2024 14:50:00 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
>> line 221:
>>
>>> 219: OverrunStyle type,
>>> 220: String ellipsisString,
>>> 221: AtomicBoolean textTruncated
>>
>> I
On Sat, 4 May 2024 14:05:19 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/skin/Utils.java
> line 221:
>
On Fri, 3 May 2024 21:00:26 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Sat, 4 May 2024 14:17:16 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> whitespace
>
> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line
> 855:
>
>> 853:
On Fri, 3 May 2024 21:00:26 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
On Fri, 3 May 2024 21:00:26 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property is being set by the code which computes
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property is being set by the code which computes the actual text
> string to be displayed (and which inserts
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property is being set by the code which computes the actual text
> string to be displayed (and which inserts
On Fri, 3 May 2024 13:19:17 GMT, Kevin Rushforth wrote:
> Would it be possible to set the value of the truncated property at the point
> where truncation occurs?
yes, `LabeledSkinBase.updateDisplayedText()` determines whether the text is
truncated or not.
-
PR Review Comment:
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Thu, 2 May 2024 22:10:24 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Thu, 2 May 2024 18:21:52 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Thu, 2 May 2024 18:34:04 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/Labeled.java line
>> 114:
>>
>>> 112: * by itself looks rather weird.
>>> 113: */
>>> 114: private static boolean useActualContentWidth;
>>
>> Even given your
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Thu, 2 May 2024 17:37:52 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Thu, 2 May 2024 18:07:12 GMT, Kevin Rushforth wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - missing )
>> - review comments
>> - Merge branch 'master' into 8092102.truncated
>>
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:25:10 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Wed, 10 Apr 2024 21:28:16 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java
>> line 38:
>>
>>> 36: /**
>>> 37: * Returns true when the Labeled must compute the actual
>>> content width in computePrefWidth().
On Wed, 10 Apr 2024 09:03:33 GMT, Karthik P K wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> add exports
>
> modules/javafx.controls/src/main/java/com/sun/javafx/scene/control/LabeledHelper.java
> line 38:
>
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Thu, 28 Mar 2024 21:44:49 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
On Thu, 28 Mar 2024 21:44:49 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Wed, 27 Mar 2024 21:54:37 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Fri, 15 Mar 2024 09:43:26 GMT, Marius Hanl wrote:
>> Okay.
>>
>> Tests: Well, there are some properties we can test here:
>> - wrapText = true -> height should be used -> check truncated
>> - width changed -> check truncated
>> - text changed -> check truncated
>
> You can check here how I
On Tue, 12 Mar 2024 15:50:21 GMT, Andy Goryachev wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableCellSkin.java
>> line 133:
>>
>>> 131: protected double computePrefWidth(double height, double topInset,
>>> double rightInset, double bottomInset,
>>> 132:
On Fri, 15 Mar 2024 09:41:25 GMT, Marius Hanl wrote:
>> Thank you for the feedback!
>>
>> The property is being added to Labeled, which happens to be a base class for
>> the cells' skins. The truncated property therefore must work in all the
>> subclasses, even those where computePrefWidth
On Mon, 11 Mar 2024 22:03:49 GMT, Marius Hanl wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> labeled helper
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TreeTableCellSkin.java
> line
On Fri, 8 Mar 2024 21:08:25 GMT, Andy Goryachev wrote:
>> Adds **Labeled.textTruncated** property which indicates when the text is
>> visually truncated (and the ellipsis string is inserted) in order to fit the
>> available width.
>>
>> The new property reacts to changes in the following
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Tue, 5 Mar 2024 14:16:59 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>>
> Adds **Labeled.textTruncated** property which indicates when the text is
> visually truncated (and the ellipsis string is inserted) in order to fit the
> available width.
>
> The new property reacts to changes in the following properties:
> - ellipsisString
> - font
> - height
> - text
> -
On Tue, 5 Mar 2024 14:59:20 GMT, Nir Lisker wrote:
> This enhancement should be discussed in the mailing list. I've never needed
> this myself, but it already had an old JBS ticket, so I can see that others
> did and for a legitimate reason (adding tooltips). I don't mind if it's added
> or
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> -
On Tue, 5 Mar 2024 09:52:37 GMT, Karthik P K wrote:
> Do you think change in `labelPaddingProperty`or `graphicProperty` should also
> trigger check
good question! a change in these properties gets handled correctly - no need
to add explicit binding.
-
PR Comment:
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> -
On Mon, 4 Mar 2024 21:04:28 GMT, Andy Goryachev wrote:
> Adds Labeled.truncated property which indicates when the text is visually
> truncated (and the ellipsis string is inserted) in order to fit the available
> width.
>
> The new property reacts to changes in the following properties:
> -
Adds Labeled.truncated property which indicates when the text is visually
truncated (and the ellipsis string is inserted) in order to fit the available
width.
The new property reacts to changes in the following properties:
- ellipsisString
- font
- text
- width
- wrapText
For some reason, line
51 matches
Mail list logo
