Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v4]

2023-02-24 Thread Kevin Rushforth
On Fri, 24 Feb 2023 22:28:08 GMT, Phil Race wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v4]

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 22:23:18 GMT, Phil Race wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v3]

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 22:03:59 GMT, Kevin Rushforth wrote: >> Phil Race has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8290866 > > tests/manual/text/EmojiTest.java line 54: > >> 52: transparent background pixels. >> 53:

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v4]

2023-02-24 Thread Phil Race
> This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is provided which uses a Text node, Label control > and

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v3]

2023-02-24 Thread Kevin Rushforth
On Fri, 24 Feb 2023 19:58:50 GMT, Phil Race wrote: >> or check for null again after synchronized(this) > > It doesn't matter, does it ? In that one in a million case we'd just build > the tables twice. OK - PR: https://git.openjdk.org/jfx/pull/1047

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v3]

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 21:21:54 GMT, Phil Race wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v3]

2023-02-24 Thread Kevin Rushforth
On Fri, 24 Feb 2023 21:21:54 GMT, Phil Race wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v3]

2023-02-24 Thread Phil Race
> This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is provided which uses a Text node, Label control > and

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v2]

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 20:31:47 GMT, Phil Race wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18 [v2]

2023-02-24 Thread Phil Race
> This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is provided which uses a Text node, Label control > and

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 19:28:49 GMT, Andy Goryachev wrote: >> modules/javafx.graphics/src/main/java/com/sun/javafx/font/PrismFontFile.java >> line 1456: >> >>> 1454:private boolean isSbixGlyph(int glyphID) { >>> 1455:if (sbixStrikes == null) { >>> 1456:synchronized (this)

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 18:58:37 GMT, Kevin Rushforth wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 19:17:08 GMT, Andy Goryachev wrote: > > app works with no clipping on macOS 12.6.1 > > clipping occurs on retina at any resolution, from "Larger Text" to "More > Space". It might be specific to Ventura, and possibly to the flag emojis. I > tried to paste random code

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 19:06:59 GMT, Kevin Rushforth wrote: >> This fix properly supports colour rendering of Emoji on macOS >> >> >> On other platforms the Emoji will be rendered as ordinary greyscale glyphs - >> if there is font >> support for the requested code point. >> >> A simple manual

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Kevin Rushforth
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote: > This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 19:10:23 GMT, Phil Race wrote: > app works with no clipping on macOS 12.6.1 clipping occurs on retina at any resolution, from "Larger Text" to "More Space". It might be specific to Ventura, and possibly to the flag emojis. I tried to paste random code blocks, see no

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 18:57:54 GMT, Andy Goryachev wrote: > > So I suspect something specific to what you are doing in your test .. not a > > general emoji problem. > > or specific to my Mac Ventura 13.1. In my test, i am setting the font > explicitly. A simpler test clips the flag symbols on

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Fri, 24 Feb 2023 18:48:20 GMT, Phil Race wrote: > So I suspect something specific to what you are doing in your test .. not a > general emoji problem. or specific to my Mac Ventura 13.1. In my test, i am setting the font explicitly. A simpler test clips the flag symbols on both retina

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote: > This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 16:50:05 GMT, Andy Goryachev wrote: > Another question: on non-retina monitor, emojis appear blurry when text size > is set to 12. I vaguely recall that when resizing down, the resizing > operation might be followed by a sharpening filter (or perhaps some other op > can be

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Phil Race
On Fri, 24 Feb 2023 16:44:35 GMT, Andy Goryachev wrote: > I see some clipping of the emoji flag sequence characters, for example > \ud83c\uddfa\ud83c\udde6 when moving from the primary retina (scale=2) to > secondary external (scale=1) monitor: I tried the same size and sequence and in the

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote: > This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is

Re: RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-24 Thread Andy Goryachev
On Thu, 23 Feb 2023 20:43:29 GMT, Phil Race wrote: > This fix properly supports colour rendering of Emoji on macOS > > > On other platforms the Emoji will be rendered as ordinary greyscale glyphs - > if there is font > support for the requested code point. > > A simple manual test is

RFR: 8290866: Apple Color Emoji turns gray after JavaFX version 18

2023-02-23 Thread Phil Race
This fix properly supports colour rendering of Emoji on macOS On other platforms the Emoji will be rendered as ordinary greyscale glyphs - if there is font support for the requested code point. A simple manual test is provided which uses a Text node, Label control and editable TextField