On Sat, 24 Feb 2024 09:53:01 GMT, Nir Lisker wrote:
> Backport of commit
> [b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b)
> from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
I note that this is a clean backport of a doc-only fix.
Backport of commit
[b43c4edf](https://github.com/openjdk/jfx/commit/b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b)
from the [openjdk/jfx](https://git.openjdk.org/jfx) repository.
-
Commit messages:
- Backport b43c4edf7590429fd051d1b0e2ccb6dd49a10b8b
Changes:
On Fri, 23 Feb 2024 22:32:23 GMT, Andy Goryachev wrote:
>> `@return` statements usually state this condition explicitly, like
>> `Map#get`: "the value to which the specified key is mapped, or `null` if
>> this map contains no mapping for the key".
>
> My point is that it should be mentioned in
On Fri, 23 Feb 2024 22:32:16 GMT, Nir Lisker wrote:
>> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs
>> in `Node` and `Scene`.
>>
>> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
>> system property, while for `Node` it isn't (which
On Fri, 23 Feb 2024 22:32:16 GMT, Nir Lisker wrote:
>> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs
>> in `Node` and `Scene`.
>>
>> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
>> system property, while for `Node` it isn't (which
On Fri, 23 Feb 2024 22:28:59 GMT, Nir Lisker wrote:
> Only `Scene` has the RTL system property checked.
I suppose because Scene must INHERIT this value from the system?
-
PR Comment: https://git.openjdk.org/jfx/pull/1379#issuecomment-1962094000
On Fri, 23 Feb 2024 21:58:30 GMT, Nir Lisker wrote:
>> I don't mind either way.
>
> `@return` statements usually state this condition explicitly, like `Map#get`:
> "the value to which the specified key is mapped, or `null` if this map
> contains no mapping for the key".
My point is that it
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote:
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn't (which means
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn't (which means `SubScene` will be
> different from `Scene`). Not sure
On Fri, 23 Feb 2024 19:38:20 GMT, Kevin Rushforth wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/layout/AnchorPane.java
>> line 187:
>>
>>> 185: * Returns the child's bottom anchor constraint, if set.
>>> 186: * @param child the child node of an anchor pane
>>> 187:
On Fri, 23 Feb 2024 20:16:55 GMT, Nir Lisker wrote:
> I suggest to move the doc to the field.
Yeah that's even better.
-
PR Review Comment: https://git.openjdk.org/jfx/pull/1379#discussion_r1501132703
On Fri, 23 Feb 2024 19:44:06 GMT, Andy Goryachev wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 6272:
>>
>>> 6270: * of text in both worlds.
>>> 6271: *
>>> 6272: * @defaultValue if the system property {@code
>>> javafx.scene.nodeOrientation.RTL} is
On Fri, 23 Feb 2024 19:34:41 GMT, Kevin Rushforth wrote:
>> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs
>> in `Node` and `Scene`.
>>
>> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
>> system property, while for `Node` it isn't
On Fri, 23 Feb 2024 18:31:10 GMT, Andy Goryachev wrote:
>> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs
>> in `Node` and `Scene`.
>>
>> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
>> system property, while for `Node` it isn't (which
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote:
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn't (which means
On Fri, 23 Feb 2024 17:46:20 GMT, Nir Lisker wrote:
> Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
> `Node` and `Scene`.
>
> Note that the default value for a `Scene`'s `NodeOrientation` depends on a
> system property, while for `Node` it isn't (which means
Fixes for the `AnchorPane` docs, as well as for the `NodeOrientation` docs in
`Node` and `Scene`.
Note that the default value for a `Scene`'s `NodeOrientation` depends on a
system property, while for `Node` it isn't (which means `SubScene` will be
different from `Scene`). Not sure if this is
17 matches
Mail list logo
