On Tue, 19 Mar 2024 22:31:33 GMT, Andy Goryachev wrote:
>> Changing `Util.shutdown()` to hide **all** showing Windows and then call
>> `Platform.exit()`.
>> This simplifies the tests and ensures a clean shutdown.
>
> Andy Goryachev has updated the pull request incrementally with one additional
On Tue, 19 Mar 2024 22:34:17 GMT, Nir Lisker wrote:
>> The only issue with this style is - it's hard to set breakpoints.
>> In this case it's not that important.
>> Thank you!
>
> It's a matter of style mostly, so I don't really mind it. The debug issue can
> be remedied by adding breakpoints
On Tue, 19 Mar 2024 22:28:54 GMT, Andy Goryachev wrote:
>> tests/system/src/test/java/test/util/Util.java line 383:
>>
>>> 381: runAndWait(() -> {
>>> 382: for (Window w : new ArrayList<>(Window.getWindows())) {
>>> 383: w.hide();
>>
>> I think you can use
On Tue, 19 Mar 2024 22:23:46 GMT, Nir Lisker wrote:
>> Andy Goryachev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> for each
>
> tests/system/src/test/java/test/util/Util.java line 383:
>
>> 381: runAndWait(() -> {
>> 382:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
Andy Goryachev has updated the pull request incrementally with one additional
commit since the last revision:
for each
-
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
tests/system/src/test/java/test/util/Util.java line 383:
> 381:
On Mon, 18 Mar 2024 22:53:03 GMT, Andy Goryachev wrote:
> Changing `Util.shutdown()` to hide **all** showing Windows and then call
> `Platform.exit()`.
> This simplifies the tests and ensures a clean shutdown.
Looks good.
-
Marked as reviewed by kcr (Lead).
PR Review:
