On Thu, 28 Mar 2024 09:05:00 GMT, Karthik P K wrote:
> Leaving it unspecified would be ok but some kind of soft recommendation could
> also help in my opinion. So there will be a direction for someone who is
> looking for a recommended way to add imports and have consistency class files.
This
On Wed, 27 Mar 2024 14:51:35 GMT, Andy Goryachev wrote:
> I would highly suggest to use the current guidelines in CONTRIBUTING.md
>
> ```
> * Don't worry too much about import order. Try not to change it but don't
> worry about fighting your IDE to stop it from doing so.
> ```
Since this is
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Tue, 26 Mar 2024 16:32:41 GMT, Kevin Rushforth wrote:
> static imports (sorted alphabetically)
> one blank line
> ordinary imports (sorted alphabetically)
>
> No wildcard imports (I favor an exception for static imports).
+1 for something like this. It is a simple rule and pretty sure that
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Tue, 26 Mar 2024 16:49:58 GMT, Kevin Rushforth wrote:
> 1. Should we have at least a soft recommendation or leave it unspecified?
I would rather leave it unspecified.
My concern is that different IDEs might have different sort orders by defaul
(now or in the future) and then we have a
On Tue, 26 Mar 2024 16:38:07 GMT, Andy Goryachev wrote:
> > We should replace this with the recommended sort order.
>
> My 2 cents would be on the other side: I would strongly recommend **against**
> enforcing a specific order, especially since it causes no issues. We should
> avoid
On Tue, 26 Mar 2024 16:32:41 GMT, Kevin Rushforth wrote:
> We should replace this with the recommended sort order.
My 2 cents would be on the other side: I would strongly recommend **against**
enforcing a specific order, especially since it causes no issues. We should
avoid wildcards, yes
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
On Tue, 26 Mar 2024 16:16:37 GMT, Kevin Rushforth wrote:
>> this is how the IDE formatter is currently configured - it should not
>> matter, especially since it dos not use wildcards (except for static
>> imports).
>
> While it doesn't matter from a correctness point of view, if we are going
On Thu, 21 Mar 2024 22:35:22 GMT, Andy Goryachev wrote:
>> apps/samples/Ensemble8/src/app/java/ensemble/samplepage/Description.java
>> line 55:
>>
>>> 53: import ensemble.SampleInfo;
>>> 54: import ensemble.SampleInfo.URL;
>>> 55: import ensemble.generated.Samples;
>>
>> I see that
On Thu, 21 Mar 2024 22:23:44 GMT, Kevin Rushforth wrote:
>> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
>> etc.) and update the copyright year to 2024. Using wildcard for more than 10
>> static imports.
>>
>>
>> --
>>
>> This is a trivial change (though fairly
On Thu, 21 Mar 2024 21:50:37 GMT, Andy Goryachev wrote:
> Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
> etc.) and update the copyright year to 2024. Using wildcard for more than 10
> static imports.
>
>
> --
>
> This is a trivial change (though fairly large),
Using Eclipse IDE to remove unused imports in **demo apps** (3D, Ensemble,
etc.) and update the copyright year to 2024. Using wildcard for more than 10
static imports.
--
This is a trivial change (though fairly large), 1 reviewer is probably enough.
-
Commit messages:
-
17 matches
Mail list logo
