Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v6]

2024-03-11 Thread Kevin Rushforth
On Sat, 9 Mar 2024 13:42:55 GMT, John Hendrikx wrote: >> modules/javafx.graphics/src/main/java/javafx/css/StyleClass.java line 32: >> >>> 30: * @deprecated for removal >>> 31: */ >>> 32: public final class StyleClass { >> >> Needs the `@Deprecated(forRemoval = true)` annotation on the class,

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v6]

2024-03-09 Thread John Hendrikx
On Sat, 9 Mar 2024 12:35:22 GMT, Nir Lisker wrote: >> John Hendrikx has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Remove commented code in BitSetTest >> - Remove unnecessary addAll overrides > >

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v6]

2024-03-09 Thread Nir Lisker
On Sat, 9 Mar 2024 06:48:25 GMT, John Hendrikx wrote: >> Improves performance of selector matching in the CSS subsystem. This is done >> by using custom set implementation which are highly optimized for the most >> common cases where the number of selectors is small (most commonly 1 or 2). >>

Re: RFR: JDK-8322964 Optimize performance of CSS selector matching [v6]

2024-03-08 Thread John Hendrikx
> Improves performance of selector matching in the CSS subsystem. This is done > by using custom set implementation which are highly optimized for the most > common cases where the number of selectors is small (most commonly 1 or 2). > It also should be more memory efficient for medium sized