On Sat, 1 Apr 2023 22:14:09 GMT, John Hendrikx wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> addressed review comments, added tests
>
> Looks really good now!
@hjohn Can you re-approve?
-
PR
On Tue, 4 Apr 2023 23:27:38 GMT, Kevin Rushforth wrote:
> I started doing some testing today.
Thank you, Kevin. I'm almost done with another round of my own testing and will
post my results, too.
> 2. The format of `VersionInfo.BUILD_TIMESTAMP`, which is used in constructing
> the
On Tue, 4 Apr 2023 08:35:52 GMT, Jose Pereda wrote:
>> @jperedadnr You set up the test correctly. I think you need to need to allow
>> the 'terminal' application to use the accessibility API so the Java robot
>> can send keyboard events. I can't provide you with the exact setting since
>> I'm
On Tue, 4 Apr 2023 15:46:20 GMT, John Neffenger wrote:
>> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
>> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
>> example, the following commands create a reproducible build:
>>
>>
>> $ export
On Tue, 4 Apr 2023 21:29:19 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text -
On Tue, 4 Apr 2023 20:45:42 GMT, Kevin Rushforth wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix up Thai font name
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/font/coretext/CTFactory.java
> line 59:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
> glyphs from another font.
> The root of this issue
On Tue, 4 Apr 2023 21:15:03 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text -
On Tue, 4 Apr 2023 18:17:55 GMT, Andy Goryachev wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> formatting and make some fields private
>
>
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
> glyphs from another font.
> The root of this issue
On Tue, 4 Apr 2023 20:47:09 GMT, Phil Race wrote:
>> This PR addresses some font problems on macOS.
>> (1) Garbled Arabic with the System font
>> (2) Non-ideal fallback fonts for all fonts
>> (3) No bold for System font.
>>
>> In particular the standard System Font was garbling Arabic text -
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
> glyphs from another font.
> The root of this issue
On Tue, 4 Apr 2023 18:49:41 GMT, Andy Goryachev wrote:
> Thai does not render for me on Ventura 13.3/M1
>
> 
On macOS 12 Thai uses Thonburi from
On Fri, 24 Mar 2023 21:37:16 GMT, Phil Race wrote:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
On Fri, 24 Mar 2023 21:37:16 GMT, Phil Race wrote:
> This PR addresses some font problems on macOS.
> (1) Garbled Arabic with the System font
> (2) Non-ideal fallback fonts for all fonts
> (3) No bold for System font.
>
> In particular the standard System Font was garbling Arabic text - random
On Mon, 3 Apr 2023 22:55:02 GMT, Andy Goryachev wrote:
> > You mention "Thai" amongst them .. but I do see Thai rendered ..
>
> Thai is not rendered for me, was Ventura 13.1, now Ventura 13.3 on Mac M1,
> (left - ventura 13.1 with the earlier commit, right - unpatched master)
So no worse off
> This pull request allows for reproducible builds of JavaFX on Linux, macOS,
> and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For
> example, the following commands create a reproducible build:
>
>
> $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct)
> $ bash gradlew
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote:
> Issue: Error copying file (if different) from
> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
> to
> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
>
> Root
On Tue, 28 Mar 2023 02:08:27 GMT, Jay Bhaskar wrote:
> Issue: Error copying file (if different) from
> Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_header.py"
> to
> "modules/javafx.web/build/mac/Release/JavaScriptCcripts/builtins_generate_separate_header.py".
>
> Root
On Fri, 31 Mar 2023 07:57:11 GMT, Hima Bindu Meda wrote:
> In Jenkins Build, the intermediate failure on windows is observed due to
> crash in mspdbserv.exe, which generates Program database (.pdb) files.
> Disabled the pdb file generation in order to resolve the build failure.
> Sanity testing
On Mon, 3 Apr 2023 18:50:57 GMT, Hima Bindu Meda wrote:
>> In Jenkins Build, the intermediate failure on windows is observed due to
>> crash in mspdbserv.exe, which generates Program database (.pdb) files.
>> Disabled the pdb file generation in order to resolve the build failure.
>> Sanity
On Fri, 24 Feb 2023 10:04:48 GMT, Dean Wookey wrote:
>> Each time a menu would change scenes, a new set of ListChangeListeners would
>> be added to the items in the menu. The bigger problem however is that these
>> list change listeners have a strong reference to the scene which is
>>
On Sun, 2 Apr 2023 23:50:15 GMT, Michael Strauß wrote:
>> `Observable{List/Set/Map}Wrapper.retainAll/removeAll` can be optimized for
>> some edge cases.
>>
>> 1. `removeAll(c)`:
>> This is a no-op if 'c' is empty.
>> For `ObservableListWrapper`, returning early skips an object allocation. For
On Tue, 4 Apr 2023 09:31:12 GMT, John Hendrikx wrote:
>> I think I am missing something :)
>>
>> The set that is passed in may indeed be immutable, but it may not be the set
>> we have cached. The memory savings only work when I then return the cached
>> set; if I return the set you pass in
On Tue, 4 Apr 2023 09:26:21 GMT, John Hendrikx wrote:
>> Couldn't you just add a fast path by calculating the hash code of the
>> immutable set eagerly and storing it in a field? This entire method could
>> probably be written to be allocation-free if the set passed into the method
>> is
On Mon, 3 Apr 2023 23:36:32 GMT, Michael Strauß wrote:
>> I don't think there is much of an impact, scene graph size should not affect
>> it. The sets involved are tiny, usually consisting of 1 or 2 items and very
>> rarely 3 or possibly more(*). The hash code of `PseudoClass` is very fast,
On Mon, 3 Apr 2023 22:55:16 GMT, Martin Fox wrote:
>> tests/manual/events/KeyboardTest.java line 79:
>>
>>> 77: */
>>> 78:
>>> 79: public class KeyboardTest extends Application {
>>
>> Could you clarify how to run the test and what one should expect?
>>
>> In my case, I'm running from Mac,
27 matches
Mail list logo
