Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh Ack Thanks Lennart > -Original Message- > From: Canh Van Truong [mailto:canh.v.tru...@dektech.com.au] > Sent: den 25 april 2017 15:29 > To: Lennart Lund ; Vu Minh Nguyen > ; mahesh.va...@oracle.com > Cc:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Vu, ACK. not tested. -AVM On 4/28/2017 1:27 PM, Vu Minh Nguyen wrote: > Hi Mahesh, > > Regarding your suggestion, I think we should do it in a separated ticket > that is re-organize headers/implementation files. > > How do you think? > > Regards, Vu > >> -Original Message- >> From:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, Regarding your suggestion, I think we should do it in a separated ticket that is re-organize headers/implementation files. How do you think? Regards, Vu > -Original Message- > From: A V Mahesh [mailto:mahesh.va...@oracle.com] > Sent: Friday, April 28, 2017 4:56 AM > To:

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh, The function `lgs_ckpt_stream_open` has a check on node status. Only do checkpoint if the current node status is ACTIVE. That check is removed from your patch. To make sure checkpoint should only be done on active node, I suggest adding that check in the beginning of your newly

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh, On 4/27/2017 5:14 PM, Canh Van Truong wrote: > As current design, the configuration stream is just deleted (e.g. immcfg -d > ) I did see that , near future we my need to associated client when deleting the stream the that is way my comment was irrelevant of clientId used or not for

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, Handling of checkpoint for stream close is in several places. Maybe we could refactor to handle in one place to make clean code. But it is not related to this ticket. We could refactor it in later ? Regards Canh -Original Message- From: Canh Van Truong

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, As current design, the configuration stream is just deleted (e.g. immcfg -d ) if the stream is opened only one time at creating cfg stream (stream->numOpeners = 1). You can check at "stream_ccb_completed_delete" function If stream->numOpeners > 1, the activity deleting

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh, On 4/27/2017 12:34 PM, Canh Van Truong wrote: > For checkpoint stream open in proc_stream_open_msg, lgs need update a > valid client_id for checkpoint data I was asking, is For checkpoint stream close in proc_stream_close_msg, lgs need update a valid client_id for checkpoint data ?

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Mahesh, For checkpoint stream open in proc_stream_open_msg, lgs need update a valid client_id for checkpoint data For checkpoint stream open in create configuration stream (in stream_ccb_apply_create) and in encode the cold sync (edu_enc_streams), lgs update an invalid client_id (-1)

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh Van, As if you are updating client_id while lgs_ckpt_stream_open() checkpoint is client_id not required as reference to while ckpt_stream_close() checkpoint ? currently this assigned to -1. -AVM On 4/25/2017 6:58 PM, Canh Van Truong wrote: > Handling of checkpoint for stream open is

[devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Handling of checkpoint for stream open is in serveral places. Handling of checkpoint is called in proc_stream_open_msg forgot to add checkpoint of destination name. Refactor so that handling of checkpoint data for stream open is done in one place and destination name was already added in

Re: [devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

Hi Canh Comment: Handling check-pointing of stream open info is done locally in several places. This problem was caused because adding check-pointing of destination name was forgotten in one of these places. Refactor so that handling of checkpoint data for stream open is done in one place

[devel] [PATCH 1/1] log: fix checkpoint dest_names in open stream request [#2434]

The patch add dest_names in checkpointing at open stream request. --- src/log/logd/lgs_evt.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/log/logd/lgs_evt.cc b/src/log/logd/lgs_evt.cc index 6972efe55..fcc02de63 100644 --- a/src/log/logd/lgs_evt.cc +++ b/src/log/logd/lgs_evt.cc @@