Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-28 Thread Rafael Odzakow
ACK, not tested. On 04/27/2017 03:10 PM, Lennart Lund wrote: > SMF has an IMM applier to track changes of attribute longDnsAllowed in > OpensafImm class. > Fix that the applier does not find the value if the list of attributes to be > handled in the > apply callback contains more than one

Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-27 Thread Neelakanta Reddy
Hi Leenart, Yes, push the patch, with all #2442 changes. Reviewed and tested the patch. Ack. /Neel. On 2017/04/27 07:40 PM, Lennart Lund wrote: > Hi Neel, > > I am not sure I understand what you mean? > All of the #2442 changes are needed not only the "> + attribute = > attrMod->modAttr;"

Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-27 Thread Lennart Lund
Hi Neel, I am not sure I understand what you mean? All of the #2442 changes are needed not only the "> + attribute = attrMod->modAttr;" fix. I suggest that you push your #2431 patch as is after the #2442 fix is pushed Thanks Lennart > -Original Message- > From: Neelakanta Reddy

Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-27 Thread Neelakanta Reddy
Hi Lennart, From IMM Version A.2.17, the IMM modify callback will have canonical attributes. All the attributes in the class along with the modified attributes. The code in CcbApplyCallback in the file "src/smf/smfd/SmfImmApplierHdl.cc", if the attrmods are more than one then the following

Re: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-27 Thread Zoran Milinkovic
...@oracle.com; Rafael Odzakow <rafael.odza...@ericsson.com> Cc: opensaf-devel@lists.sourceforge.net Subject: [devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442] SMF has an IMM applier to track changes of attribute longDnsAllowed in OpensafImm clas

[devel] [PATCH 1/1] smf: Attribute value handling in longDn applier is incorrect [#2442]

2017-04-27 Thread Lennart Lund
SMF has an IMM applier to track changes of attribute longDnsAllowed in OpensafImm class. Fix that the applier does not find the value if the list of attributes to be handled in the apply callback contains more than one attribute. Also if the found attribute is not the serached one the cached