Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

@Suryanarayana: I think this fix makes AMFND a bit defensive, but let's see Mahesh's comments @Mahesh: If getting NCSMDS_DOWN, then there's no active to wait, so MDS should stop this timer? On 26/04/17 15:45, Suryanarayana.Garlapati wrote: > Might be i guess this fix needs to be done at the

Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

Other services might have similar functionality. So its better to fix the root cause and not at each and every service. On Wednesday 26 April 2017 12:05 PM, minh chau wrote: > > @Suryanarayana: I think this fix makes AMFND a bit defensive, but > let's see Mahesh's comments > @Mahesh: If

Re: [devel] [PATCH 1/1] smf: updated the imm API vesrion to latest supported [#2431]

Hi Lennart, The problem is happening when the IMM OI version is greater than A.2.16. I tested with A.2.16 its working fine. Test with A.2.16 and let me know the result. If the tests are passing the IMM version for src/smf/smfd/SmfImmApplierHdl.h will be changed to A.2.16 before pushing the

Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

Might be i guess this fix needs to be done at the MDS level, not at the AMFND, taking into consideration that the cluster has only two Controllers. Timer which is getting started at MDS should not be started(if started should be stopped) in case of getting the down for both of the amfd's.

[devel] [PATCH 0/1] Review Request for log: generate hash only if having destination name set [#2438]

Summary: log: generate hash only if having destination name set [#2438] Review request for Ticket(s): 2438 Peer Reviewer(s): Lennart, Canh, Mahesh Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE *** Affected branch(es): develop, release Development branch: ticket-2438 Base revision:

[devel] [PATCH 1/1] log: generate hash only if having destination name set [#2438]

rfc5424_msgid is only referred when streaming and having destination name set on that log stream. It means it does meaningless job sometimes, that is do hash calculation even there is no destination name set. This ticket will fix that. --- src/log/logd/lgs_dest.cc | 6 ++

Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

Hi Gary, If I understand, before 5.2, while running campaign SMF used to set saAmfSUMaintenanceCampaign attribute in affected SUs using CCB operations. Since AMF feature "Restrictions to auto repair" was not implemented (implemented in #2144, 5.2), AMF was still taking actions if components

Re: [devel] [PATCH 1/1] smf: updated the imm API vesrion to latest supported [#2431]

Hi Neel In SMF the value of long dn attribute is cached and an applier is used to handle updates. I am creating a fix for the applier that will lock reading of this cached value when getting the completed callback (a change is most likely going to happen) and updating of the cached variable

Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

Hi Praveen >From talking with some SMF maintainers, some applications could be using >saAmfSUMaintenanceCampaign even though AMF does not. So in terms of backwards compatibility, it is better to put this configuration in AMF instead. Thanks Gary -Original Message- From: praveen

Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

On 26-Apr-17 3:25 PM, Gary Lee wrote: > Hi Praveen > > From talking with some SMF maintainers, some applications could be using > saAmfSUMaintenanceCampaign even though AMF does not. How it is exposed to the application? I guess an SMF application can register for SMF callback

Re: [devel] [PATCH 1/1] amfd: make auto repair restriction configurable [#2435]

Hi Praveen Also, most of the code changes is just replacing ‘!su->saAmfSUMaintenanceCampaign.empty()’ with ‘restrict_auto_repair() == true’, which arguably is clearer to read. Apart from that, there is a small change to not to send the campaign in the notification to SMF if the restrict auto

Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

Hi Mahesh, The sequence is going like this: - Stop both SCs, amfnd receives 2 NCSMDS_DOWN, one is Adest, one is Vdest. I guess at this point MDS tells that both standby and active amfd are down? 2017-04-26 21:13:52 PL-4 osafamfnd[413]: WA AMF director unexpectedly crashed - Leave

Re: [devel] [PATCH 1/1] imm: Improve ccb error string handling [#2367]

Hi Hieu, Reviewed the patch and IMM code again. Ack from me. Thanks, Zoran -Original Message- From: Zoran Milinkovic [mailto:zoran.milinko...@ericsson.com] Sent: den 25 april 2017 13:33 To: Hieu Thanh Nguyen ; reddy.neelaka...@oracle.com; Hung Duc Nguyen

Re: [devel] [PATCH 1/1] amfnd: Fix illegal memory access in avnd_comptype_delete [#2424]

Ack (review only) On 25/4/17, 4:51 pm, "Hoa Le" wrote: Problem: - There are some unsafe memory accesses which may cause segfault in avnd_comptype_delete() function. Fix: - Check if a pointer is valid before accessing it. - Minor update in

Re: [devel] [PATCH 1/1] amf: support amf tool command to know AMF cluster/nodes status [#2354]

Hi Praveen Ack with 2 minor comments below [GL]. Also errors should probably go to stderr. Thanks Gary On 14/4/17, 9:43 pm, "praveenmalviya" wrote: With this command, a user can know the status of nodes in AMF cluster. For example: 1)normal cluster

Re: [devel] [PATCH 1/1] amf: validate env variable format set in comptype/comp objects [#2409]

Hi Nguyen Some comments below. Thanks On 13/4/17, 10:48 pm, "Nguyen Luu" wrote: Valid environment variable should have the format 'var=value'. AMF currently does not validate this format during CREATE CCBs for comptype and comp objects (MODIFY

Re: [devel] [PATCH 1/1] amfnd: Ignore second NCSMDS_DOWN [#2436]

Hi Minh chau, On 4/26/2017 5:43 PM, minh chau wrote: > > - Stop both SCs, amfnd receives 2 NCSMDS_DOWN, one is Adest, one is Vdest I don't seen unnatural events from MDS, as amfnd might have subsided for them. Currently transport (MDS) functionality doesn't provide event differently for

Re: [devel] [PATCH 1/1] amfnd: Fix illegal memory access in avnd_comptype_delete [#2424]

Ack, code review only, I assume you had run some regression on it. Thanks -Nagu > -Original Message- > From: Hoa Le [mailto:hoa...@dektech.com.au] > Sent: 25 April 2017 12:21 > To: gary@dektech.com.au; hans.nordeb...@ericsson.com; > minh.c...@dektech.com.au; nagendr...@oracle.com; >