Hi Leenart,
Yes, push the patch, with all #2442 changes.
Reviewed and tested the patch.
Ack.
/Neel.
On 2017/04/27 07:40 PM, Lennart Lund wrote:
> Hi Neel,
>
> I am not sure I understand what you mean?
> All of the #2442 changes are needed not only the "> + attribute =
> attrMod->modAttr;"
---
src/amf/amfnd/susm.cc | 10 ++
1 file changed, 10 insertions(+)
diff --git a/src/amf/amfnd/susm.cc b/src/amf/amfnd/susm.cc
index 52af63b83..04ced426d 100644
--- a/src/amf/amfnd/susm.cc
+++ b/src/amf/amfnd/susm.cc
@@ -1608,6 +1608,16 @@ uint32_t avnd_su_pres_fsm_run(AVND_CB *cb,
Summary: amf: send oper_state when NCS SUs already instantiated [#2443]
Review request for Ticket(s): 2443
Peer Reviewer(s): AMF devs
Pull request to: AMF maintainers
Affected branch(es): develop, release
Development branch: ticket-2443
Base revision: 94fe6f2ca5c34bafc86f001807ea08ce39f60a34
Hi Canh,
On 4/27/2017 5:14 PM, Canh Van Truong wrote:
> As current design, the configuration stream is just deleted (e.g. immcfg -d
> )
I did see that , near future we my need to associated client when
deleting the stream
the that is way my comment was irrelevant of clientId used or not for
Hi Hans N,
ACK .
This patch will also resolve My another problem , which ia have been
debugging related to clock_gettime(CLOCK_MONOTONIC)
-AVM
On 4/27/2017 7:25 PM, Hans Nordeback wrote:
> ---
> src/base/sysf_tmr.c | 20 +---
> 1 file changed, 17 insertions(+), 3
Hi Neel,
I am not sure I understand what you mean?
All of the #2442 changes are needed not only the "> + attribute =
attrMod->modAttr;" fix.
I suggest that you push your #2431 patch as is after the #2442 fix is pushed
Thanks
Lennart
> -Original Message-
> From: Neelakanta Reddy
---
src/base/sysf_tmr.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/base/sysf_tmr.c b/src/base/sysf_tmr.c
index d4bd8de12..42679e103 100644
--- a/src/base/sysf_tmr.c
+++ b/src/base/sysf_tmr.c
@@ -447,12 +447,14 @@ static uint32_t
Summary: base: Blocking send causes AMF health check time-out [#2278]
Review request for Ticket(s): 2278
Peer Reviewer(s): Ramesh, AndersW, Mahesh
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop, 5.1, 5.2
Development branch: ticket-2278
Base revision:
Hi Lennart,
From IMM Version A.2.17, the IMM modify callback will have canonical
attributes.
All the attributes in the class along with the modified attributes.
The code in CcbApplyCallback in the file
"src/smf/smfd/SmfImmApplierHdl.cc", if the attrmods are more than one
then the following
Hi Lennart,
You have a typo in the comment you've changed.
SMF is only interested in longDnsAllowed attribute, and not in
opensafNetworkName
Thanks,
Zoran
-Original Message-
From: Lennart Lund [mailto:lennart.l...@ericsson.com]
Sent: den 27 april 2017 15:10
To:
SMF has an IMM applier to track changes of attribute longDnsAllowed in
OpensafImm class.
Fix that the applier does not find the value if the list of attributes to be
handled in the
apply callback contains more than one attribute. Also if the found attribute is
not the serached
one the cached
Summary: smf: Attribute value handling in longDn applier is incorrect [#2442]
Review request for Ticket(s): 2442
Peer Reviewer(s): rafael.odza...@ericsson.com, reddy.neelaka...@oracle.com
Pull request to: *** LIST THE PERSON WITH PUSH ACCESS HERE ***
Affected branch(es): develop
Development
Hi Mahesh,
Handling of checkpoint for stream close is in several places. Maybe we could
refactor to handle in one place to make clean code.
But it is not related to this ticket. We could refactor it in later ?
Regards
Canh
-Original Message-
From: Canh Van Truong
Hi Mahesh,
As current design, the configuration stream is just deleted (e.g. immcfg -d
) if the stream is opened only one time at creating cfg stream
(stream->numOpeners = 1). You can check at "stream_ccb_completed_delete"
function
If stream->numOpeners > 1, the activity deleting
Hi Neel
The value of longDnsAllowed is cached in SMF. This is done by reading the
attribute at start up and using an applier to get runtime changes. The current
handling is that the cached value is updated in the applier "apply callback"
when the attribute value is changed. Based on the
Hi Canh,
On 4/27/2017 12:34 PM, Canh Van Truong wrote:
> For checkpoint stream open in proc_stream_open_msg, lgs need update a
> valid client_id for checkpoint data
I was asking, is For checkpoint stream close in proc_stream_close_msg,
lgs need update a valid client_id for checkpoint data ?
Hi Mahesh,
For checkpoint stream open in proc_stream_open_msg, lgs need update a valid
client_id for checkpoint data
For checkpoint stream open in create configuration stream (in
stream_ccb_apply_create) and in encode the cold sync (edu_enc_streams), lgs
update an invalid client_id (-1)
Hi Canh Van,
As if you are updating client_id while lgs_ckpt_stream_open() checkpoint
is client_id not required as reference to while ckpt_stream_close()
checkpoint ?
currently this assigned to -1.
-AVM
On 4/25/2017 6:58 PM, Canh Van Truong wrote:
> Handling of checkpoint for stream open is
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Opensaf-devel mailing list
19 matches
Mail list logo
