Coverity Scan: Analysis completed for openssl/openssl

2024-05-01 Thread scan-admin


Your request for analysis of openssl/openssl has been completed 
successfully.
The results are available at 
https://u15810271.ct.sendgrid.net/ls/click?upn=u001.AxU2LYlgjL6eX23u9ErQy-2BKADyCpvUKOL6EWmZljiu7On3ENqKj59w4rEawU-2BYZgjBJ8Ay1pFYeVslaCebcWhw-3D-3DKv6Y_bGLyfjQQhnPAMp6Vz8xksML07NHC5l7WMnVZN7GWb6olHhhIr3PDep33O2iH-2FBMwPhoBGdWyUgKqvWL9Y2MXGgUmOQqDmwX5Ra2Tqd-2Fl5ZOVUswv0mj2sYY26q4Pw5rZGGe5wRItX2UBLHKYwBNv8xJkUcgtuERn2I6ch0j6sJEgzY4bS8WP-2BI4EsnlZ797HTp2P-2FC5GZs8Dic20-2FkYAtA-3D-3D

Build ID: 609997

Analysis Summary:
   New defects found: 0
   Defects eliminated: 0



[openssl/tools] 352d32: adjust newraw key to record time like the handshak...

2024-05-01 Thread Neil Horman
  Branch: refs/heads/fix-stats
  Home:   https://github.com/openssl/tools
  Commit: 352d322c2ca5530de14f24436b92d550cfde0c77
  
https://github.com/openssl/tools/commit/352d322c2ca5530de14f24436b92d550cfde0c77
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/newrawkey.c

  Log Message:
  ---
  adjust newraw key to record time like the handshake test

the handshake test records the average time of each thread running
its test, while other tests record the overall duration, leading to
inconsistencies in how we do measurement.

Bring newrawkey into line with how handshake does it.


  Commit: 8a3e7cae16dfe86877c7f9188471e07164812e40
  
https://github.com/openssl/tools/commit/8a3e7cae16dfe86877c7f9188471e07164812e40
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/pemread.c

  Log Message:
  ---
  convert pemread to be consistent in its time measurement

like handshake and newrawkey, record times per thread and average them


  Commit: 7b5e2edc8bc51970e86dc9125944acdad40c2ae9
  
https://github.com/openssl/tools/commit/7b5e2edc8bc51970e86dc9125944acdad40c2ae9
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/providerdoall.c

  Log Message:
  ---
  Convert providerdoall to be consistent in time measurement

Convert it to do the same math the other tests do


  Commit: 18ada4f6390ede55dbe4aa45a80899223277ff2f
  
https://github.com/openssl/tools/commit/18ada4f6390ede55dbe4aa45a80899223277ff2f
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/randbytes.c

  Log Message:
  ---
  convert randbytes to use consistent time measurements

modify randbytes to measure time the way the other tests do


  Commit: a4ccf92b254c5ed51aebe19db12aeaaa5576b077
  
https://github.com/openssl/tools/commit/a4ccf92b254c5ed51aebe19db12aeaaa5576b077
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/rsasign.c

  Log Message:
  ---
  make rsasign measure time consistently

Like the other tests, measure time per thread and average those


  Commit: 4ca43da6822c3aee640522c526ae515e40893a73
  
https://github.com/openssl/tools/commit/4ca43da6822c3aee640522c526ae515e40893a73
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/sslnew.c

  Log Message:
  ---
  convert sslnew to measure time consistently

Make it do the same math the other tests do


  Commit: 13fe31415f8a2333b13fd8691ad20156fa2cdbfe
  
https://github.com/openssl/tools/commit/13fe31415f8a2333b13fd8691ad20156fa2cdbfe
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/x509storeissuer.c

  Log Message:
  ---
  make x509storeissuer do timekeeping like the other tests

Also, while I'm in here, fix an aliasing issue in threadcount, in which
the main routine had a variable overriding the global one.


  Commit: cdd4959a97f99488df9f51cecd30b54d469733a1
  
https://github.com/openssl/tools/commit/cdd4959a97f99488df9f51cecd30b54d469733a1
  Author: Neil Horman 
  Date:   2024-04-30 (Tue, 30 Apr 2024)

  Changed paths:
M perf/newrawkey.c
M perf/pemread.c
M perf/providerdoall.c
M perf/rsasign.c

  Log Message:
  ---
  fixup! make x509storeissuer do timekeeping like the other tests


Compare: https://github.com/openssl/tools/compare/352d322c2ca5%5E...cdd4959a97f9

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/tools/settings/notifications


[openssl/openssl] eb3b90: Use OSSL_TIME instead of using arithmetic directly...

2024-05-01 Thread Matt Caswell
  Branch: refs/heads/openssl-3.3
  Home:   https://github.com/openssl/openssl
  Commit: eb3b903af9b8de754f198a4ea5ea239f3721e3ee
  
https://github.com/openssl/openssl/commit/eb3b903af9b8de754f198a4ea5ea239f3721e3ee
  Author: Matt Caswell 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M test/sslapitest.c

  Log Message:
  ---
  Use OSSL_TIME instead of using arithmetic directly on time_t

We have functions for adding/subtracting time. We should use them.

Reviewed-by: Tomas Mraz 
Reviewed-by: Neil Horman 
(Merged from https://github.com/openssl/openssl/pull/23966)

(cherry picked from commit afb6ce0d0f5b8e88f8b4f420aba0a8e59f58934f)


  Commit: 91d5fd54ee3ad87b5d3a57668e8dc9495d72bab6
  
https://github.com/openssl/openssl/commit/91d5fd54ee3ad87b5d3a57668e8dc9495d72bab6
  Author: Matt Caswell 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M test/build.info
M test/sslapitest.c

  Log Message:
  ---
  Fix intermittent sslapitest early data related failures

Early data is time sensitive. We have an approx 8 second allowance between
writing the early data and reading it. If we exceed that time tests will
fail. This can sometimes (rarely) occur in normal CI operation. We can try
and detect this and just ignore the result of such test failures if the test
has taken too long. We assume anything over 7 seconds is too long.

This is a partial fix for #22605

Reviewed-by: Tomas Mraz 
Reviewed-by: Neil Horman 
(Merged from https://github.com/openssl/openssl/pull/23966)

(cherry picked from commit 1848c561ec39a9ea91ff1bf740a554be274f98b0)


Compare: https://github.com/openssl/openssl/compare/bbae0c9f05f3...91d5fd54ee3a

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications


[openssl/openssl] afb6ce: Use OSSL_TIME instead of using arithmetic directly...

2024-05-01 Thread Matt Caswell
  Branch: refs/heads/master
  Home:   https://github.com/openssl/openssl
  Commit: afb6ce0d0f5b8e88f8b4f420aba0a8e59f58934f
  
https://github.com/openssl/openssl/commit/afb6ce0d0f5b8e88f8b4f420aba0a8e59f58934f
  Author: Matt Caswell 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M test/sslapitest.c

  Log Message:
  ---
  Use OSSL_TIME instead of using arithmetic directly on time_t

We have functions for adding/subtracting time. We should use them.

Reviewed-by: Tomas Mraz 
Reviewed-by: Neil Horman 
(Merged from https://github.com/openssl/openssl/pull/23966)


  Commit: 1848c561ec39a9ea91ff1bf740a554be274f98b0
  
https://github.com/openssl/openssl/commit/1848c561ec39a9ea91ff1bf740a554be274f98b0
  Author: Matt Caswell 
  Date:   2024-05-01 (Wed, 01 May 2024)

  Changed paths:
M test/build.info
M test/sslapitest.c

  Log Message:
  ---
  Fix intermittent sslapitest early data related failures

Early data is time sensitive. We have an approx 8 second allowance between
writing the early data and reading it. If we exceed that time tests will
fail. This can sometimes (rarely) occur in normal CI operation. We can try
and detect this and just ignore the result of such test failures if the test
has taken too long. We assume anything over 7 seconds is too long.

This is a partial fix for #22605

Reviewed-by: Tomas Mraz 
Reviewed-by: Neil Horman 
(Merged from https://github.com/openssl/openssl/pull/23966)


Compare: https://github.com/openssl/openssl/compare/af75373eeab6...1848c561ec39

To unsubscribe from these emails, change your notification settings at 
https://github.com/openssl/openssl/settings/notifications