Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-19 Thread Kevin Benton
You can't upload directly. You have to follow the same gerrit review process as submitting regular code. Run 'git review' from the root of the neutron-specs folder. -- Kevin Benton On Fri, Apr 18, 2014 at 10:47 PM, Nader Lahouti nader.laho...@gmail.comwrote: Do I need any permission to upload

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-18 Thread Nader Lahouti
Do I need any permission to upload a design specification in the 'specs/juno' folder in neutron-specs? I tried to upload and get this message: fatal: unable to access 'https://github.com/openstack/neutron-specs.git/': The requested URL returned error: 403 Please advise. Thanks, Nader. On

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-17 Thread Carl Baldwin
Sure thing [1]. The easiest change I saw was to remove the restriction that the number of sub titles is exactly 9. This won't require any of the other blueprints already posted for review to change. See what you think. Carl [1] https://review.openstack.org/#/c/88381/ On Wed, Apr 16, 2014 at

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-17 Thread Kyle Mestery
On Thu, Apr 17, 2014 at 1:18 PM, Carl Baldwin c...@ecbaldwin.net wrote: Sure thing [1]. The easiest change I saw was to remove the restriction that the number of sub titles is exactly 9. This won't require any of the other blueprints already posted for review to change. See what you think.

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-17 Thread Carl Baldwin
Wow, easiest merge ever! Can we get this repository counted in our stats?! ;) Carl On Thu, Apr 17, 2014 at 1:09 PM, Kyle Mestery mest...@noironetworks.com wrote: On Thu, Apr 17, 2014 at 1:18 PM, Carl Baldwin c...@ecbaldwin.net wrote: Sure thing [1]. The easiest change I saw was to remove

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Gary Kotton
+1 On 4/16/14 1:35 AM, Carl Baldwin c...@ecbaldwin.net wrote: +1. I think we'll like this process better. I hope to have some of the first blueprints to propose to the new repository very soon. On Tue, Apr 15, 2014 at 4:07 PM, Kyle Mestery mest...@noironetworks.com wrote: Given the success

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread mar...@redhat.com
On 16/04/14 00:07, Kyle Mestery wrote: Given the success the Nova team has had in handling reviews using their new nova-specs gerrit repository, I think it makes a lot of sense for Neutron to do the same. With this in mind, I've added instructions to the BP wiki [1] for how to do. Going

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Kyle Mestery
I think the problem is that your spec should be at the toplevel of the juno directory, and that's why the UT is failing. Can you move your spec up a level, including the image? You can create a spec images directory to put them in there and reference it in the spec as well if you want. On Tue,

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Salvatore Orlando
if the image you're adding is a diagram, I would think about asciiflow.comfirst! On 16 April 2014 15:09, Kyle Mestery mest...@noironetworks.com wrote: I think the problem is that your spec should be at the toplevel of the juno directory, and that's why the UT is failing. Can you move your

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Kyle Mestery
Actually, +1 to that Salvatore! I've found asciiflow.com to be superb for these types of things. On Wed, Apr 16, 2014 at 8:39 AM, Salvatore Orlando sorla...@nicira.com wrote: if the image you're adding is a diagram, I would think about asciiflow.com first! On 16 April 2014 15:09, Kyle

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Russell Bryant
On 04/16/2014 09:39 AM, Salvatore Orlando wrote: if the image you're adding is a diagram, I would think about asciiflow.com http://asciiflow.com first! In all seriousness, I think that's a very nice solution for simple diagrams. :-) For other diagrams, I wonder if it makes sense to just

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread trinath.soman...@freescale.com
, 2014 7:22 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [neutron] Neutron BP review process for Juno Actually, +1 to that Salvatore! I've found asciiflow.com to be superb for these types of things. On Wed, Apr 16, 2014 at 8:39 AM, Salvatore

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Russell Bryant
On 04/16/2014 09:51 AM, Russell Bryant wrote: On 04/16/2014 09:39 AM, Salvatore Orlando wrote: if the image you're adding is a diagram, I would think about asciiflow.com http://asciiflow.com first! In all seriousness, I think that's a very nice solution for simple diagrams. :-) For

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Kyle Mestery
On Wed, Apr 16, 2014 at 12:23 PM, Russell Bryant rbry...@redhat.com wrote: On 04/16/2014 09:51 AM, Russell Bryant wrote: On 04/16/2014 09:39 AM, Salvatore Orlando wrote: if the image you're adding is a diagram, I would think about asciiflow.com http://asciiflow.com first! In all seriousness,

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Nachi Ueno
Hi folks I don't think to use ASCII digrams is good idea because it is hard to maintenance update diagrams.. so I would like to recommend Blockdiag Netdiag which are plugins for sphinx. Blockdiag http://blockdiag.com/en/blockdiag/ blockdiag { A - B - C - D; A - E - F - G; } will be

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Collins, Sean
Nice!! nwdiag would make things really easy. -- Sean M. Collins ___ OpenStack-dev mailing list OpenStack-dev@lists.openstack.org http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Alan Kavanagh
agree the simplest and quickest way is a better use of our time. /Alan -Original Message- From: Nachi Ueno [mailto:na...@ntti3.com] Sent: April-16-14 3:19 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [neutron] Neutron BP review process

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Eugene Nikanorov
the simplest and quickest way is a better use of our time. /Alan -Original Message- From: Nachi Ueno [mailto:na...@ntti3.com] Sent: April-16-14 3:19 PM To: OpenStack Development Mailing List (not for usage questions) Subject: Re: [openstack-dev] [neutron] Neutron BP review process for Juno

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Carl Baldwin
Neutron (and Nova), I have had one thing come up as I've been using the template. I find that I would like to add just a little document structure in the form of a sub-heading or two under the Proposed change heading but before the required Alternatives sub-heading. However, this is not allowed

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Kyle Mestery
On Wed, Apr 16, 2014 at 4:26 PM, Carl Baldwin c...@ecbaldwin.net wrote: Neutron (and Nova), I have had one thing come up as I've been using the template. I find that I would like to add just a little document structure in the form of a sub-heading or two under the Proposed change heading but

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-16 Thread Nachi Ueno
Hi folks My bad,, Issue (1) was my mistake, and fixed 2014-04-16 15:16 GMT-07:00 Nachi Ueno na...@ntti3.com: Hi folks I submitted a wip patch which has diagram examples for both of ascii flow and blockdiag. https://review.openstack.org/#/c/88095/1 This is both output from ascii flow and

[openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-15 Thread Kyle Mestery
Given the success the Nova team has had in handling reviews using their new nova-specs gerrit repository, I think it makes a lot of sense for Neutron to do the same. With this in mind, I've added instructions to the BP wiki [1] for how to do. Going forward in Juno, this is how Neutron BPs will be

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-15 Thread Nachi Ueno
+10 ! 2014-04-15 15:07 GMT-07:00 Kyle Mestery mest...@noironetworks.com: Given the success the Nova team has had in handling reviews using their new nova-specs gerrit repository, I think it makes a lot of sense for Neutron to do the same. With this in mind, I've added instructions to the

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-15 Thread Carl Baldwin
+1. I think we'll like this process better. I hope to have some of the first blueprints to propose to the new repository very soon. On Tue, Apr 15, 2014 at 4:07 PM, Kyle Mestery mest...@noironetworks.com wrote: Given the success the Nova team has had in handling reviews using their new

Re: [openstack-dev] [neutron] Neutron BP review process for Juno

2014-04-15 Thread Sumit Naiksatam
What's the convention for adding images to the patch? The following directory structure seemed logical to me (but the current UT will not allow it): specs/juno/bp-name/bp-name.rst specs/juno/bp-name/images/image1.png Thanks, ~Sumit. On Tue, Apr 15, 2014 at 3:35 PM, Carl Baldwin