Re: [openstack-dev] [nova] Super fun unshelve image_ref bugs

On 12/1/2017 2:47 PM, Matt Riedemann wrote: Andrew Laski also mentioned in IRC that we didn't replace the original instance.image_ref with the shelved image id because the shelve operation should be transparent to the end user, they have the same image (not really), same volumes, same IPs, etc

Re: [openstack-dev] [nova] Super fun unshelve image_ref bugs

On Fri, Dec 1, 2017 at 2:47 PM, Matt Riedemann wrote: > Andrew Laski also mentioned in IRC that we didn't replace the original > instance.image_ref with the shelved image id because the shelve operation > should be transparent to the end user, they have the same image (not >

Re: [openstack-dev] [nova] Super fun unshelve image_ref bugs

On 12/1/2017 1:25 PM, Mathieu Gagné wrote: Hi, On Fri, Dec 1, 2017 at 12:24 PM, Matt Riedemann wrote: I think we can assert as follows: 2. If we're going to point the instance at an image_ref, we shouldn't delete that image. I don't have a good reason why besides

Re: [openstack-dev] [nova] Super fun unshelve image_ref bugs

Hi, On Fri, Dec 1, 2017 at 12:24 PM, Matt Riedemann wrote: > > I think we can assert as follows: > > 2. If we're going to point the instance at an image_ref, we shouldn't delete > that image. I don't have a good reason why besides deleting things which > nova has a reference

[openstack-dev] [nova] Super fun unshelve image_ref bugs

I came across this bug during triage today: https://bugs.launchpad.net/nova/+bug/1732428 It essentially says that unshelving an instance and then resizing that instance later, depending on the type of image backend, can fail. It's pointed out that when we complete the unshelve procedure, we