Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/326?usp=email )
Change subject: Remove last uses of inet_ntoa
..
Patch Set 1:
Attention is currently required from: d12fk, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/40?usp=email )
Change subject: dns option: make server id/priority optional
..
inet_ntoa is officially deprecated and in some places
its use already causes warnings (e.g. Fedora submissions).
Since we mostly use inet_ntop already, just convert the
remaining usages to that.
Change-Id: I052bebe720ddf26340827f25b94705945e470bfa
Signed-off-by: Frank Lichtenheld
Acked-by: Arne
These are all not actually problems, since the
uninitialized parts are either .unused members of the
struct (mroute_addr) or only written to (buflen), but
still doesn't hurt to explicitely initialize them.
Change-Id: I45cd0917d24570ae9e9db7eb6c370756e4595842
Signed-off-by: Frank Lichtenheld
The previous code went through some hoops
to avoid compiler warnings. But there is
a much easier way by just telling it
exactly what you want to do.
Also fix typo in variable name while I'm
here.
Change-Id: Icc86334b26ba1fcc20f4cd03644018d1d16796e3
Signed-off-by: Frank Lichtenheld
Acked-by:
Half of them used unsigned int, the other half size_t.
Standardize on one. Could've also standardized on the
other, both are much too big for the expected numbers
anyway.
Add a new utility function clamp_size_to_int for
cases we need to change from size_t to int (there
are a lot of those all over
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/269?usp=email )
Change subject: mss/mtu: make all size calculations use size_t
..
mss/mtu: make all size calculations use size_t
Half
flichtenheld has uploaded this change for review. (
http://gerrit.openvpn.net/c/openvpn/+/310?usp=email )
Change subject: generate_auth_token: simplify code
..
generate_auth_token: simplify code
The previous code went through
Attention is currently required from: flichtenheld, plaisthos.
Hello cron2, plaisthos,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/268?usp=email
to look at the new patch set (#4).
Change subject: Change type of frame.mss_fix to uint16_t
Attention is currently required from: cron2, plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/268?usp=email )
Change subject: Change type of frame.mss_fix to uint16_t
..
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/310?usp=email )
Change subject: generate_auth_token: simplify code
..
Patch Set 2:
Attention is currently required from: stipa.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/368?usp=email )
Change subject: dco: warn if DATA_V1 packets are sent to userspace
..
Patch
From: Lev Stipakov
Servers 2.4.0 - 2.4.4 support peer-id and AEAD ciphers,
but only send DATA_V1 packets. With DCO enabled on the
client, connection is established but not working.
This is because DCO driver(s) are unable to handle
DATA_V1 packets and forwards them to userspace, where
they
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/364?usp=email
to look at the new patch set (#4).
Change subject: Print server temp key details
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/365?usp=email
to look at the new patch set (#5).
Change subject: Print SSL peer signature information in handshake debug details
Attention is currently required from: flichtenheld, stipa.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/367?usp=email )
Change subject: dco-win: get driver version
..
Patch Set 3:
Attention is currently required from: cron2, d12fk, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/361?usp=email )
Change subject: dev-tools/gerrit-send-mail.py: tool to send Gerrit patchsets to
Patchwork
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/318?usp=email )
Change subject: Fix various "Uninitialized scalar variable" warnings from
Coverity
From: Lev Stipakov
Print dco-win driver version using the new ioctl.
Requires dco-win driver 1.0.0 or newer to work.
Change-Id: I1d0d909e7fca3f51b5c848f1a771a989ab040f17
Signed-off-by: Lev Stipakov
Acked-by: Arne Schwabe
---
This change was reviewed on Gerrit and approved by at least one
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/366?usp=email )
Change subject: Add warning for the --show-groups command that some groups are
missing
Attention is currently required from: cron2, flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/268?usp=email )
Change subject: Change type of frame.mss_fix to uint16_t
..
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/364?usp=email )
Change subject: Print server temp key details
..
Patch Set 4:
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )
Change subject: Remove ability to use configurations without TLS by default
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/325?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed:
Code-Review-1 by
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server
Attention is currently required from: plaisthos.
flichtenheld has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/365?usp=email )
Change subject: Print SSL peer signature information in handshake debug details
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/364?usp=email
to look at the new patch set (#5).
The following approvals got outdated and were removed:
Code-Review+1
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/366?usp=email
to look at the new patch set (#6).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Attention is currently required from: flichtenheld, plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/364?usp=email
to look at the new patch set (#6).
Change subject: Print peer temporary key details
Attention is currently required from: plaisthos.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/366?usp=email
to look at the new patch set (#7).
The change is no longer submittable: checks~ChecksSubmitRule is unsatisfied now.
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )
Change subject: Remove ability to use configurations without TLS by default
Attention is currently required from: flichtenheld.
Hello flichtenheld,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/364?usp=email
to look at the new patch set (#3).
Change subject: Print server temp key details
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/325?usp=email )
Change subject: Remove ability to use configurations without TLS by default
Attention is currently required from: flichtenheld.
plaisthos has posted comments on this change. (
http://gerrit.openvpn.net/c/openvpn/+/323?usp=email )
Change subject: Add warning if a p2p NCP client connects to a p2mp server
37 matches
Mail list logo
